Skip to contentSkip to conversation

SUNRPC: correct error code comment in xs_tcp_setup_socket()

PATCH New Calum Mackay 1 participant 1 message Oct 24, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SUNRPC: correct error code comment in xs_tcp_setup_socket()

This comment was introduced by commit 6ea44adce915 ("SUNRPC: ensure correct error is reported by xs_tcp_setup_socket()").

I believe EIO was a typo at the time: it should have been EAGAIN.

Subsequently, commit 0445f92c5d53 ("SUNRPC: Fix disconnection races") changed that to ENOTCONN.

Rather than trying to keep the comment here in sync with the code in xprt_force_disconnect(), make the point in a non-specific way.

Fixes 6ea44adce915 ("SUNRPC: ensure correct error is reported by xs_tcp_setup_socket()")
---
 net/sunrpc/xprtsock.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
net/sunrpc/xprtsock.c +2 -4
index 554e1bb4c1c7..3f11de5ad486 100644
@@ -2278,10 +2278,8 @@ static void xs_tcp_setup_socket(struct work_struct *work)
 	case -EHOSTUNREACH:
 	case -EADDRINUSE:
 	case -ENOBUFS:
-		/*
-		 * xs_tcp_force_close() wakes tasks with -EIO.
-		 * We need to wake them first to ensure the
-		 * correct error code.
+		/* xs_tcp_force_close() wakes tasks with a fixed error code.
+		 * We need to wake them first to ensure the correct error code.
 		 */
 		xprt_wake_pending_tasks(xprt, status);
 		xs_tcp_force_close(xprt);
Signature · 1 line
2.18.4