Skip to contentSkip to conversation

gitk: macOS: ignore osascript errors

PATCH In review Beat Bolli 2 participants 3 messages Oct 25, 2020 – Oct 27, 2020

lore
Share & tools
lore

Beat Bolli

author
#0 lore raw

PATCH 1/1 gitk: macOS: ignore osascript errors

Starting gitk on a macOS 10.14.6 (Mojave) system fails with the error

Error in startup script: 2020-10-25 17:16:44.568 osascript[36810:18758270]
Error loading /Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support:
dlopen(/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support, 0x0106):
code signature in (/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support) not valid for use in process: mapping process is a platform binary, but mapped file is not [[this same message repeated dozens of times]]
while executing
"exec osascript -e [format {
tell application "System Events"
set frontmost of processes whose unix id is %d to true
end te..."
invoked from within
"if {[tk windowingsystem] eq "aqua"} {
exec osascript -e [format {
tell application "System Events"
set frontmost of processes ..."
(file "./gitk" line 12265)

Ignore errors from the osascript invocation, especially because this macOS version seems to correctly place the gitk window in the foreground.

---
 gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
gitk +2 -2
index 23d9dd1..8551711 100755
@@ -12290,11 +12290,11 @@ if {[catch {package require Tk 8.4} err]} {
 
 # on OSX bring the current Wish process window to front
 if {[tk windowingsystem] eq "aqua"} {
-    exec osascript -e [format {
+    catch { exec osascript -e [format {
         tell application "System Events"
             set frontmost of processes whose unix id is %d to true
         end tell
-    } [pid] ]
+    } [pid] ] }
 }
 
 # Unset GIT_TRACE var if set
Signature · 1 line
2.28.0
#1 lore raw
Quoted 8 lines · Beat Bolli

Starting gitk on a macOS 10.14.6 (Mojave) system fails with the error

Error in startup script: 2020-10-25 17:16:44.568 osascript[36810:18758270]
Error loading /Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support:
dlopen(/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support, 0x0106):
code signature in (/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support) not valid for use in process: mapping process is a platform binary, but mapped file is not [[this same message repeated dozens of times]]

While the code change itself makes sense to me, the justification is a bit strange. This error message suggests that something is messed up on your system. Your commit message makes it sound as if all people on macOS 10.14.6 get this error, which is not the case.

Quoted 2 lines

Ignore errors from the osascript invocation, especially because this macOS version seems to correctly place the gitk window in the foreground.

Whether gitk comes to the foreground on start depends on the Tcl/Tk version, not the macOS version. With Tk 8.6 it does, so it might actually be nice to add a version check here. (I'm not requesting that you actually do that as part of this patch; just saying.)

Quoted 11 lines
---
  gitk | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
gitk +0 -0
index 23d9dd1..8551711 100755
@@ -12290,11 +12290,11 @@ if {[catch {package require Tk 8.4} err]} {
 

gitk if {[catch {package require Tk 8.4} err]} { · line 12298

Quoted 10 lines
gitk +2 -2
  # on OSX bring the current Wish process window to front
  if {[tk windowingsystem] eq "aqua"} {
-    exec osascript -e [format {
+    catch { exec osascript -e [format {
          tell application "System Events"
              set frontmost of processes whose unix id is %d to true
          end tell
-    } [pid] ]
+    } [pid] ] }
  }

Like I said, the change itself looks good to me, especially since the corresponding code in git gui is also guarded by a catch.

Best,
Stefan

author
#2 lore raw
Quoted 15 lines · Stefan Haller
Quoted 13 lines · Beat Bolli

Starting gitk on a macOS 10.14.6 (Mojave) system fails with the error

     Error in startup script: 2020-10-25 17:16:44.568 osascript[36810:18758270]
     Error loading /Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support:
     dlopen(/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support, 0x0106):
     code signature in (/Library/QuickTime/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support) not valid for use in process: mapping process is a platform binary, but mapped file is not
     [[this same message repeated dozens of times]]

Quoted 4 lines

While the code change itself makes sense to me, the justification is a bit strange. This error message suggests that something is messed up on your system. Your commit message makes it sound as if all people on macOS 10.14.6 get this error, which is not the case.

You're right; renaming the parent directory makes the error go away, but I'd still like to keep my system working with all installed software.

Quoted 8 lines
Quoted 3 lines

Ignore errors from the osascript invocation, especially because this macOS
version seems to correctly place the gitk window in the foreground.

Whether gitk comes to the foreground on start depends on the Tcl/Tk version, not the macOS version. With Tk 8.6 it does, so it might actually be nice to add a version check here. (I'm not requesting that you actually do that as part of this patch; just saying.)

wish(1) version 8.5 is bundled with macOS Mojave.

Quoted 25 lines
Quoted 15 lines

---
  gitk | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
gitk +1 -1
index 23d9dd1..8551711 100755
@@ -12290,11 +12290,11 @@ if {[catch {package require Tk 8.4} err]} {
     # on OSX bring the current Wish process window to front
   if {[tk windowingsystem] eq "aqua"} {
-    exec osascript -e [format {
+    catch { exec osascript -e [format {
Quoted 6 lines

          tell application "System Events"
              set frontmost of processes whose unix id is %d to true end tell
-    } [pid] ]
+    } [pid] ] }
  }

Like I said, the change itself looks good to me, especially since the corresponding code in git gui is also guarded by a catch.

Quoted 2 lines

Best,
Stefan

Cheers, Beat