Patch "selftests: mptcp: depends on built-in IPv6" has been added to the 5.9-stable tree
Hi Sasha,
Quoted 3 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
selftests: mptcp: depends on built-in IPv6
Thank you for backporting this patch.
(...)
Quoted 1 line
Fixes 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it")
This patch is not really needed because AFAICS this commit here above has not been backported to v5.9. It is only in v5.10-rc1.
(...)
tools/testing/selftests/net/mptcp/config line 3
Quoted 8 lines
tools/testing/selftests/net/mptcp/config +1
-0@@ -1,4 +1,5 @@ CONFIG_MPTCP=y +CONFIG_IPV6=y CONFIG_MPTCP_IPV6=y
But you can also keep this patch, it doesn't hurt: without this commit 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it"), CONFIG_MPTCP_IPV6=y selects CONFIG_IPV6=y. In other words, adding "CONFIG_IPV6=y" here in the selftests config is redundant if you don't have this commit 010b430d5df5 but not wrong.
Note that if you also want to backport this commit 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it"), you will need commit 0ed37ac586c0 ("mptcp: depends on IPV6 but not as a module") as well.
Cheers,
Matt
Signature · 2 lines
Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Sasha Levin
maintainerQuoted 28 lines · Matthieu Baerts
Hi Sasha,
Quoted 3 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
selftests: mptcp: depends on built-in IPv6
Thank you for backporting this patch.
(...)
Quoted 1 line
Fixes 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it")This patch is not really needed because AFAICS this commit here above has not been backported to v5.9. It is only in v5.10-rc1.
(...)
tools/testing/selftests/net/mptcp/config line 3
Quoted 8 lines
tools/testing/selftests/net/mptcp/config +1
-0@@ -1,4 +1,5 @@ CONFIG_MPTCP=y +CONFIG_IPV6=y CONFIG_MPTCP_IPV6=yBut you can also keep this patch, it doesn't hurt: without this commit
010b430d5df5("mptcp:MPTCP_IPV6should depend on IPV6 instead of selecting it"),CONFIG_MPTCP_IPV6=yselectsCONFIG_IPV6=y. In other words, adding "CONFIG_IPV6=y" here in the selftests config is redundant if you don't have this commit010b430d5df5but not wrong.
Quoted 1 line
Note that if you also want to backport this commit
010b430d5df5("mptcp:MPTCP_IPV6should depend on IPV6 instead of selecting it"), you will need commit0ed37ac586c0("mptcp: depends on IPV6 but not as a module") as well.
I'll drop the selftests fix then, thanks for the heads-up!
Signature · 2 lines
Thanks, Sasha