Skip to contentSkip to conversation

RDMA/uverbs: Fix false error in query gid IOCTL

PATCH Applied Gal Pressman 2 participants 2 messages Oct 26, 2020 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/uverbs: Fix false error in query gid IOCTL

Some drivers (such as EFA) have a GID table, but aren't IB/RoCE devices. Remove the unnecessary rdma_ib_or_roce() check.

Fixes 9f85cbe50aa0 ("RDMA/uverbs: Expose the new GID query API to user space")
---
 drivers/infiniband/core/uverbs_std_types_device.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/infiniband/core/uverbs_std_types_device.c +0 -3
index f367d523a46b..302f898c5833 100644
@@ -401,9 +401,6 @@ static int UVERBS_HANDLER(UVERBS_METHOD_QUERY_GID_ENTRY)(
 	if (!rdma_is_port_valid(ib_dev, port_num))
 		return -EINVAL;
 
-	if (!rdma_ib_or_roce(ib_dev, port_num))
-		return -EOPNOTSUPP;
-
 	gid_attr = rdma_get_gid_attr(ib_dev, port_num, gid_index);
 	if (IS_ERR(gid_attr))
 		return PTR_ERR(gid_attr);

base-commit: c7a198c700763ac89abbb166378f546aeb9afb33

Signature · 1 line
2.29.1
maintainer Applied
#1 lore raw
Quoted 8 lines · Gal Pressman

Some drivers (such as EFA) have a GID table, but aren't IB/RoCE devices. Remove the unnecessary rdma_ib_or_roce() check.

Fixes 9f85cbe50aa0 ("RDMA/uverbs: Expose the new GID query API to user space")
---
 drivers/infiniband/core/uverbs_std_types_device.c | 3 ---
 1 file changed, 3 deletions(-)

Applied to for-rc, thanks

Jason