perf/x86/intel/uncore: fix Add BW copypasta
Subsystems (2)
PATCH 1/1 perf/x86/intel/uncore: fix Add BW copypasta
From: Arnd Bergmann <[email protected]>
gcc -Wextra points out a duplicate initialization of one array member:
arch/x86/events/intel/uncore_snb.c:478:37: warning: initialized field overwritten [-Woverride-init]
478 | [SNB_PCI_UNCORE_IMC_DATA_READS] = { SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE,
The only sensible explanation is that a duplicate 'READS' was used instead of the correct 'WRITES', so change it back.
--- arch/x86/events/intel/uncore_snb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/events/intel/uncore_snb.c +1 -1
@@ -475,7 +475,7 @@ enum perf_snb_uncore_imc_freerunning_types {static struct freerunning_counters snb_uncore_imc_freerunning[] = { [SNB_PCI_UNCORE_IMC_DATA_READS ] = {SNB_UNCORE_PCI_IMC_DATA_READS_BASE ,0x0 ,0x0 ,1 ,32 }, - [SNB_PCI_UNCORE_IMC_DATA_READS ] = {SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE , + [SNB_PCI_UNCORE_IMC_DATA_WRITES ] = {SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE ,0x0 ,0x0 ,1 ,32 }, [SNB_PCI_UNCORE_IMC_GT_REQUESTS ] = {SNB_UNCORE_PCI_IMC_GT_REQUESTS_BASE ,0x0 ,0x0 ,1 ,32 },
Signature · 1 line
2.27.0
Peter Zijlstra
maintainerQuoted 5 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
gcc -Wextra points out a duplicate initialization of one array member:
Quoted 8 lines
arch/x86/events/intel/uncore_snb.c:478:37: warning: initialized field overwritten [-Woverride-init]
478 | [SNB_PCI_UNCORE_IMC_DATA_READS] = {SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE,The only sensible explanation is that a duplicate 'READS' was used instead of the correct 'WRITES', so change it back.
Fixes 24633d901ea4 ("perf/x86/intel/uncore: Add BW counters for GT, IA and IO breakdown")Signed-off-by Arnd Bergmann <[email protected]>
Thanks!
[tip: perf/urgent] perf/x86/intel/uncore: Fix Add BW copypasta
In reply to Arnd BergmannThe following commit has been merged into the perf/urgent branch of tip:
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: 1a8cfa24e21c2f154791f0cdd85fc28496918722 Gitweb: https://git.kernel.org/tip/1a8cfa24e21c2f154791f0cdd85fc28496918722 Author: Arnd Bergmann <[email protected]> AuthorDate: Mon, 26 Oct 2020 22:51:57 +01:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Tue, 10 Nov 2020 18:38:40 +01:00
perf/x86/intel/uncore: Fix Add BW copypasta
gcc -Wextra points out a duplicate initialization of one array member:
arch/x86/events/intel/uncore_snb.c:478:37: warning: initialized field overwritten [-Woverride-init]
478 | [SNB_PCI_UNCORE_IMC_DATA_READS] = { SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE,
The only sensible explanation is that a duplicate 'READS' was used instead of the correct 'WRITES', so change it back.
--- arch/x86/events/intel/uncore_snb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/events/intel/uncore_snb.c +1 -1
@@ -475,7 +475,7 @@ enum perf_snb_uncore_imc_freerunning_types {static struct freerunning_counters snb_uncore_imc_freerunning[] = { [SNB_PCI_UNCORE_IMC_DATA_READS ] = {SNB_UNCORE_PCI_IMC_DATA_READS_BASE ,0x0 ,0x0 ,1 ,32 }, - [SNB_PCI_UNCORE_IMC_DATA_READS ] = {SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE , + [SNB_PCI_UNCORE_IMC_DATA_WRITES ] = {SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE ,0x0 ,0x0 ,1 ,32 }, [SNB_PCI_UNCORE_IMC_GT_REQUESTS ] = {SNB_UNCORE_PCI_IMC_GT_REQUESTS_BASE ,0x0 ,0x0 ,1 ,32 },