Skip to contentSkip to conversation

io-wq: set task TASK_INTERRUPTIBLE state before schedule_timeout

PATCH New [email protected] 1 participant 1 message Oct 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 io-wq: set task TASK_INTERRUPTIBLE state before schedule_timeout

From: Zqiang <[email protected]>

In 'io_wqe_worker' thread, if the work which in 'wqe->work_list' be finished, the 'wqe->work_list' is empty, and after that the '__io_worker_idle' func return false, the task state is TASK_RUNNING, need to be set TASK_INTERRUPTIBLE before call schedule_timeout func.

---
 fs/io-wq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/io-wq.c +1 -1
index 02894df7656d..5f0626935b64 100644
@@ -618,7 +618,7 @@ static int io_wqe_worker(void *data)
 		raw_spin_unlock_irq(&wqe->lock);
 		if (signal_pending(current))
 			flush_signals(current);
-		if (schedule_timeout(WORKER_IDLE_TIMEOUT))
+		if (schedule_timeout_interruptible(WORKER_IDLE_TIMEOUT))
 			continue;
 		/* timed out, exit unless we're the fixed worker */
 		if (test_bit(IO_WQ_BIT_EXIT, &wq->state) ||
Signature · 1 line
2.17.1