Skip to contentSkip to conversation

Trivial warning fixes

PATCH In review [email protected] 4 participants 6 messages Oct 27, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover Trivial warning fixes

From: Felipe Balbi <[email protected]>

Hi,

here's a couple build warning fixes that I just caught with allmodconfig on AArch64.

cheers

Felipe Balbi (2):
hwtracing: coresight: add missing MODULE_LICENSE()
irqchip: bcm2836: fix section mismatch warning

 drivers/hwtracing/coresight/coresight-core.c | 1 +
 drivers/irqchip/irq-bcm2836.c                | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.29.1
#1 lore raw

PATCH 1/2 hwtracing: coresight: add missing MODULE_LICENSE()

From: Felipe Balbi <[email protected]>

Fix the following build warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/hwtracing/coresight/coresight.o

---
 drivers/hwtracing/coresight/coresight-core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hwtracing/coresight/coresight-core.c +1 -0
index 6994c1309b2b..7936fca8436c 100644
@@ -1692,3 +1692,4 @@ module_exit(coresight_exit);
 MODULE_AUTHOR("Pratik Patel <[email protected]>");
 MODULE_AUTHOR("Mathieu Poirier <[email protected]>");
 MODULE_DESCRIPTION("Arm CoreSight tracer driver");
+MODULE_LICENSE("GPL");
Signature · 1 line
2.29.1
#4 lore raw

PATCH 2/2 irqchip: bcm2836: fix section mismatch warning

In reply to [email protected]

From: Felipe Balbi <[email protected]>

Fix the following warning:

WARNING: modpost: vmlinux.o(.text.unlikely+0x17b2c): Section mismatch in reference from the function bcm2836_arm_irqchip_smp_init() to the function .init.text:set_smp_ipi_range() The function bcm2836_arm_irqchip_smp_init() references
the function __init set_smp_ipi_range().
This is often because bcm2836_arm_irqchip_smp_init lacks a __init
annotation or the annotation of set_smp_ipi_range is wrong.

---
 drivers/irqchip/irq-bcm2836.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-bcm2836.c +1 -1
index 97838eb705f9..cbc7c740e4dc 100644
@@ -244,7 +244,7 @@ static int bcm2836_cpu_dying(unsigned int cpu)
 
 #define BITS_PER_MBOX	32
 
-static void bcm2836_arm_irqchip_smp_init(void)
+static void __init bcm2836_arm_irqchip_smp_init(void)
 {
 	struct irq_fwspec ipi_fwspec = {
 		.fwnode		= intc.domain->fwnode,
Signature · 1 line
2.29.1
#5 lore raw

Re: [PATCH 2/2] irqchip: bcm2836: fix section mismatch warning

Quoted 22 lines · On 2020-10-27 08:51, [email protected] wrote:

From: Felipe Balbi <[email protected]>

Fix the following warning:

WARNING: modpost: vmlinux.o(.text.unlikely+0x17b2c): Section mismatch in reference from the function bcm2836_arm_irqchip_smp_init() to the function .init.text:set_smp_ipi_range()
The function bcm2836_arm_irqchip_smp_init() references
the function __init set_smp_ipi_range().
This is often because bcm2836_arm_irqchip_smp_init lacks a __init annotation or the annotation of set_smp_ipi_range is wrong.

---
 drivers/irqchip/irq-bcm2836.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-bcm2836.c +0 -0
index 97838eb705f9..cbc7c740e4dc 100644

drivers/irqchip/irq-bcm2836.c static int bcm2836_cpu_dying(unsigned int cpu) · line 250

Quoted 8 lines
drivers/irqchip/irq-bcm2836.c +1 -1
@@ -244,7 +244,7 @@ static int bcm2836_cpu_dying(unsigned int cpu)
 
 #define BITS_PER_MBOX	32
 
-static void bcm2836_arm_irqchip_smp_init(void)
+static void __init bcm2836_arm_irqchip_smp_init(void)
 {
 	struct irq_fwspec ipi_fwspec = {
 		.fwnode		= intc.domain->fwnode,

I already have a fix for this one[1], which should be in -next.

Thanks,

        M.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=57733e009f0c7e0526e10a18be12f56996c5460e

Signature · 1 line
Jazz is not dead. It just smells funny...
#3 lore raw

Re: [PATCH 1/2] hwtracing: coresight: add missing MODULE_LICENSE()

In reply to [email protected]

Hi Felipe,

Quoted 6 lines · On Tue, Oct 27, 2020 at 10:51:56AM +0200, [email protected] wrote:

From: Felipe Balbi <[email protected]>

Fix the following build warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/hwtracing/coresight/coresight.o

Arnd already sent a patch about this[1] yesterday.

Thanks,
Mathieu

[1]. https://lists.linaro.org/pipermail/coresight/2020-October/005041.html

Quoted 17 lines
---
 drivers/hwtracing/coresight/coresight-core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hwtracing/coresight/coresight-core.c +1 -0
index 6994c1309b2b..7936fca8436c 100644
@@ -1692,3 +1692,4 @@ module_exit(coresight_exit);
 MODULE_AUTHOR("Pratik Patel <[email protected]>");
 MODULE_AUTHOR("Mathieu Poirier <[email protected]>");
 MODULE_DESCRIPTION("Arm CoreSight tracer driver");
+MODULE_LICENSE("GPL");
Signature · 1 line
2.29.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel