net: dec: tulip: de2104x: Add shutdown handler to stop NIC
Subsystems (3)
PATCH v4 1/1 net: dec: tulip: de2104x: Add shutdown handler to stop NIC
The driver does not implement a shutdown handler which leads to issues when using kexec in certain scenarios. The NIC keeps on fetching descriptors which gets flagged by the IOMMU with errors like this:
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr fffff000
---
Changes from v3:
- Added rtnl_lock()/unlock() as suggested by Jakub and use dev_close()
Changes from v2:
- Changed to net-next
- Removed extra whitespace
Changes from v1:
- Replace call to de_remove_one with de_shutdown() function as suggested by James.
--- drivers/net/ethernet/dec/tulip/de2104x.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/net/ethernet/dec/tulip/de2104x.c +10 -0
@@ -2175,11 +2175,21 @@ static int __maybe_unused de_resume(struct device *dev_d) static SIMPLE_DEV_PM_OPS(de_pm_ops, de_suspend, de_resume); +static void de_shutdown (struct pci_dev *pdev) +{ +struct net_device *dev =pci_get_drvdata (pdev); + +rtnl_lock (); +dev_close (dev); +rtnl_unlock (); +} +static struct pci_driver de_driver = { .name =DRV_NAME , .id_table = de_pci_tbl, .probe = de_init_one, .remove = de_remove_one, + .shutdown = de_shutdown, .driver.pm = &de_pm_ops, };
Signature · 1 line
2.29.1
Quoted 11 lines · On Wed, 28 Oct 2020 10:21:25 -0700 Moritz Fischer wrote:
The driver does not implement a shutdown handler which leads to issues when using kexec in certain scenarios. The NIC keeps on fetching descriptors which gets flagged by the IOMMU with errors like this:
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr
fffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addrfffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addrfffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addrfffff000
DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addrfffff000Signed-off-by Moritz Fischer <[email protected]>
Applied, thanks!