Skip to contentSkip to conversation

Restore installation of public header via make install

PATCH Applied [email protected] 2 participants 2 messages Oct 29, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Restore installation of public header via make install

From: Luca Boccassi <[email protected]>

Fixes 5ca4c55e3382 ("Makefile: generate libfsverity.pc during 'make install'")

---
I think this was removed by mistake? After the linked commit make install does not install the header anymore

 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index a898ed4..bfe83c4 100644
@@ -206,6 +206,7 @@ install:all
 	install -m644 libfsverity.a $(DESTDIR)$(LIBDIR)
 	install -m755 libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)
 	ln -sf libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)/libfsverity.so
+	install -m644 include/libfsverity.h $(DESTDIR)$(INCDIR)
 	sed -e "s|@PREFIX@|$(PREFIX)|" \
 		-e "s|@LIBDIR@|$(LIBDIR)|" \
 		-e "s|@INCDIR@|$(INCDIR)|" \
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw
Quoted 17 lines · On Thu, Oct 29, 2020 at 09:18:27AM +0000, [email protected] wrote:

From: Luca Boccassi <[email protected]>

Fixes 5ca4c55e3382 ("Makefile: generate libfsverity.pc during 'make install'")

---
I think this was removed by mistake? After the linked commit make install does not install the header anymore

 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +0 -0
index a898ed4..bfe83c4 100644

Makefile install:all · line 212

Quoted 7 lines
Makefile +1 -0
@@ -206,6 +206,7 @@ install:all
 	install -m644 libfsverity.a $(DESTDIR)$(LIBDIR)
 	install -m755 libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)
 	ln -sf libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)/libfsverity.so
+	install -m644 include/libfsverity.h $(DESTDIR)$(INCDIR)
 	sed -e "s|@PREFIX@|$(PREFIX)|" \
 		-e "s|@LIBDIR@|$(LIBDIR)|" \
 		-e "s|@INCDIR@|$(INCDIR)|" \

Applied, thanks. Sorry about that.

- Eric