nitro_enclaves: Add logic for setting an enclave vCPU
Hello Andra Paraschiv,
The patch ff8a4d3e3a99: "nitro_enclaves: Add logic for setting an enclave vCPU" from Sep 21, 2020, leads to the following static checker warning:
drivers/virt/nitro_enclaves/ne_misc_dev.c:471 ne_donated_cpu()
error: passing untrusted data 'cpu' to 'cpumask_test_cpu()'
drivers/virt/nitro_enclaves/ne_misc_dev.c
1093 switch (cmd) {
1094 case NE_ADD_VCPU: {
1095 int rc = -EINVAL;
1096 u32 vcpu_id = 0;
1097
1098 if (copy_from_user(&vcpu_id, (void __user *)arg, sizeof(vcpu_id)))
^^^^^^^^
1099 return -EFAULT;
1100
1101 mutex_lock(&ne_enclave->enclave_info_mutex);
1102
1103 if (ne_enclave->state != NE_STATE_INIT) {
1104 dev_err_ratelimited(ne_misc_dev.this_device,
1105 "Enclave is not in init state\n");
1106
1107 mutex_unlock(&ne_enclave->enclave_info_mutex);
1108
1109 return -NE_ERR_NOT_IN_INIT_STATE;
1110 }
1111
1112 if (vcpu_id >= (ne_enclave->nr_parent_vm_cores *
1113 ne_enclave->nr_threads_per_core)) {To prevent a buffer overflow vcpu_id has to be less than "nr_cpu_ids". Is "ne_enclave->nr_parent_vm_cores * ne_enclave->nr_threads_per_core" <= nr_cpu_ids? If so then it's fine.
1114 dev_err_ratelimited(ne_misc_dev.this_device,
1115 "vCPU id higher than max CPU id\n");
1116
1117 mutex_unlock(&ne_enclave->enclave_info_mutex);
1118
1119 return -NE_ERR_INVALID_VCPU;
1120 }
1121
1122 if (!vcpu_id) {
1123 /* Use the CPU pool for choosing a CPU for the enclave. */
1124 rc = ne_get_cpu_from_cpu_pool(ne_enclave, &vcpu_id);
1125 if (rc < 0) {
1126 dev_err_ratelimited(ne_misc_dev.this_device,
1127 "Error in get CPU from pool [rc=%d]\n",
1128 rc);
1129
1130 mutex_unlock(&ne_enclave->enclave_info_mutex);
1131
1132 return rc;
1133 }
1134 } else {
1135 /* Check if the provided vCPU is available in the NE CPU pool. */
1136 rc = ne_check_cpu_in_cpu_pool(ne_enclave, vcpu_id);
^^^^^^^This will lead to the out of bounds if vcpu_id is more than nr_cpu_ids.
1137 if (rc < 0) {
1138 dev_err_ratelimited(ne_misc_dev.this_device,regards,
dan carpenter
CgpPbiAzMC8xMC8yMDIwIDEzOjMwLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+Cj4gSGVsbG8gQW5k cmEgUGFyYXNjaGl2LAo+Cj4gVGhlIHBhdGNoIGZmOGE0ZDNlM2E5OTogIm5pdHJvX2VuY2xhdmVz OiBBZGQgbG9naWMgZm9yIHNldHRpbmcgYW4KPiBlbmNsYXZlIHZDUFUiIGZyb20gU2VwIDIxLCAy MDIwLCBsZWFkcyB0byB0aGUgZm9sbG93aW5nIHN0YXRpYwo+IGNoZWNrZXIgd2FybmluZzoKPgo+ ICAgICAgICAgIGRyaXZlcnMvdmlydC9uaXRyb19lbmNsYXZlcy9uZV9taXNjX2Rldi5jOjQ3MSBu ZV9kb25hdGVkX2NwdSgpCj4gICAgICAgICAgZXJyb3I6IHBhc3NpbmcgdW50cnVzdGVkIGRhdGEg J2NwdScgdG8gJ2NwdW1hc2tfdGVzdF9jcHUoKScKPgo+IGRyaXZlcnMvdmlydC9uaXRyb19lbmNs YXZlcy9uZV9taXNjX2Rldi5jCj4gICAgMTA5MyAgICAgICAgICBzd2l0Y2ggKGNtZCkgewo+ICAg IDEwOTQgICAgICAgICAgY2FzZSBORV9BRERfVkNQVTogewo+ICAgIDEwOTUgICAgICAgICAgICAg ICAgICBpbnQgcmMgPSAtRUlOVkFMOwo+ICAgIDEwOTYgICAgICAgICAgICAgICAgICB1MzIgdmNw dV9pZCA9IDA7Cj4gICAgMTA5Nwo+ICAgIDEwOTggICAgICAgICAgICAgICAgICBpZiAoY29weV9m cm9tX3VzZXIoJnZjcHVfaWQsICh2b2lkIF9fdXNlciAqKWFyZywgc2l6ZW9mKHZjcHVfaWQpKSkK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5eXl5eXl5eCj4K PiAgICAxMDk5ICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKPiAgICAx MTAwCj4gICAgMTEwMSAgICAgICAgICAgICAgICAgIG11dGV4X2xvY2soJm5lX2VuY2xhdmUtPmVu Y2xhdmVfaW5mb19tdXRleCk7Cj4gICAgMTEwMgo+ICAgIDExMDMgICAgICAgICAgICAgICAgICBp ZiAobmVfZW5jbGF2ZS0+c3RhdGUgIT0gTkVfU1RBVEVfSU5JVCkgewo+ICAgIDExMDQgICAgICAg ICAgICAgICAgICAgICAgICAgIGRldl9lcnJfcmF0ZWxpbWl0ZWQobmVfbWlzY19kZXYudGhpc19k ZXZpY2UsCj4gICAgMTEwNSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiRW5jbGF2ZSBpcyBub3QgaW4gaW5pdCBzdGF0ZVxuIik7Cj4gICAgMTEwNgo+ICAgIDEx MDcgICAgICAgICAgICAgICAgICAgICAgICAgIG11dGV4X3VubG9jaygmbmVfZW5jbGF2ZS0+ZW5j bGF2ZV9pbmZvX211dGV4KTsKPiAgICAxMTA4Cj4gICAgMTEwOSAgICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIC1ORV9FUlJfTk9UX0lOX0lOSVRfU1RBVEU7Cj4gICAgMTExMCAgICAgICAg ICAgICAgICAgIH0KPiAgICAxMTExCj4gICAgMTExMiAgICAgICAgICAgICAgICAgIGlmICh2Y3B1 X2lkID49IChuZV9lbmNsYXZlLT5ucl9wYXJlbnRfdm1fY29yZXMgKgo+ICAgIDExMTMgICAgICAg ICAgICAgICAgICAgICAgbmVfZW5jbGF2ZS0+bnJfdGhyZWFkc19wZXJfY29yZSkpIHsKPgo+IFRv IHByZXZlbnQgYSBidWZmZXIgb3ZlcmZsb3cgdmNwdV9pZCBoYXMgdG8gYmUgbGVzcyB0aGFuICJu cl9jcHVfaWRzIi4KPiBJcyAibmVfZW5jbGF2ZS0+bnJfcGFyZW50X3ZtX2NvcmVzICogbmVfZW5j bGF2ZS0+bnJfdGhyZWFkc19wZXJfY29yZSIKPiA8PSBucl9jcHVfaWRzPyAgSWYgc28gdGhlbiBp dCdzIGZpbmUuCgpIaSBEYW4sCgpUaGFua3MgZm9yIHJlYWNoaW5nIG91dCB3aXRoIHJlZ2FyZCB0 byB0aGlzIHJlcG9ydGVkIGlzc3VlIGZyb20gdGhlIApzdGF0aWMgYW5hbHlzaXMuCgoibnJfY3B1 X2lkcyIgaXMgdXNlZCB3aGVuIHRoZSBudW1iZXIgb2YgY29yZXMgaXMgaW5pdGlhbGl6ZWQsIHNv IGl0IApzaG91bGQgYmUgZmluZS4gTGV0IG1lIGtub3cgaWYgSSBtaXNzIHNvbWV0aGluZyBhbmQg YSBjaGVjayBoYXMgdG8gYmUgCmFkZGVkIHRvIGRpcmVjdGx5IGNvbXBhcmUgdG8gIm5yX2NwdV9p ZHMiLgoKVGhlIGluaXRpYWxpemF0aW9uIGZsb3cgZm9yIHRoZSBhYm92ZSB2YXJpYWJsZXMgbG9v a3MgbGlrZSB0aGlzOgoKWzFdIHxuZV9zZXR1cF9jcHVfcG9vbCgpfHx8Cgp8CgoJLyogQ2FsY3Vs YXRlIHRoZSBudW1iZXIgb2YgdGhyZWFkcyBmcm9tIGEgZnVsbCBDUFUgY29yZS4gKi8KCWNwdSAg PSAgY3B1bWFza19hbnkoY3B1X3Bvb2wpOwoJZm9yX2VhY2hfY3B1KGNwdV9zaWJsaW5nLCAgdG9w b2xvZ3lfc2libGluZ19jcHVtYXNrKGNwdSkpCgkJbmVfY3B1X3Bvb2wubnJfdGhyZWFkc19wZXJf Y29yZSsrOwoKCW5lX2NwdV9wb29sLm5yX3BhcmVudF92bV9jb3JlcyAgPSAgbnJfY3B1X2lkcyAg LyAgbmVfY3B1X3Bvb2wubnJfdGhyZWFkc19wZXJfY29yZTt8CgpbMl0gbmVfY3JlYXRlX3ZtX2lv Y3RsKCl8fAoKfAoKCW5lX2VuY2xhdmUtPm5yX3BhcmVudF92bV9jb3JlcyAgPSAgbmVfY3B1X3Bv b2wubnJfcGFyZW50X3ZtX2NvcmVzOwoJbmVfZW5jbGF2ZS0+bnJfdGhyZWFkc19wZXJfY29yZSAg PSAgbmVfY3B1X3Bvb2wubnJfdGhyZWFkc19wZXJfY29yZTt8CgoKVGhhbmtzLApBbmRyYQoKWzFd IApodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxk cy9saW51eC5naXQvdHJlZS9kcml2ZXJzL3ZpcnQvbml0cm9fZW5jbGF2ZXMvbmVfbWlzY19kZXYu Yz9oPXY1LjEwLXJjMSNuMjc5ClsyXSAKaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xp bnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L3RyZWUvZHJpdmVycy92aXJ0L25pdHJv X2VuY2xhdmVzL25lX21pc2NfZGV2LmM/aD12NS4xMC1yYzEjbjE1NzEKCj4KPiAgICAxMTE0ICAg ICAgICAgICAgICAgICAgICAgICAgICBkZXZfZXJyX3JhdGVsaW1pdGVkKG5lX21pc2NfZGV2LnRo aXNfZGV2aWNlLAo+ICAgIDExMTUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgInZDUFUgaWQgaGlnaGVyIHRoYW4gbWF4IENQVSBpZFxuIik7Cj4gICAgMTExNgo+ ICAgIDExMTcgICAgICAgICAgICAgICAgICAgICAgICAgIG11dGV4X3VubG9jaygmbmVfZW5jbGF2 ZS0+ZW5jbGF2ZV9pbmZvX211dGV4KTsKPiAgICAxMTE4Cj4gICAgMTExOSAgICAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIC1ORV9FUlJfSU5WQUxJRF9WQ1BVOwo+ICAgIDExMjAgICAgICAg ICAgICAgICAgICB9Cj4gICAgMTEyMQo+ICAgIDExMjIgICAgICAgICAgICAgICAgICBpZiAoIXZj cHVfaWQpIHsKPiAgICAxMTIzICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBVc2UgdGhlIENQ VSBwb29sIGZvciBjaG9vc2luZyBhIENQVSBmb3IgdGhlIGVuY2xhdmUuICovCj4gICAgMTEyNCAg ICAgICAgICAgICAgICAgICAgICAgICAgcmMgPSBuZV9nZXRfY3B1X2Zyb21fY3B1X3Bvb2wobmVf ZW5jbGF2ZSwgJnZjcHVfaWQpOwo+ICAgIDExMjUgICAgICAgICAgICAgICAgICAgICAgICAgIGlm IChyYyA8IDApIHsKPiAgICAxMTI2ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRl dl9lcnJfcmF0ZWxpbWl0ZWQobmVfbWlzY19kZXYudGhpc19kZXZpY2UsCj4gICAgMTEyNyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJFcnJvciBp biBnZXQgQ1BVIGZyb20gcG9vbCBbcmM9JWRdXG4iLAo+ICAgIDExMjggICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByYyk7Cj4gICAgMTEyOQo+ICAg IDExMzAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbXV0ZXhfdW5sb2NrKCZuZV9l bmNsYXZlLT5lbmNsYXZlX2luZm9fbXV0ZXgpOwo+ICAgIDExMzEKPiAgICAxMTMyICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByYzsKPiAgICAxMTMzICAgICAgICAgICAg ICAgICAgICAgICAgICB9Cj4gICAgMTEzNCAgICAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4gICAg MTEzNSAgICAgICAgICAgICAgICAgICAgICAgICAgLyogQ2hlY2sgaWYgdGhlIHByb3ZpZGVkIHZD UFUgaXMgYXZhaWxhYmxlIGluIHRoZSBORSBDUFUgcG9vbC4gKi8KPiAgICAxMTM2ICAgICAgICAg ICAgICAgICAgICAgICAgICByYyA9IG5lX2NoZWNrX2NwdV9pbl9jcHVfcG9vbChuZV9lbmNsYXZl LCB2Y3B1X2lkKTsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeXl5eXl5eCj4gVGhpcyB3aWxsIGxlYWQg dG8gdGhlIG91dCBvZiBib3VuZHMgaWYgdmNwdV9pZCBpcyBtb3JlIHRoYW4KPiBucl9jcHVfaWRz Lgo+Cj4gICAgMTEzNyAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHJjIDwgMCkgewo+ICAg IDExMzggICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2X2Vycl9yYXRlbGltaXRl ZChuZV9taXNjX2Rldi50aGlzX2RldmljZSwKPgo+IHJlZ2FyZHMsCj4gZGFuIGNhcnBlbnRlcgoK CgoKQW1hem9uIERldmVsb3BtZW50IENlbnRlciAoUm9tYW5pYSkgUy5SLkwuIHJlZ2lzdGVyZWQg b2ZmaWNlOiAyN0EgU2YuIExhemFyIFN0cmVldCwgVUJDNSwgZmxvb3IgMiwgSWFzaSwgSWFzaSBD b3VudHksIDcwMDA0NSwgUm9tYW5pYS4gUmVnaXN0ZXJlZCBpbiBSb21hbmlhLiBSZWdpc3RyYXRp b24gbnVtYmVyIEoyMi8yNjIxLzIwMDUuCg=
Quoted 42 lines · Andra-Irina
Quoted 35 lines · Dan Carpenter
Hello Andra Paraschiv,
The patch
ff8a4d3e3a99: "nitro_enclaves: Add logic for setting an enclave vCPU" from Sep 21, 2020, leads to the following static checker warning:
drivers/virt/nitro_enclaves/ne_misc_dev.c:471ne_donated_cpu()
error: passing untrusted data 'cpu' to 'cpumask_test_cpu()'
drivers/virt/nitro_enclaves/ne_misc_dev.c1093 switch (cmd) { 1094 case NE_ADD_VCPU: { 1095 int rc = -EINVAL; 1096 u32 vcpu_id = 0; 1097 1098 if (copy_from_user(&vcpu_id, (void __user *)arg, sizeof(vcpu_id))) ^^^^^^^^ 1099 return -EFAULT; 1100 1101 mutex_lock(&ne_enclave->enclave_info_mutex); 1102 1103 if (ne_enclave->state != NE_STATE_INIT) { 1104 dev_err_ratelimited(ne_misc_dev.this_device, 1105 "Enclave is not in init state\n"); 1106 1107 mutex_unlock(&ne_enclave->enclave_info_mutex); 1108 1109 return -NE_ERR_NOT_IN_INIT_STATE; 1110 } 1111 1112 if (vcpu_id >= (ne_enclave->nr_parent_vm_cores * 1113 ne_enclave->nr_threads_per_core)) {Quoted 3 lines
To prevent a buffer overflow
vcpu_idhas to be less than "nr_cpu_ids". Is "ne_enclave->nr_parent_vm_cores*ne_enclave->nr_threads_per_core" <=nr_cpu_ids? If so then it's fine.
Quoted 8 lines
Hi Dan,
Thanks for reaching out with regard to this reported issue from the static analysis.
"
nr_cpu_ids" is used when the number of cores is initialized, so it should be fine. Let me know if I miss something and a check has to be added to directly compare to "nr_cpu_ids".
Yeah. That works. Thanks for taking a look at this.
regards,
dan carpenter
CgpPbiAwMi8xMS8yMDIwIDA4OjIwLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IE9uIEZyaSwgT2N0 IDMwLCAyMDIwIGF0IDA1OjIzOjE4UE0gKzAyMDAsIFBhcmFzY2hpdiwgQW5kcmEtSXJpbmEgd3Jv dGU6Cj4+Cj4+IE9uIDMwLzEwLzIwMjAgMTM6MzAsIERhbiBDYXJwZW50ZXIgd3JvdGU6Cj4+PiBI ZWxsbyBBbmRyYSBQYXJhc2NoaXYsCj4+Pgo+Pj4gVGhlIHBhdGNoIGZmOGE0ZDNlM2E5OTogIm5p dHJvX2VuY2xhdmVzOiBBZGQgbG9naWMgZm9yIHNldHRpbmcgYW4KPj4+IGVuY2xhdmUgdkNQVSIg ZnJvbSBTZXAgMjEsIDIwMjAsIGxlYWRzIHRvIHRoZSBmb2xsb3dpbmcgc3RhdGljCj4+PiBjaGVj a2VyIHdhcm5pbmc6Cj4+Pgo+Pj4gICAgICAgICAgIGRyaXZlcnMvdmlydC9uaXRyb19lbmNsYXZl cy9uZV9taXNjX2Rldi5jOjQ3MSBuZV9kb25hdGVkX2NwdSgpCj4+PiAgICAgICAgICAgZXJyb3I6 IHBhc3NpbmcgdW50cnVzdGVkIGRhdGEgJ2NwdScgdG8gJ2NwdW1hc2tfdGVzdF9jcHUoKScKPj4+ Cj4+PiBkcml2ZXJzL3ZpcnQvbml0cm9fZW5jbGF2ZXMvbmVfbWlzY19kZXYuYwo+Pj4gICAgIDEw OTMgICAgICAgICAgc3dpdGNoIChjbWQpIHsKPj4+ICAgICAxMDk0ICAgICAgICAgIGNhc2UgTkVf QUREX1ZDUFU6IHsKPj4+ICAgICAxMDk1ICAgICAgICAgICAgICAgICAgaW50IHJjID0gLUVJTlZB TDsKPj4+ICAgICAxMDk2ICAgICAgICAgICAgICAgICAgdTMyIHZjcHVfaWQgPSAwOwo+Pj4gICAg IDEwOTcKPj4+ICAgICAxMDk4ICAgICAgICAgICAgICAgICAgaWYgKGNvcHlfZnJvbV91c2VyKCZ2 Y3B1X2lkLCAodm9pZCBfX3VzZXIgKilhcmcsIHNpemVvZih2Y3B1X2lkKSkpCj4+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeXl5eXl5eXgo+Pj4KPj4+ICAg ICAxMDk5ICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVGQVVMVDsKPj4+ICAgICAx MTAwCj4+PiAgICAgMTEwMSAgICAgICAgICAgICAgICAgIG11dGV4X2xvY2soJm5lX2VuY2xhdmUt PmVuY2xhdmVfaW5mb19tdXRleCk7Cj4+PiAgICAgMTEwMgo+Pj4gICAgIDExMDMgICAgICAgICAg ICAgICAgICBpZiAobmVfZW5jbGF2ZS0+c3RhdGUgIT0gTkVfU1RBVEVfSU5JVCkgewo+Pj4gICAg IDExMDQgICAgICAgICAgICAgICAgICAgICAgICAgIGRldl9lcnJfcmF0ZWxpbWl0ZWQobmVfbWlz Y19kZXYudGhpc19kZXZpY2UsCj4+PiAgICAgMTEwNSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiRW5jbGF2ZSBpcyBub3QgaW4gaW5pdCBzdGF0ZVxuIik7Cj4+ PiAgICAgMTEwNgo+Pj4gICAgIDExMDcgICAgICAgICAgICAgICAgICAgICAgICAgIG11dGV4X3Vu bG9jaygmbmVfZW5jbGF2ZS0+ZW5jbGF2ZV9pbmZvX211dGV4KTsKPj4+ICAgICAxMTA4Cj4+PiAg ICAgMTEwOSAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIC1ORV9FUlJfTk9UX0lOX0lO SVRfU1RBVEU7Cj4+PiAgICAgMTExMCAgICAgICAgICAgICAgICAgIH0KPj4+ICAgICAxMTExCj4+ PiAgICAgMTExMiAgICAgICAgICAgICAgICAgIGlmICh2Y3B1X2lkID49IChuZV9lbmNsYXZlLT5u cl9wYXJlbnRfdm1fY29yZXMgKgo+Pj4gICAgIDExMTMgICAgICAgICAgICAgICAgICAgICAgbmVf ZW5jbGF2ZS0+bnJfdGhyZWFkc19wZXJfY29yZSkpIHsKPj4+Cj4+PiBUbyBwcmV2ZW50IGEgYnVm ZmVyIG92ZXJmbG93IHZjcHVfaWQgaGFzIHRvIGJlIGxlc3MgdGhhbiAibnJfY3B1X2lkcyIuCj4+ PiBJcyAibmVfZW5jbGF2ZS0+bnJfcGFyZW50X3ZtX2NvcmVzICogbmVfZW5jbGF2ZS0+bnJfdGhy ZWFkc19wZXJfY29yZSIKPj4+IDw9IG5yX2NwdV9pZHM/ICBJZiBzbyB0aGVuIGl0J3MgZmluZS4K Pj4gSGkgRGFuLAo+Pgo+PiBUaGFua3MgZm9yIHJlYWNoaW5nIG91dCB3aXRoIHJlZ2FyZCB0byB0 aGlzIHJlcG9ydGVkIGlzc3VlIGZyb20gdGhlIHN0YXRpYwo+PiBhbmFseXNpcy4KPj4KPj4gIm5y X2NwdV9pZHMiIGlzIHVzZWQgd2hlbiB0aGUgbnVtYmVyIG9mIGNvcmVzIGlzIGluaXRpYWxpemVk LCBzbyBpdCBzaG91bGQKPj4gYmUgZmluZS4gTGV0IG1lIGtub3cgaWYgSSBtaXNzIHNvbWV0aGlu ZyBhbmQgYSBjaGVjayBoYXMgdG8gYmUgYWRkZWQgdG8KPj4gZGlyZWN0bHkgY29tcGFyZSB0byAi bnJfY3B1X2lkcyIuCj4gWWVhaC4gIFRoYXQgd29ya3MuICBUaGFua3MgZm9yIHRha2luZyBhIGxv b2sgYXQgdGhpcy4KPgoKT2ssIHRoYW5rcyBmb3IgdGhlIGZvbGxvdy11cC4KCkFuZHJhCgoKCkFt YXpvbiBEZXZlbG9wbWVudCBDZW50ZXIgKFJvbWFuaWEpIFMuUi5MLiByZWdpc3RlcmVkIG9mZmlj ZTogMjdBIFNmLiBMYXphciBTdHJlZXQsIFVCQzUsIGZsb29yIDIsIElhc2ksIElhc2kgQ291bnR5 LCA3MDAwNDUsIFJvbWFuaWEuIFJlZ2lzdGVyZWQgaW4gUm9tYW5pYS4gUmVnaXN0cmF0aW9uIG51 bWJlciBKMjIvMjYyMS8yMDA1Lgo