i915/perf: Make sure i915 is loaded before reading proc

PATCH In review Umesh Nerlige Ramappa 4 participants 5 messages Oct 30, 2020 – Nov 2, 2020

Share & tools

Umesh Nerlige Ramappa

author

2020-10-30 22:55 UTC #0 lore raw

PATCH 1/1 i915/perf: Make sure i915 is loaded before reading proc

The previous test may have unloaded i915 or failed to load it back. To combat such cases, each test fixture is supposed to ensure that i915 is loaded prior to running the subtests. In most fixtures this happens automatically when we try to get a handle to i915. In perf OA, we stat some proc/sys files even before getting a handle to i915. Occassionally, perf tests fail trying to stat these files. Fix perf OA by checking and loading i915 if it's not loaded.

v2: Remove the if check (Ashutosh)

Closes https://gitlab.freedesktop.org/drm/intel/-/issues/405

Signed-off-by Umesh Nerlige Ramappa <[email protected]>

Reviewed-by Petri Latvala <[email protected]>

Reviewed-by Ashutosh Dixit <[email protected]>

---
 tests/i915/perf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

tests/i915/perf.c +8 -0

index a5c4adc3..bd8281bd 100644
@@ -41,6 +41,7 @@
 #include "i915/gem.h"
 #include "i915/perf.h"
 #include "igt.h"
+#include "igt_kmod.h"
 #include "igt_sysfs.h"
 #include "drm.h"

@@ -4806,6 +4807,13 @@ igt_main
 	igt_fixture {
 		struct stat sb;
 
+		/*
+		 * Prior tests may have unloaded i915 or failed while
+		 * loading/unloading i915. Load i915 here before we stat the
+		 * files.
+		 */
+		igt_i915_driver_load(NULL);
+
 		igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
 			    == 0);
 		igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)

Signature · 6 lines

2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Dixit, Ashutosh

Reviewed-by on v1 1/1

2020-10-30 23:06 UTC #1 lore raw

tests/i915/perf.c igt_main · line 4816

Quoted 11 lines · Umesh Nerlige Ramappa

tests/i915/perf.c +7 -0

@@ -4806,6 +4807,13 @@ igt_main
 	igt_fixture {
 		struct stat sb;
 
+		/*
+		 * Prior tests may have unloaded i915 or failed while
+		 * loading/unloading i915. Load i915 here before we stat the
+		 * files.
+		 */
+		igt_i915_driver_load(NULL);
+

I was thinking that the original if () was also ok because there will be an additional igt_debug() if the module is already loaded and the if will avoid that. Anyway you decide what to do, either way:

Reviewed-by Ashutosh Dixit <[email protected]>

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-10-30 23:58 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for i915/perf: Make sure i915 is loaded before reading proc (rev2)

In reply to Umesh Nerlige Ramappa

== Series Details ==

Series: i915/perf: Make sure i915 is loaded before reading proc (rev2)
URL : https://patchwork.freedesktop.org/series/83222/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9231 -> IGTPW_5111
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/index.html

Known issues
------------

Here are the changes found in IGTPW_5111 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-bsw-kefka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-bsw-kefka/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][3] -> [DMESG-FAIL][4] ([i915#541])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@gt_timelines:
- fi-apl-guc: [PASS][5] -> [INCOMPLETE][6] ([i915#1635])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html

* igt@kms_busy@basic@flip:
- fi-kbl-soraka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-kbl-soraka/igt@kms_busy@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-kbl-soraka/igt@kms_busy@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-kbl-7500u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-byt-j1900/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-byt-j1900/igt@[email protected]

#### Possible fixes ####

* igt@fbdev@mmap:
- {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-tgl-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-tgl-dsi/igt@[email protected]

* igt@i915_module_load@reload:
- {fi-ehl-1}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-ehl-1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-ehl-1/igt@[email protected]
- fi-skl-lmem: [DMESG-WARN][17] ([i915#2605]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/fi-skl-lmem/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/fi-skl-lmem/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (44 -> 40)
------------------------------

Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5830 -> IGTPW_5111

CI-20190529: 20190529
CI_DRM_9231: 40b81504461f5cf3d7fc46af5b981aeebd255eea @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5111: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/index.html
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-10-31 02:07 UTC #3 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for i915/perf: Make sure i915 is loaded before reading proc (rev2)

In reply to Umesh Nerlige Ramappa

== Series Details ==

Series: i915/perf: Make sure i915 is loaded before reading proc (rev2)
URL : https://patchwork.freedesktop.org/series/83222/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9231_full -> IGTPW_5111_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_5111_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5111_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5111_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_big_fb@x-tiled-16bpp-rotate-180:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-snb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-snb2/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5111_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fence@parallel@rcs0:
- shard-hsw: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-hsw1/igt@gem_exec_fence@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-hsw2/igt@gem_exec_fence@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#54])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-kbl2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-kbl6/igt@[email protected]
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#1635] / [i915#54])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-apl2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-apl6/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#1635] / [i915#1982]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-apl3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-apl6/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-hsw2/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-hsw6/igt@kms_flip@[email protected]

* igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-glk6/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@ab-hdmi-a1-hdmi-a2.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-glk3/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@ab-hdmi-a1-hdmi-a2.html

* igt@kms_flip@blocking-wf_vblank@a-dp1:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +5 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-kbl4/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-kbl2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][17] -> [FAIL][18] ([i915#2598])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-tglb2/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-tglb7/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check@a-hdmi-a1:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#2122]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-glk4/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-snb: [PASS][21] -> [FAIL][22] ([i915#2546])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-blt:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#49])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-glk8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-glk8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-iclb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109642] / [fdo#111068])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-iclb2/igt@kms_psr2_su@page_flip.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-iclb5/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html

* igt@perf@gen12-unprivileged-single-ctx-counters:
- shard-tglb: [PASS][33] -> [SKIP][34] ([i915#1354]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-tglb1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-tglb2/igt@[email protected]

* igt@perf@polling:
- shard-glk: [PASS][35] -> [SKIP][36] ([fdo#109271] / [i915#1354]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-glk6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-glk3/igt@[email protected]
- shard-apl: [PASS][37] -> [SKIP][38] ([fdo#109271] / [i915#1354] / [i915#1635]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-apl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-apl8/igt@[email protected]
- shard-iclb: [PASS][39] -> [SKIP][40] ([i915#1354]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-iclb8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-iclb8/igt@[email protected]

* igt@perf@stress-open-close:
- shard-kbl: [PASS][41] -> [SKIP][42] ([fdo#109271] / [i915#1354]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-kbl4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-kbl3/igt@[email protected]
- shard-hsw: [PASS][43] -> [SKIP][44] ([fdo#109271]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-hsw7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-hsw2/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [DMESG-WARN][45] ([i915#118] / [i915#95]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-glk8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-glk9/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-priority-all:
- shard-iclb: [INCOMPLETE][47] ([i915#1895]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-iclb1/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-iclb4/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-hsw: [FAIL][49] ([i915#1888] / [i915#2261]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-hsw1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-hsw4/igt@[email protected]
- shard-snb: [INCOMPLETE][51] ([i915#82]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-snb2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-snb4/igt@[email protected]

* igt@i915_pm_backlight@bad-brightness:
- shard-iclb: [INCOMPLETE][53] -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-iclb4/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-iclb3/igt@[email protected]

* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-kbl: [FAIL][55] ([i915#2521]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-kbl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-kbl4/igt@[email protected]
- shard-tglb: [FAIL][57] ([i915#2521]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-tglb3/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-tglb1/igt@[email protected]

* igt@kms_atomic_transition@plane-use-after-nonblocking-unbind-fencing@vga-1-pipe-a:
- shard-hsw: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-hsw6/igt@kms_atomic_transition@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-hsw7/igt@kms_atomic_transition@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][61] ([i915#2370]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-hsw1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-hsw4/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-blt-ytiled:
- shard-apl: [DMESG-WARN][63] ([i915#1635] / [i915#1982]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-apl2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-apl6/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-render-untiled:
- shard-glk: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +7 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-glk8/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-glk7/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][67] ([i915#79]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-glk1/igt@kms_flip@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][69] ([i915#2055]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-hsw7/igt@kms_flip@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-hsw4/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-dp1:
- shard-kbl: [DMESG-FAIL][71] ([i915#1982]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-kbl6/igt@kms_flip@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-dp1:
- shard-kbl: [DMESG-WARN][73] ([i915#1982]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-kbl6/igt@kms_flip@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-iclb: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-iclb2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-iclb6/igt@[email protected]

* igt@kms_vblank@pipe-d-accuracy-idle:
- shard-tglb: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-tglb8/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-tglb5/igt@[email protected]

#### Warnings ####

* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [DMESG-WARN][89] ([i915#1436]) -> [DMESG-WARN][90] ([i915#2411])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9231/shard-tglb1/igt@i915_pm_backlight@fade_with_suspend.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/shard-tglb5/igt@i915_pm_backlight@fade_with_suspend.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (11 -> 8)
------------------------------

Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5830 -> IGTPW_5111
* Piglit: piglit_4509 -> None

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5111/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Petri Latvala

2020-11-02 09:48 UTC #4 lore raw

In reply to Umesh Nerlige Ramappa

Quoted 31 lines · Umesh Nerlige Ramappa

The previous test may have unloaded i915 or failed to load it back. To combat such cases, each test fixture is supposed to ensure that i915 is loaded prior to running the subtests. In most fixtures this happens automatically when we try to get a handle to i915. In perf OA, we stat some proc/sys files even before getting a handle to i915. Occassionally, perf tests fail trying to stat these files. Fix perf OA by checking and loading i915 if it's not loaded.
v2: Remove the if check (Ashutosh)
Closes https://gitlab.freedesktop.org/drm/intel/-/issues/405
Signed-off-by Umesh Nerlige Ramappa <[email protected]>
Reviewed-by Petri Latvala <[email protected]>
Reviewed-by Ashutosh Dixit <[email protected]>
---
 tests/i915/perf.c | 8 ++++++++
 1 file changed, 8 insertions(+)
tests/i915/perf.c +1 -0
index a5c4adc3..bd8281bd 100644
@@ -41,6 +41,7 @@
 #include "i915/gem.h"
 #include "i915/perf.h"
 #include "igt.h"
+#include "igt_kmod.h"
 #include "igt_sysfs.h"
 #include "drm.h"
 

tests/i915/perf.c igt_main · line 4816

Quoted 10 lines

tests/i915/perf.c +7 -0

@@ -4806,6 +4807,13 @@ igt_main
 	igt_fixture {
 		struct stat sb;
 
+		/*
+		 * Prior tests may have unloaded i915 or failed while
+		 * loading/unloading i915. Load i915 here before we stat the
+		 * files.
+		 */
+		igt_i915_driver_load(NULL);
+

Please use drm_load_module() instead, Chris's patch for exporting that is now merged.

Signature · 5 lines

Petri Latvala
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev