mklibs: drop support for
PATCH 1/1 mklibs: drop support for
This is not enabled or tested by default, and has never been ported to python 3 upstream[1], which means it doesn't work at all with plain poky. If you need it, please put it in a separate layer and/or modernize to work with py3.
https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
--- meta-poky/conf/local.conf.sample | 5 +---- meta-poky/conf/local.conf.sample.extended | 9 --------- 2 files changed, 1 insertion(+), 13 deletions(-)
meta-poky/conf/local.conf.sample +1 -4
@@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be included in this variable # are: # - 'buildstats' collect build statistics -# - 'image-mklibs' to reduce shared library files size for an image # - 'image-prelink' in order to prelink the filesystem image -# NOTE: if listing mklibs & prelink both, then make sure mklibs is before prelink -# NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended -USER_CLASSES ?= "buildstats image-mklibs image-prelink" +USER_CLASSES ?= "buildstats image-prelink" # # Runtime testing of images
meta-poky/conf/local.conf.sample.extended +0 -9
@@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11" # # TCMODE ?= "external-sourcery" -# mklibs library size optimization is more useful to smaller images, -# and less useful for bigger images. Also mklibs library optimization -# can break the ABI compatibility, so should not be applied to the -# images which are to be extended or upgraded later. -#This enabled mklibs library size optimization just for the specified image. -#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal" -#This enable mklibs library size optimization will be for all the images. -#MKLIBS_OPTIMIZED_IMAGES ?= "all" - # This value is currently used by pseudo to determine if the recipe should # build both the 32-bit and 64-bit wrapper libraries on a 64-bit build system. #
Signature · 1 line
2.29.0
Quoted 7 lines · Alexander Kanavin
This is not enabled or tested by default, and has never been ported to python 3 upstream[1], which means it doesn't work at all with plain poky. If you need it, please put it in a separate layer and/or modernize to work with py3.
https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
how about trying this patch to make it work with python3? Since we use mklibs as a feature highlight of tools that yocto can provide users, its perhaps good to keep it working.
https://uclibc.org/~kraj/0001-mklib-Port-to-use-python3.patch
Quoted 48 lines
Signed-off-by Alexander Kanavin <[email protected]>--- meta-poky/conf/local.conf.sample | 5 +---- meta-poky/conf/local.conf.sample.extended | 9 --------- 2 files changed, 1 insertion(+), 13 deletions(-)meta-poky/conf/local.conf.sample +1
-4@@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be included in this variable # are: # - 'buildstats' collect build statistics -# - 'image-mklibs' to reduce shared library files size for an image # - 'image-prelink' in order to prelink the filesystem image -# NOTE: if listing mklibs & prelink both, then make sure mklibs is before prelink -# NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended -USER_CLASSES ?= "buildstats image-mklibs image-prelink" +USER_CLASSES ?= "buildstats image-prelink" # # Runtime testing of imagesmeta-poky/conf/local.conf.sample.extended +0
-9@@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11" # # TCMODE ?= "external-sourcery" -# mklibs library size optimization is more useful to smaller images, -# and less useful for bigger images. Also mklibs library optimization -# can break the ABI compatibility, so should not be applied to the -# images which are to be extended or upgraded later. -#This enabled mklibs library size optimization just for the specified image. -#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal" -#This enable mklibs library size optimization will be for all the images. -#MKLIBS_OPTIMIZED_IMAGES ?= "all" - # This value is currently used by pseudo to determine if the recipe should # build both the 32-bit and 64-bit wrapper libraries on a 64-bit build system. #
Apologies, but I have no interest in custom patching, or otherwise maintaining mklibs - there is no evidence that anyone uses it, or if it works at all (as it hasn't been tested on the AB in years, if ever), and so it has to go. There's been no real work on it since at least 2015.
Alex
Quoted 76 lines · Khem Raj
Quoted 7 lines · Alexander Kanavin
This is not enabled or tested by default, and has never been ported to python 3 upstream[1], which means it doesn't work at all with plain poky. If you need it, please put it in a separate layer and/or modernize to work with py3.
https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
how about trying this patch to make it work with python3? Since we use mklibs as a feature highlight of tools that yocto can provide users, its perhaps good to keep it working.
https://uclibc.org/~kraj/0001-mklib-Port-to-use-python3.patch
Review
Quoted 7 lines
Signed-off-by Alexander Kanavin <[email protected]>--- meta-poky/conf/local.conf.sample | 5 +---- meta-poky/conf/local.conf.sample.extended | 9 --------- 2 files changed, 1 insertion(+), 13 deletions(-)(quoted diff) +0
-0b/meta-poky/conf/local.conf.sample
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks" · line 148
Quoted 5 lines
index
68e71b930b..e0ba9a35ef100644meta-poky/conf/local.conf.sample +0
-0@@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be includedin this variable
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks"
Quoted 5 lines
meta-poky/conf/local.conf.sample +0
-2# are: # - 'buildstats' collect build statistics -# - 'image-mklibs' to reduce shared library files size for an image # - 'image-prelink' in order to prelink the filesystem image -# NOTE: if listing mklibs & prelink both, then make sure mklibs isbefore prelink
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks" · line 154
Quoted 1 line
meta-poky/conf/local.conf.sample +0
-1-# NOTE: mklibs also needs to be explicitly enabled for a given image,see local.conf.extended
Review
Quoted 6 lines
meta-poky/conf/local.conf.sample +1
-1-USER_CLASSES ?= "buildstats image-mklibs image-prelink" +USER_CLASSES ?= "buildstats image-prelink" # # Runtime testing of images(quoted diff) +0
-0b/meta-poky/conf/local.conf.sample.extended
meta-poky/conf/local.conf.sample.extended DISTRO_FEATURES_remove = "x11" · line 122
Quoted 12 lines
index
62415a43ed..024bf14af5100644meta-poky/conf/local.conf.sample.extended +0
-5@@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11" # # TCMODE ?= "external-sourcery" -# mklibs library size optimization is more useful to smaller images, -# and less useful for bigger images. Also mklibs library optimization -# can break the ABI compatibility, so should not be applied to the -# images which are to be extended or upgraded later. -#This enabled mklibs library size optimization just for the specifiedimage.
meta-poky/conf/local.conf.sample.extended DISTRO_FEATURES_remove = "x11" · line 124
Quoted 2 lines
meta-poky/conf/local.conf.sample.extended +0
-2-#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal" -#This enable mklibs library size optimization will be for all theimages.
meta-poky/conf/local.conf.sample.extended DISTRO_FEATURES_remove = "x11"
Quoted 3 lines
meta-poky/conf/local.conf.sample.extended +0
-2-#MKLIBS_OPTIMIZED_IMAGES ?= "all" - # This value is currently used by pseudo to determine if the recipeshould
meta-poky/conf/local.conf.sample.extended DISTRO_FEATURES_remove = "x11" · line 119
Quoted 1 line
meta-poky/conf/local.conf.sample.extended +0
-0# build both the 32-bit and 64-bit wrapper libraries on a 64-bit buildsystem.
Quoted 6 lines
meta-poky/conf/local.conf.sample.extended +0
-0#
Quoted 2 lines · Alexander Kanavin
Apologies, but I have no interest in custom patching, or otherwise maintaining mklibs - there is no evidence that anyone uses it, or if it works at all (as it hasn't been tested on the AB in years, if ever), and so it has to go. There's been no real work on it since at least 2015.
It ok if you don't have interest but let's not delete it. I will send
a patch to h
Quoted 71 lines
Alex
Quoted 67 lines · Khem Raj
Quoted 7 lines · Alexander Kanavin
This is not enabled or tested by default, and has never been ported to python 3 upstream[1], which means it doesn't work at all with plain poky. If you need it, please put it in a separate layer and/or modernize to work with py3.
https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
how about trying this patch to make it work with python3? Since we use mklibs as a feature highlight of tools that yocto can provide users, its perhaps good to keep it working.
https://uclibc.org/~kraj/0001-mklib-Port-to-use-python3.patch
Quoted 48 lines
Signed-off-by Alexander Kanavin <[email protected]>--- meta-poky/conf/local.conf.sample | 5 +---- meta-poky/conf/local.conf.sample.extended | 9 --------- 2 files changed, 1 insertion(+), 13 deletions(-)meta-poky/conf/local.conf.sample +1
-4@@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be included in this variable # are: # - 'buildstats' collect build statistics -# - 'image-mklibs' to reduce shared library files size for an image # - 'image-prelink' in order to prelink the filesystem image -# NOTE: if listing mklibs & prelink both, then make sure mklibs is before prelink -# NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended -USER_CLASSES ?= "buildstats image-mklibs image-prelink" +USER_CLASSES ?= "buildstats image-prelink" # # Runtime testing of imagesmeta-poky/conf/local.conf.sample.extended +0
-9@@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11" # # TCMODE ?= "external-sourcery" -# mklibs library size optimization is more useful to smaller images, -# and less useful for bigger images. Also mklibs library optimization -# can break the ABI compatibility, so should not be applied to the -# images which are to be extended or upgraded later. -#This enabled mklibs library size optimization just for the specified image. -#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal" -#This enable mklibs library size optimization will be for all the images. -#MKLIBS_OPTIMIZED_IMAGES ?= "all" - # This value is currently used by pseudo to determine if the recipe should # build both the 32-bit and 64-bit wrapper libraries on a 64-bit build system. #