Skip to contentSkip to conversation

drm/panfrost: Remove unused variables in panfrost_job_close()

PATCH In review Boris Brezillon 2 participants 3 messages Nov 1, 2020 – Nov 3, 2020

Subsystems (3)
lore
Share & tools
lore

Boris Brezillon

author maintainer
#0 lore raw

PATCH 1/1 drm/panfrost: Remove unused variables in panfrost_job_close()

Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close") left unused variables behind, thus generating a warning at compilation time. Remove those variables.

Fixes a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close")

---
My bad, I didn't notice this warning when rebasing Steven's patch on top of drm-misc-next :-/

---
 drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/panfrost/panfrost_job.c +0 -2
index 14c11293791e..d58e5fe12cab 100644
@@ -634,8 +634,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
 
 void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
 {
-	struct panfrost_device *pfdev = panfrost_priv->pfdev;
-	struct panfrost_job_slot *js = pfdev->js;
 	int i;
 
 	for (i = 0; i < NUM_JOB_SLOTS; i++)
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Boris Brezillon

Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close") left unused variables behind, thus generating a warning at compilation time. Remove those variables.

Fixes a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close")
Quoted 3 lines

---
My bad, I didn't notice this warning when rebasing Steven's patch on top of drm-misc-next :-/

Partly my fault - I think I forgot to rebase the patch on drm-misc-next before posting. Thanks for fixing it.

Steve

Quoted 10 lines
---
  drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
  1 file changed, 2 deletions(-)
drivers/gpu/drm/panfrost/panfrost_job.c +0 -0
index 14c11293791e..d58e5fe12cab 100644

drivers/gpu/drm/panfrost/panfrost_job.c int panfrost_job_open(struct panfrost_file_priv *panfrost_priv) · line 639

Quoted 8 lines
drivers/gpu/drm/panfrost/panfrost_job.c +0 -2
@@ -634,8 +634,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
 
  void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
  {
-	struct panfrost_device *pfdev = panfrost_priv->pfdev;
-	struct panfrost_job_slot *js = pfdev->js;
  	int i;
 
  	for (i = 0; i < NUM_JOB_SLOTS; i++)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#2 lore raw
Quoted 9 lines · On Mon, 2 Nov 2020 08:39:29 +0000 Steven Price <[email protected]> wrote:
Quoted 6 lines · Boris Brezillon

Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close") left unused variables behind, thus generating a warning at compilation time. Remove those variables.

Fixes a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close")

Queued to drm-misc-next.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel