Skip to contentSkip to conversation

ALSA: hda: prevent undefined shift in snd_hdac_ext_bus_get_link()

PATCH Applied Dan Carpenter 2 participants 2 messages Nov 3, 2020

Subsystems (2)
Sound Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ALSA: hda: prevent undefined shift in snd_hdac_ext_bus_get_link()

This is harmless, but the "addr" comes from the user and it could lead to a negative shift or to shift wrapping if it's too high.

Fixes 0b00a5615dc4 ("ALSA: hdac_ext: add hdac extended controller")
Signed-off-by Dan Carpenter <[email protected]>
---
 sound/hda/ext/hdac_ext_controller.c | 2 ++
 1 file changed, 2 insertions(+)
sound/hda/ext/hdac_ext_controller.c +2 -0
index 4d060d5b1db6..b0c0ef824d7d 100644
@@ -148,6 +148,8 @@ struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_bus *bus,
 		return NULL;
 	if (bus->idx != bus_idx)
 		return NULL;
+	if (addr < 0 || addr > 31)
+		return NULL;
 
 	list_for_each_entry(hlink, &bus->hlink_list, list) {
 		for (i = 0; i < HDA_MAX_CODECS; i++) {
Signature · 1 line
2.28.0
Applied
#1 lore raw
Quoted 6 lines · Dan Carpenter

This is harmless, but the "addr" comes from the user and it could lead to a negative shift or to shift wrapping if it's too high.

Fixes 0b00a5615dc4 ("ALSA: hdac_ext: add hdac extended controller")
Signed-off-by Dan Carpenter <[email protected]>

Thanks, applied.

Takashi