Skip to contentSkip to conversation

drm/amd/display: fix psr panel lightup

PATCH In review [email protected] 2 participants 2 messages Nov 3, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: fix psr panel lightup

From: Roman Li <[email protected]>

[Why]
The change for correct asic type check
caused a psr regression due to incorrect
chip family id for Raven.

[How]
Use correct family id.

---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +1 -1
index 6b8bc8dde6ea..09b51fca3d44 100644
@@ -2740,7 +2740,7 @@ bool dc_link_setup_psr(struct dc_link *link,
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
 	/*skip power down the single pipe since it blocks the cstate*/
-	if ((link->ctx->asic_id.chip_family == FAMILY_AI) &&
+	if ((link->ctx->asic_id.chip_family == FAMILY_RV) &&
 	     ASICREV_IS_RAVEN(link->ctx->asic_id.hw_internal_rev))
 		psr_context->psr_level.bits.SKIP_CRTC_DISABLE = true;
 #endif
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
maintainer Reviewed-by on v1 1/1
#1 lore raw

________________________________
From: [email protected] <[email protected]>
Sent: Tuesday, November 3, 2020 6:12 PM
To: [email protected] <[email protected]>; Deucher, Alexander <[email protected]>; Quan, Evan <[email protected]>; Siqueira, Rodrigo <[email protected]>; Pillai, Aurabindo <[email protected]>
Cc: Li, Roman <[email protected]>
Subject: [PATCH] drm/amd/display: fix psr panel lightup

From: Roman Li <[email protected]>

[Why]
The change for correct asic type check
caused a psr regression due to incorrect
chip family id for Raven.

[How]
Use correct family id.

---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +1 -1
index 6b8bc8dde6ea..09b51fca3d44 100644
@@ -2740,7 +2740,7 @@ bool dc_link_setup_psr(struct dc_link *link,
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
         /*skip power down the single pipe since it blocks the cstate*/
-       if ((link->ctx->asic_id.chip_family == FAMILY_AI) &&
+       if ((link->ctx->asic_id.chip_family == FAMILY_RV) &&
              ASICREV_IS_RAVEN(link->ctx->asic_id.hw_internal_rev))
                 psr_context->psr_level.bits.SKIP_CRTC_DISABLE = true;
 #endif

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx