arm64: dts: marvell: espressobin: Add ethernet switch aliases

PATCH In review Pali Rohár 2 participants 2 messages Nov 4, 2020 – Nov 9, 2020

Subsystems (3)

Stable branch Device tree bindings Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support

lore

Share & tools

lore

Pali Rohár

author

2020-11-04 11:53 UTC #0 lore raw

PATCH 1/1 arm64: dts: marvell: espressobin: Add ethernet switch aliases

commit b64d814257b027e29a474bcd660f6372490138c7 upstream.

Espressobin boards have 3 ethernet ports and some of them got assigned more then one MAC address. MAC addresses are stored in U-Boot environment.

Since commit a2c7023f7075c ("net: dsa: read mac address from DT for slave device") kernel can use MAC addresses from DT for particular DSA port.

Currently Espressobin DTS file contains alias just for ethernet0.

This patch defines additional ethernet aliases in Espressobin DTS files, so bootloader can fill correct MAC address for DSA switch ports if more MAC addresses were specified.

DT alias ethernet1 is used for wan port, DT aliases ethernet2 and ethernet3 are used for lan ports for both Espressobin revisions (V5 and V7).

Fixes 5253cb8c00a6f ("arm64: dts: marvell: espressobin: add ethernet alias")

Cc <[email protected]> # a2c7023f7075c: dsa: read mac address

Signed-off-by Pali Rohár <[email protected]>

Reviewed-by Andrew Lunn <[email protected]>

Reviewed-by Andre Heider <[email protected]>

Signed-off-by Gregory CLEMENT <[email protected]>

[pali: Backported Espressobin rev V5 changes to 5.4 and 4.19 versions]

---
This patch is backport for 5.4 and 4.19 stable releases. From original patch were removed changes for Espressobin revision V7 as these older kernel versions have DTS files only for Espressobin revision V5.

Note that this patch depends on commit a2c7023f7075c ("dsa: read mac address") as stated on Cc: line and for 4.19 release needs to be backported first.

---
 .../boot/dts/marvell/armada-3720-espressobin.dts     | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +8 -4

index 05dc58c13fa4..6226e7e80980 100644
@@ -21,6 +21,10 @@
 
 	aliases {
 		ethernet0 = &eth0;
+		/* for dsa slave device */
+		ethernet1 = &switch0port1;
+		ethernet2 = &switch0port2;
+		ethernet3 = &switch0port3;
 		serial0 = &uart0;
 		serial1 = &uart1;
 	};

@@ -147,7 +151,7 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 
-			port@0 {
+			switch0port0: port@0 {
 				reg = <0>;
 				label = "cpu";
 				ethernet = <&eth0>;

@@ -158,19 +162,19 @@
 				};
 			};
 
-			port@1 {
+			switch0port1: port@1 {
 				reg = <1>;
 				label = "wan";
 				phy-handle = <&switch0phy0>;
 			};
 
-			port@2 {
+			switch0port2: port@2 {
 				reg = <2>;
 				label = "lan0";
 				phy-handle = <&switch0phy1>;
 			};
 
-			port@3 {
+			switch0port3: port@3 {
 				reg = <3>;
 				label = "lan1";
 				phy-handle = <&switch0phy2>;

Signature · 1 line

2.20.1

Greg KH

maintainer

2020-11-09 12:22 UTC #1 lore raw

Quoted 30 lines · Pali Rohár

commit b64d814257b027e29a474bcd660f6372490138c7 upstream.
Espressobin boards have 3 ethernet ports and some of them got assigned more then one MAC address. MAC addresses are stored in U-Boot environment.
Since commit a2c7023f7075c ("net: dsa: read mac address from DT for slave device") kernel can use MAC addresses from DT for particular DSA port.
Currently Espressobin DTS file contains alias just for ethernet0.
This patch defines additional ethernet aliases in Espressobin DTS files, so bootloader can fill correct MAC address for DSA switch ports if more MAC addresses were specified.
DT alias ethernet1 is used for wan port, DT aliases ethernet2 and ethernet3 are used for lan ports for both Espressobin revisions (V5 and V7).
Fixes 5253cb8c00a6f ("arm64: dts: marvell: espressobin: add ethernet alias")
Cc <[email protected]> # a2c7023f7075c: dsa: read mac address
Signed-off-by Pali Rohár <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>
Reviewed-by Andre Heider <[email protected]>
Signed-off-by Gregory CLEMENT <[email protected]>
[pali: Backported Espressobin rev V5 changes to 5.4 and 4.19 versions]
---
This patch is backport for 5.4 and 4.19 stable releases. From original patch were removed changes for Espressobin revision V7 as these older kernel versions have DTS files only for Espressobin revision V5.

Quoted 6 lines

Note that this patch depends on commit a2c7023f7075c ("dsa: read mac address") as stated on Cc: line and for 4.19 release needs to be backported first.
---
 .../boot/dts/marvell/armada-3720-espressobin.dts     | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Now queued up, thanks.

greg k-h