Skip to contentSkip to conversation

Nexus 7 and A500 device-tree improvements

PATCH In review Dmitry Osipenko 2 participants 12 messages Nov 4, 2020 – Nov 10, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover Nexus 7 and A500 device-tree improvements

This series improves device-trees of Nexus 7 and A500 devices by correcting old and adding new DT properties.

Changelog:

v2: - Added these two additional patches:

ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

Dmitry Osipenko (8):
ARM: tegra: acer-a500: Correct thermal zone names
ARM: tegra: acer-a500: Add power-supply to lvds-encoder node
ARM: tegra: nexus7: Correct thermal zone names
ARM: tegra: nexus7: Improve CPU passive-cooling threshold
ARM: tegra: nexus7: Add power-supply to lvds-encoder node
ARM: tegra: nexus7: Rename gpio-hog nodes
ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

 .../boot/dts/tegra20-acer-a500-picasso.dts    |  5 ++--
 .../tegra30-asus-nexus7-grouper-common.dtsi   | 30 +++++++++++++------
 ...egra30-asus-nexus7-grouper-maxim-pmic.dtsi |  2 +-
 .../boot/dts/tegra30-asus-nexus7-tilapia.dtsi |  2 +-
 4 files changed, 26 insertions(+), 13 deletions(-)
Signature · 1 line
2.27.0
#1 lore raw

PATCH v2 1/8 ARM: tegra: acer-a500: Correct thermal zone names

Rename thermal zones in order fix dt_binding_check warning telling that names do not match the expected pattern.

---
 arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra20-acer-a500-picasso.dts +2 -2
index 575898e8c785..8e3e79b734b0 100644
@@ -1063,14 +1063,14 @@ sound {
 	};
 
 	thermal-zones {
-		nct1008-local {
+		skin-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <0>; /* milliseconds */
 
 			thermal-sensors = <&nct1008 0>;
 		};
 
-		nct1008-remote {
+		cpu-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <5000>; /* milliseconds */
 
Signature · 1 line
2.27.0
#2 lore raw

PATCH v2 2/8 ARM: tegra: acer-a500: Add power-supply to lvds-encoder node

In reply to Dmitry Osipenko

The lvds-encoder binding now supports power-supply property, let's specify it in the device-tree for completeness.

---
 arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/tegra20-acer-a500-picasso.dts +1 -0
index 8e3e79b734b0..09329cb4993a 100644
@@ -950,6 +950,7 @@ lvds-encoder {
 		compatible = "ti,sn75lvds83", "lvds-encoder";
 
 		powerdown-gpios = <&gpio TEGRA_GPIO(B, 2) GPIO_ACTIVE_LOW>;
+		power-supply = <&vdd_3v3_sys>;
 
 		ports {
 			#address-cells = <1>;
Signature · 1 line
2.27.0
#3 lore raw

PATCH v2 3/8 ARM: tegra: nexus7: Correct thermal zone names

In reply to Dmitry Osipenko

Rename thermal zones in order fix dt_binding_check warning telling that names do not match the expected pattern.

---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi +2 -2
index 2b405872ad2d..543c52cd8260 100644
@@ -1267,14 +1267,14 @@ sound {
 	};
 
 	thermal-zones {
-		nct72-local {
+		skin-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <0>; /* milliseconds */
 
 			thermal-sensors = <&nct72 0>;
 		};
 
-		nct72-remote {
+		cpu-thermal {
 			polling-delay-passive = <1000>; /* milliseconds */
 			polling-delay = <5000>; /* milliseconds */
 
Signature · 1 line
2.27.0
#4 lore raw

PATCH v2 4/8 ARM: tegra: nexus7: Improve CPU passive-cooling threshold

In reply to Dmitry Osipenko

The current CPU thermal limit is a bit inappropriate for Nexus 7 once device is getting used on a daily bases. For example, currently it's may be impossible to watch a hardware accelerated 720p video without hitting a severe CPU throttling, which ruins user experience. This patch improves the thermal throttling thresholds.

In my experience setting CPU thermal threshold to 57C provides the most reasonable result, where device is a bit warm under constant load and not getting overly hot, in the same time performance is okay. Let's bump the passive-cooling threshold from 50C to 57C and also lower the thermal hysteresis to 0.2C in order to make throttling more reactive.

---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi +3 -3
index 543c52cd8260..adc708bbfb62 100644
@@ -1282,9 +1282,9 @@ cpu-thermal {
 
 			trips {
 				trip0: cpu-alert0 {
-					/* start throttling at 50C */
-					temperature = <50000>;
-					hysteresis = <3000>;
+					/* throttle at 57C until temperature drops to 56.8C */
+					temperature = <57000>;
+					hysteresis = <200>;
 					type = "passive";
 				};
 
Signature · 1 line
2.27.0
#5 lore raw

PATCH v2 5/8 ARM: tegra: nexus7: Add power-supply to lvds-encoder node

In reply to Dmitry Osipenko

The lvds-encoder binding now supports power-supply property, let's specify it in the device-tree for completeness.

---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi +1 -0
index adc708bbfb62..c2b1229f0d83 100644
@@ -1172,6 +1172,7 @@ lvds-encoder {
 		compatible = "ti,sn75lvds83", "lvds-encoder";
 
 		powerdown-gpios = <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
+		power-supply = <&vdd_3v3_sys>;
 
 		ports {
 			#address-cells = <1>;
Signature · 1 line
2.27.0
#6 lore raw

PATCH v2 6/8 ARM: tegra: nexus7: Rename gpio-hog nodes

In reply to Dmitry Osipenko

Devicetree schema now requires gpio-hog nodes to have a certain naming pattern, like a -hog suffix. This patch fixes dtbs_check warnings about the names.

---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi     | 4 ++--
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi | 2 +-
 arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi            | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi +2 -2
index c2b1229f0d83..7fe584d69f5d 100644
@@ -91,7 +91,7 @@ dc@54240000 {
 	};
 
 	gpio@6000d000 {
-		init-mode {
+		init-mode-hog {
 			gpio-hog;
 			gpios =	<TEGRA_GPIO(DD, 7) GPIO_ACTIVE_HIGH>,
 				<TEGRA_GPIO(CC, 6) GPIO_ACTIVE_HIGH>,
@@ -99,7 +99,7 @@ init-mode {
 			output-low;
 		};
 
-		init-low-power-mode {
+		init-low-power-mode-hog {
 			gpio-hog;
 			gpios = <TEGRA_GPIO(I, 6) GPIO_ACTIVE_HIGH>;
 			input;
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi +1 -1
index b25b3fa90ac6..17b6682ffce8 100644
@@ -29,7 +29,7 @@ gpio4 {
 				};
 			};
 
-			cpu-pwr-req {
+			cpu-pwr-req-hog {
 				gpio-hog;
 				gpios = <6 GPIO_ACTIVE_HIGH>;
 				input;
arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi +1 -1
index e3da89f1941a..a681ad51fddd 100644
@@ -23,7 +23,7 @@ panel-timing {
 	};
 
 	gpio@6000d000 {
-		init-mode-3g {
+		init-mode-3g-hog {
 			gpio-hog;
 			gpios =	<TEGRA_GPIO(D, 2) GPIO_ACTIVE_HIGH>,
 				<TEGRA_GPIO(C, 6) GPIO_ACTIVE_HIGH>,
Signature · 1 line
2.27.0
#7 lore raw

PATCH v2 7/8 ARM: tegra: nexus7: Set video decoder clock rate to 408MHz

In reply to Dmitry Osipenko

The default 600MHz is technically unsupported on Nexus 7. Assign VDE clock to 408MHz, which is supported by all hardware versions.

---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi +3 -0
index 7fe584d69f5d..fb5b33f1bcd8 100644
@@ -107,6 +107,9 @@ init-low-power-mode-hog {
 	};
 
 	vde@6001a000 {
+		assigned-clocks = <&tegra_car TEGRA30_CLK_VDE>;
+		assigned-clock-parents = <&tegra_car TEGRA30_CLK_PLL_P>;
+		assigned-clock-rates = <408000000>;
 		core-supply = <&vdd_core>;
 	};
 
Signature · 1 line
2.27.0
#8 lore raw

Re: [PATCH v2 7/8] ARM: tegra: nexus7: Set video decoder clock rate to 408MHz

Quoted 7 lines · Dmitry Osipenko

The default 600MHz is technically unsupported on Nexus 7. Assign VDE clock to 408MHz, which is supported by all hardware versions.

---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 3 +++
 1 file changed, 3 insertions(+)

This doesn't seem to apply. Is there another patch that this depends on?

Thierry

#9 lore raw

Re: [PATCH v2 7/8] ARM: tegra: nexus7: Set video decoder clock rate to 408MHz

10.11.2020 20:58, Thierry Reding пишет:

Quoted 10 lines · Dmitry Osipenko
Quoted 7 lines

The default 600MHz is technically unsupported on Nexus 7. Assign VDE clock to 408MHz, which is supported by all hardware versions.

---
 arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 3 +++
 1 file changed, 3 insertions(+)

This doesn't seem to apply. Is there another patch that this depends on?

Indeed, this patch was done on top of the "core voltage scaling" series. I'll rebase and send it separately, thanks.

#10 lore raw

PATCH v2 8/8 ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

In reply to Dmitry Osipenko

Depending on a driver probe order, panel-simple driver may probe first, which results in this error:

panel-simple display-panel: Reject override mode: panel has a fixed mode

We don't want to use panel-simple anyways because customized timings are preferred for Nexus 7, hence remove the panel-simple compatibles from the panel node.

---
 .../boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi +10 -2
index fb5b33f1bcd8..df33f3db8a38 100644
@@ -1103,8 +1103,16 @@ cpu@3 {
 	};
 
 	display-panel {
-		compatible = "hydis,hv070wx2-1e0", "chunghwa,claa070wp03xg",
-			     "panel-lvds";
+		/*
+		 * Nexus 7 supports two compatible panel models:
+		 *
+		 *  1. hydis,hv070wx2-1e0
+		 *  2. chunghwa,claa070wp03xg
+		 *
+		 * We want to use timing which is optimized for Nexus 7,
+		 * hence we need to customize the timing.
+		 */
+		compatible = "panel-lvds";
 
 		power-supply = <&vdd_pnl>;
 		backlight = <&backlight>;
Signature · 1 line
2.27.0
#11 lore raw
In reply to Dmitry Osipenko
Quoted 20 lines · Dmitry Osipenko

This series improves device-trees of Nexus 7 and A500 devices by correcting old and adding new DT properties.

Changelog:

v2: - Added these two additional patches:

ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

Dmitry Osipenko (8):
ARM: tegra: acer-a500: Correct thermal zone names
ARM: tegra: acer-a500: Add power-supply to lvds-encoder node
ARM: tegra: nexus7: Correct thermal zone names
ARM: tegra: nexus7: Improve CPU passive-cooling threshold
ARM: tegra: nexus7: Add power-supply to lvds-encoder node
ARM: tegra: nexus7: Rename gpio-hog nodes
ARM: tegra: nexus7: Set video decoder clock rate to 408MHz
ARM: tegra: nexus7: Use panel-lvds as the only panel compatible

Quoted 5 lines
 .../boot/dts/tegra20-acer-a500-picasso.dts    |  5 ++--
 .../tegra30-asus-nexus7-grouper-common.dtsi   | 30 +++++++++++++------
 ...egra30-asus-nexus7-grouper-maxim-pmic.dtsi |  2 +-
 .../boot/dts/tegra30-asus-nexus7-tilapia.dtsi |  2 +-
 4 files changed, 26 insertions(+), 13 deletions(-)

Applied all of these except patch 7. Let me know if there is some other patch that I need to pull in first.

Thierry