Skip to contentSkip to conversation

thinkpad_acpi: add P1 gen3 second fan support

PATCH In review Iakov 'Jake' Kirilenko 2 participants 2 messages Nov 5, 2020 – Nov 9, 2020 x86 platform drivers

lore
Share & tools
lore

Iakov 'Jake' Kirilenko

author
#0 lore raw

PATCH 1/1 thinkpad_acpi: add P1 gen3 second fan support

Tested on my P1 gen3, works fine with thinkfan. Since thinkpad_acpi fan control is off by default, it is safe to add 2nd fan control for brave overclockers

Signed-off-by Iakov 'Jake' Kirilenko <[email protected]>
---
 drivers/platform/x86/thinkpad_acpi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/thinkpad_acpi.c +1 -0
index e38106750..4d64ba291 100644
@@ -8776,6 +8776,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
 	TPACPI_Q_LNV3('N', '2', 'C', TPACPI_FAN_2CTL),	/* P52 / P72 */
 	TPACPI_Q_LNV3('N', '2', 'E', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (1st gen) */
 	TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (2nd gen) */
+	TPACPI_Q_LNV3('N', '2', 'V', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (3nd gen) */
 };
 
 static int __init fan_init(struct ibm_init_struct *iibm)
Signature · 1 line
2.29.2
#1 lore raw

Hi,

Quoted 5 lines · Iakov 'Jake' Kirilenko

Tested on my P1 gen3, works fine with thinkfan. Since thinkpad_acpi fan control is off by default, it is safe to add 2nd fan control for brave overclockers

Signed-off-by Iakov 'Jake' Kirilenko <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 17 lines
---
 drivers/platform/x86/thinkpad_acpi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/thinkpad_acpi.c +1 -0
index e38106750..4d64ba291 100644
@@ -8776,6 +8776,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
 	TPACPI_Q_LNV3('N', '2', 'C', TPACPI_FAN_2CTL),	/* P52 / P72 */
 	TPACPI_Q_LNV3('N', '2', 'E', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (1st gen) */
 	TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (2nd gen) */
+	TPACPI_Q_LNV3('N', '2', 'V', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (3nd gen) */
 };
 
 static int __init fan_init(struct ibm_init_struct *iibm)