Skip to contentSkip to conversation

PCI: Disable MSI for Pericom PCIe-USB adapter

PATCH In review Andy Shevchenko 3 participants 9 messages Nov 6, 2020 – Nov 18, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 PCI: Disable MSI for Pericom PCIe-USB adapter

Pericom PCIe-USB adapter advertises MSI, but documentation says "The MSI Function is not implemented on this device." in the chapters 7.3.27, 7.3.29-7.3.31.

Fixes 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

Datasheet: https://www.diodes.com/assets/Datasheets/PI7C9X440SL.pdf

---
v2: dropped confusing word (David), added ifdeffery (Ben)

 drivers/pci/quirks.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/pci/quirks.c +13 -4
index f70692ac79c5..e66e0cc8f99b 100644
@@ -5567,17 +5567,26 @@ static void pci_fixup_no_d0_pme(struct pci_dev *dev)
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x2142, pci_fixup_no_d0_pme);
 
 /*
- * Device [12d8:0x400e] and [12d8:0x400f]
+ * Device 12d8:0x400e [OHCI] and 12d8:0x400f [EHCI]
+ *
  * These devices advertise PME# support in all power states but don't
  * reliably assert it.
+ *
+ * These devices advertise MSI, but documentation (PI7C9X440SL.pdf) says
+ * "The MSI Function is not implemented on this device." in the chapters
+ * 7.3.27, 7.3.29-7.3.31.
  */
-static void pci_fixup_no_pme(struct pci_dev *dev)
+static void pci_fixup_no_msi_no_pme(struct pci_dev *dev)
 {
+#ifdef CONFIG_PCI_MSI
+	pci_info(dev, "The MSI is not implemented on this device, disabling it\n");
+	dev->no_msi = 1;
+#endif
 	pci_info(dev, "PME# is unreliable, disabling it\n");
 	dev->pme_support = 0;
 }
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_pme);
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_pme);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_msi_no_pme);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_msi_no_pme);
 
 static void apex_pci_fixup_class(struct pci_dev *pdev)
 {
Signature · 1 line
2.28.0
#1 lore raw

PATCH v2 2/2 PCI: Use predefined Pericom vendor ID

Pericom has predefined vendor ID, use it instead of hard coded value.

---
v2: no changes

 drivers/pci/quirks.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pci/quirks.c +3 -3
index e66e0cc8f99b..11409f04023c 100644
@@ -2356,9 +2356,9 @@ static void quirk_enable_clear_retrain_link(struct pci_dev *dev)
 	dev->clear_retrain_link = 1;
 	pci_info(dev, "Enable PCIe Retrain Link quirk\n");
 }
-DECLARE_PCI_FIXUP_HEADER(0x12d8, 0xe110, quirk_enable_clear_retrain_link);
-DECLARE_PCI_FIXUP_HEADER(0x12d8, 0xe111, quirk_enable_clear_retrain_link);
-DECLARE_PCI_FIXUP_HEADER(0x12d8, 0xe130, quirk_enable_clear_retrain_link);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_PERICOM, 0xe110, quirk_enable_clear_retrain_link);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_PERICOM, 0xe111, quirk_enable_clear_retrain_link);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_PERICOM, 0xe130, quirk_enable_clear_retrain_link);
 
 static void fixup_rev1_53c810(struct pci_dev *dev)
 {
Signature · 1 line
2.28.0
#2 lore raw
In reply to Andy Shevchenko
Quoted 7 lines · Andy Shevchenko

Pericom PCIe-USB adapter advertises MSI, but documentation says "The MSI Function is not implemented on this device." in the chapters 7.3.27, 7.3.29-7.3.31.

Fixes 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

Datasheet: https://www.diodes.com/assets/Datasheets/PI7C9X440SL.pdf

Reported-by [email protected]

Is there a URL to a problem report we can include here?

Quoted 44 lines

---
v2: dropped confusing word (David), added ifdeffery (Ben)

 drivers/pci/quirks.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/pci/quirks.c +13 -4
index f70692ac79c5..e66e0cc8f99b 100644
@@ -5567,17 +5567,26 @@ static void pci_fixup_no_d0_pme(struct pci_dev *dev)
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x2142, pci_fixup_no_d0_pme);
 
 /*
- * Device [12d8:0x400e] and [12d8:0x400f]
+ * Device 12d8:0x400e [OHCI] and 12d8:0x400f [EHCI]
+ *
  * These devices advertise PME# support in all power states but don't
  * reliably assert it.
+ *
+ * These devices advertise MSI, but documentation (PI7C9X440SL.pdf) says
+ * "The MSI Function is not implemented on this device." in the chapters
+ * 7.3.27, 7.3.29-7.3.31.
  */
-static void pci_fixup_no_pme(struct pci_dev *dev)
+static void pci_fixup_no_msi_no_pme(struct pci_dev *dev)
 {
+#ifdef CONFIG_PCI_MSI
+	pci_info(dev, "The MSI is not implemented on this device, disabling it\n");
+	dev->no_msi = 1;
+#endif
 	pci_info(dev, "PME# is unreliable, disabling it\n");
 	dev->pme_support = 0;
 }
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_pme);
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_pme);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_msi_no_pme);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_msi_no_pme);
 
 static void apex_pci_fixup_class(struct pci_dev *pdev)
 {
Signature · 1 line
2.28.0
#3 lore raw
Quoted 10 lines · Bjorn Helgaas
Quoted 7 lines · Andy Shevchenko

Pericom PCIe-USB adapter advertises MSI, but documentation says "The MSI Function is not implemented on this device." in the chapters 7.3.27, 7.3.29-7.3.31.

Fixes 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

Datasheet: https://www.diodes.com/assets/Datasheets/PI7C9X440SL.pdf

Reported-by [email protected]

Is there a URL to a problem report we can include here?

You mean URL to email archives or something else?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Bjorn Helgaas
Quoted 4 lines · Andy Shevchenko

Pericom PCIe-USB adapter advertises MSI, but documentation says "The MSI Function is not implemented on this device." in the chapters 7.3.27, 7.3.29-7.3.31.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Fixes 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

Datasheet: https://www.diodes.com/assets/Datasheets/PI7C9X440SL.pdf

Reported-by [email protected]

Is there a URL to a problem report we can include here?

You mean URL to email archives or something else?

Yes. URL to lore email archive, bugzilla, or any other report of the problem this caused, i.e., how Alberto noticed something wrong.

#5 lore raw
Quoted 11 lines · Bjorn Helgaas
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · Bjorn Helgaas
Quoted 7 lines · Andy Shevchenko

Pericom PCIe-USB adapter advertises MSI, but documentation says "The MSI Function is not implemented on this device." in the chapters 7.3.27, 7.3.29-7.3.31.

Fixes 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

Datasheet: https://www.diodes.com/assets/Datasheets/PI7C9X440SL.pdf

Reported-by [email protected]
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Is there a URL to a problem report we can include here?

You mean URL to email archives or something else?

Yes. URL to lore email archive, bugzilla, or any other report of the problem this caused, i.e., how Alberto noticed something wrong.

Okay, I'll include in v3.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw
Quoted 12 lines · Andy Shevchenko
Quoted 11 lines · Bjorn Helgaas
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · Bjorn Helgaas
Quoted 7 lines · Andy Shevchenko

Pericom PCIe-USB adapter advertises MSI, but documentation says "The MSI Function is not implemented on this device." in the chapters 7.3.27, 7.3.29-7.3.31.

Fixes 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

Datasheet: https://www.diodes.com/assets/Datasheets/PI7C9X440SL.pdf

Reported-by [email protected]
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Is there a URL to a problem report we can include here?

You mean URL to email archives or something else?

Yes. URL to lore email archive, bugzilla, or any other report of the problem this caused, i.e., how Alberto noticed something wrong.

Okay, I'll include in v3.

I may not include that. It misses archives probably due to some footer in the message. Closest what I have found is [1].
Do you still want me to include that link?

[1]: https://lore.kernel.org/linux-usb/[email protected]/

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw
In reply to Andy Shevchenko
Quoted 8 lines · Andy Shevchenko

Pericom PCIe-USB adapter advertises MSI, but documentation says "The MSI Function is not implemented on this device." in the chapters 7.3.27, 7.3.29-7.3.31.

Fixes 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices")

Datasheet: https://www.diodes.com/assets/Datasheets/PI7C9X440SL.pdf

I added the URL you sent and applied both of these, thanks!

Quoted 43 lines

---
v2: dropped confusing word (David), added ifdeffery (Ben)

 drivers/pci/quirks.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/pci/quirks.c +13 -4
index f70692ac79c5..e66e0cc8f99b 100644
@@ -5567,17 +5567,26 @@ static void pci_fixup_no_d0_pme(struct pci_dev *dev)
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x2142, pci_fixup_no_d0_pme);
 
 /*
- * Device [12d8:0x400e] and [12d8:0x400f]
+ * Device 12d8:0x400e [OHCI] and 12d8:0x400f [EHCI]
+ *
  * These devices advertise PME# support in all power states but don't
  * reliably assert it.
+ *
+ * These devices advertise MSI, but documentation (PI7C9X440SL.pdf) says
+ * "The MSI Function is not implemented on this device." in the chapters
+ * 7.3.27, 7.3.29-7.3.31.
  */
-static void pci_fixup_no_pme(struct pci_dev *dev)
+static void pci_fixup_no_msi_no_pme(struct pci_dev *dev)
 {
+#ifdef CONFIG_PCI_MSI
+	pci_info(dev, "The MSI is not implemented on this device, disabling it\n");
+	dev->no_msi = 1;
+#endif
 	pci_info(dev, "PME# is unreliable, disabling it\n");
 	dev->pme_support = 0;
 }
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_pme);
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_pme);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_msi_no_pme);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400f, pci_fixup_no_msi_no_pme);
 
 static void apex_pci_fixup_class(struct pci_dev *pdev)
 {
Signature · 1 line
2.28.0
#8 lore raw
Quoted 1 line · Bjorn Helgaas

On Fri, Nov 06, 2020 at 12:05:25PM +0200, Andy Shevchenko wrote:

...

Quoted 1 line

I added the URL you sent and applied both of these, thanks!

Thank you!

Signature · 2 lines
With Best Regards,
Andy Shevchenko