auxdisplay: fix use after free in lcd2s_i2c_remove()
Subsystems (2)
PATCH 1/1 auxdisplay: fix use after free in lcd2s_i2c_remove()
The kfree() needs to be moved down a line to prevent a use after free.
Fixes 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/auxdisplay/lcd2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/auxdisplay/lcd2s.c +1 -1
@@ -348,8 +348,8 @@ static int lcd2s_i2c_remove(struct i2c_client *i2c) {struct lcd2s_data *lcd2s =i2c_get_clientdata (i2c); -kfree (lcd2s->charlcd);charlcd_unregister (lcd2s->charlcd); +kfree (lcd2s->charlcd);return 0 ; }
Signature · 1 line
2.28.0
Quoted 13 lines · Dan Carpenter
The
kfree()needs to be moved down a line to prevent a use after free.Fixes 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")Signed-off-by Dan Carpenter <[email protected]>--- drivers/auxdisplay/lcd2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/auxdisplay/lcd2s.c +0
-0
drivers/auxdisplay/lcd2s.c static int lcd2s_i2c_remove(struct i2c_client *i2c) · line 354
Quoted 8 lines
drivers/auxdisplay/lcd2s.c +1
-1@@ -348,8 +348,8 @@ static int lcd2s_i2c_remove(struct i2c_client *i2c) {struct lcd2s_data *lcd2s =i2c_get_clientdata (i2c); -kfree (lcd2s->charlcd);charlcd_unregister (lcd2s->charlcd); +kfree (lcd2s->charlcd);return 0 ; }
Reviewed-by Lars Pöschel <[email protected]>
Thanks,
Lars
Quoted 2 lines · Dan Carpenter
The
kfree()needs to be moved down a line to prevent a use after free.
Thanks Dan for catching this one up while in -next. I'll pick it up.
Cheers,
Miguel