Skip to contentSkip to conversation

f2fs: avoid unneeded data copy in f2fs_ioc_move_range()

PATCH New Jaegeuk Kim 1 participant 1 message Nov 9, 2020

Subsystems (2)
lore
Share & tools
lore

Jaegeuk Kim

author maintainer
#0 lore raw

PATCH 1/1 f2fs: avoid unneeded data copy in f2fs_ioc_move_range()

From: Chao Yu <[email protected]>

Fields in struct f2fs_move_range won't change in f2fs_ioc_move_range(), let's avoid copying this structure's data to userspace.

---
 fs/f2fs/file.c | 6 ------
 1 file changed, 6 deletions(-)
fs/f2fs/file.c +0 -6
index 52417a2e3f4f..22ae8ae0072f 100644
@@ -2898,12 +2898,6 @@ static int f2fs_ioc_move_range(struct file *filp, unsigned long arg)
 					range.pos_out, range.len);
 
 	mnt_drop_write_file(filp);
-	if (err)
-		goto err_out;
-
-	if (copy_to_user((struct f2fs_move_range __user *)arg,
-						&range, sizeof(range)))
-		err = -EFAULT;
 err_out:
 	fdput(dst);
 	return err;
Signature · 1 line
2.29.2.222.g5d2a92d10f8-goog