Skip to contentSkip to conversation

pinctrl: jasperlake: Fix HOSTSW_OWN register offset

PATCH In review Andy Shevchenko 3 participants 3 messages Nov 11, 2020

Subsystems (3)
GPIO Pin control Pin controller - Intel
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 pinctrl: jasperlake: Fix HOSTSW_OWN register offset

Jasper Lake uses different offset for HOSTSW_OWN register. Fix it here.

Fixes e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
Reported-by Evan Green <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>

---
I have got a confirmation that PADCFGLOCK is still 0x80. I updated my patch and put your name as Reported-by. If you want me to have your patch instead, I can review it (it needs some massage of the commit message)

 drivers/pinctrl/intel/pinctrl-jasperlake.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/pinctrl-jasperlake.c +1 -1
index c5e204c8da9c..ec435b7ab392 100644
@@ -16,7 +16,7 @@
 
 #define JSL_PAD_OWN	0x020
 #define JSL_PADCFGLOCK	0x080
-#define JSL_HOSTSW_OWN	0x0b0
+#define JSL_HOSTSW_OWN	0x0c0
 #define JSL_GPI_IS	0x100
 #define JSL_GPI_IE	0x120
Signature · 1 line
2.28.0
#1 lore raw
Quoted 4 lines · Andy Shevchenko

Jasper Lake uses different offset for HOSTSW_OWN register. Fix it here.

Quoted 8 lines
Fixes e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
Reported-by Evan Green <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>

---
I have got a confirmation that PADCFGLOCK is still 0x80. I updated my patch and put your name as Reported-by. If you want me to have your patch instead, I can review it (it needs some massage of the commit message)

Either way is ok. I'm happy to spin and edit my commit message, let me know how to change.
-Evan

#2 lore raw
Quoted 16 lines · Evan Green
Quoted 4 lines · Andy Shevchenko

Jasper Lake uses different offset for HOSTSW_OWN register. Fix it here.

Quoted 8 lines
Fixes e278dcb7048b ("pinctrl: intel: Add Intel Jasper Lake pin controller support")
Reported-by Evan Green <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>

---
I have got a confirmation that PADCFGLOCK is still 0x80. I updated my patch and put your name as Reported-by. If you want me to have your patch instead, I can review it (it needs some massage of the commit message)

Quoted 2 lines

Either way is ok. I'm happy to spin and edit my commit message, let me know how to change.

Okay, let's drop this one, because it repeats yours 100% code wise.

Signature · 2 lines
With Best Regards,
Andy Shevchenko