Skip to contentSkip to conversation

arm64: add config for Broadcom BCM4908 SoCs

PATCH Applied Rafał Miłecki 2 participants 7 messages Nov 12, 2020 – Nov 25, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/3 arm64: add config for Broadcom BCM4908 SoCs

From: Rafał Miłecki <[email protected]>

Add ARCH_BCM4908 config that can be used for compiling DTS files.

---
V4: s/Cortex/Brahma/

---
 arch/arm64/Kconfig.platforms | 8 ++++++++
 arch/arm64/configs/defconfig | 1 +
 2 files changed, 9 insertions(+)
arch/arm64/Kconfig.platforms +8 -0
index 6f2494dd6d60..ec60d32e8d5f 100644
@@ -43,6 +43,14 @@ config ARCH_BCM2835
 	  This enables support for the Broadcom BCM2837 and BCM2711 SoC.
 	  These SoCs are used in the Raspberry Pi 3 and 4 devices.
 
+config ARCH_BCM4908
+	bool "Broadcom BCM4908 family"
+	select GPIOLIB
+	help
+	  This enables support for the Broadcom BCM4906, BCM4908 and
+	  BCM49408 SoCs. These SoCs use Brahma-B53 cores and can be
+	  found in home routers.
+
 config ARCH_BCM_IPROC
 	bool "Broadcom iProc SoC Family"
 	select COMMON_CLK_IPROC
arch/arm64/configs/defconfig +1 -0
index 17a2df6a263e..ead6fa942994 100644
@@ -32,6 +32,7 @@ CONFIG_ARCH_AGILEX=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_ARCH_ALPINE=y
 CONFIG_ARCH_BCM2835=y
+CONFIG_ARCH_BCM4908=y
 CONFIG_ARCH_BCM_IPROC=y
 CONFIG_ARCH_BERLIN=y
 CONFIG_ARCH_BRCMSTB=y
Signature · 1 line
2.27.0
#1 lore raw

PATCH v4 2/3 dt-bindings: arm: bcm: document BCM4908 bindings

From: Rafał Miłecki <[email protected]>

BCM4908 is a new family that includes BCM4906, BCM4908 and BCM49408. It's mostly used in home routers and often replaces Northstar in vendors portfolio.

---
V3: New patch in the series

---
 .../bindings/arm/bcm/brcm,bcm4908.yaml        | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml
Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml new file +38 -0
new file mode 100644
index 000000000000..dfe1c1c6bb8c
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm4908.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM4908 device tree bindings
+
+description:
+  Broadcom BCM4906 / BCM4908 / BCM49408 Wi-Fi/network SoCs with Brahma CPUs.
+
+maintainers:
+  - Rafał Miłecki <[email protected]>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - description: BCM4906 based boards
+        items:
+          - const: brcm,bcm4906
+          - const: brcm,bcm4908
+
+      - description: BCM4908 based boards
+        items:
+          - enum:
+              - asus,gt-ac5300
+          - const: brcm,bcm4908
+
+      - description: BCM49408 based boards
+        items:
+          - const: brcm,bcm49408
+          - const: brcm,bcm4908
+
+additionalProperties: false
+
+...
Signature · 1 line
2.27.0
#4 lore raw

PATCH v4 3/3 arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

They don't descibe hardware fully yet but it's enough to boot a system.

Some missing blocks:
1. PMC (Power Management Controller?)
2. Ethernet
3. Crypto
4. Thermal

Asus DTS is missing defining full NAND partitions layout and buttons.

Further changes will fill those gaps as soon as required bindings will be found / tested / added.

---
V2: Move some NAND properties to device dts
Fix CPU compatible strings
Add axi@81000000
Fix PMU compatible string
V3: Drop leading 0s
Drop bootargs with debugging earlycon
Use usb@ syntax to match [PATCH v2 00/18] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

---
 arch/arm64/boot/dts/broadcom/Makefile         |   1 +
 arch/arm64/boot/dts/broadcom/bcm4908/Makefile |   2 +
 .../bcm4908/bcm4908-asus-gt-ac5300.dts        |  66 +++++++
 .../boot/dts/broadcom/bcm4908/bcm4908.dtsi    | 187 ++++++++++++++++++
 4 files changed, 256 insertions(+)
 create mode 100644 arch/arm64/boot/dts/broadcom/bcm4908/Makefile
 create mode 100644 arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
 create mode 100644 arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
arch/arm64/boot/dts/broadcom/Makefile +1 -0
index cb7de8d99223..998e240aa698 100644
@@ -5,5 +5,6 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-4-b.dtb \
 			      bcm2837-rpi-3-b-plus.dtb \
 			      bcm2837-rpi-cm3-io3.dtb
 
+subdir-y	+= bcm4908
 subdir-y	+= northstar2
 subdir-y	+= stingray
arch/arm64/boot/dts/broadcom/bcm4908/Makefile new file +2 -0
new file mode 100644
index 000000000000..ef26c23603ce
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0
+dtb-$(CONFIG_ARCH_BCM4908) += bcm4908-asus-gt-ac5300.dtb
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts new file +66 -0

66 lines not on this page · raw message

arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi new file +187 -0

187 lines not on this page · raw message

Signature · 1 line
2.27.0
#5 lore raw

Re: [PATCH V4 3/3] arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files

In reply to Rafał Miłecki
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

They don't descibe hardware fully yet but it's enough to boot a system.

Some missing blocks:
1. PMC (Power Management Controller?)
2. Ethernet
3. Crypto
4. Thermal

Quoted 7 lines

Asus DTS is missing defining full NAND partitions layout and buttons.

Further changes will fill those gaps as soon as required bindings will be found / tested / added.

---

Applied to devicetree-arm64/next, thanks!
--
Florian

#3 lore raw

Re: [PATCH V4 2/3] dt-bindings: arm: bcm: document BCM4908 bindings

In reply to Florian Fainelli
Quoted 11 lines · Florian Fainelli
Quoted 8 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

BCM4908 is a new family that includes BCM4906, BCM4908 and BCM49408. It's mostly used in home routers and often replaces Northstar in vendors portfolio.

---

Applied to devicetree-arm64/next, thanks!

Can you send me an incremental fix for this warning:

CHECK
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dt.yaml /home/fainelli/dev/linux/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dt.yaml:
/: '#address-cells', '#size-cells', 'aliases', 'axi@81000000',
'bus@ff800000', 'chosen', 'clocks', 'cpus', 'gpio-keys-polled', 'interrupt-parent', 'memory@0', 'model', 'pmu', 'soc', 'timer' do not
match any of the regexes: 'pinctrl-[0-9]+'
From schema:
/home/fainelli/dev/linux/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml

reproduced with:

ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml

Thanks

Signature · 1 line
Florian