Skip to contentSkip to conversation

syscalls: Fix file comments for syscalls implemented in kernel/sys.c

PATCH In review Tal Zussman 3 participants 3 messages Nov 12, 2020 – Nov 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls: Fix file comments for syscalls implemented in kernel/sys.c

The relevant syscalls were previously moved from kernel/timer.c to kernel/sys.c, but the comments weren't updated to reflect this change.

Fixing these comments messes up the alphabetical ordering of syscalls by filename. This could be fixed by merging the two groups of kernel/sys.c syscalls, but that would require reordering the syscalls and renumbering them to maintain the numerical order in unistd.h.

---
 include/linux/syscalls.h          | 2 +-
 include/uapi/asm-generic/unistd.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/syscalls.h +1 -1
index 37bea07c12f2..629870fbb2c9 100644
@@ -744,7 +744,7 @@ asmlinkage long sys_settimeofday(struct __kernel_old_timeval __user *tv,
 asmlinkage long sys_adjtimex(struct __kernel_timex __user *txc_p);
 asmlinkage long sys_adjtimex_time32(struct old_timex32 __user *txc_p);
 
-/* kernel/timer.c */
+/* kernel/sys.c */
 asmlinkage long sys_getpid(void);
 asmlinkage long sys_getppid(void);
 asmlinkage long sys_getuid(void);
include/uapi/asm-generic/unistd.h +1 -1
index 2056318988f7..fc48c64700eb 100644
@@ -517,7 +517,7 @@ __SC_COMP(__NR_settimeofday, sys_settimeofday, compat_sys_settimeofday)
 __SC_3264(__NR_adjtimex, sys_adjtimex_time32, sys_adjtimex)
 #endif
 
-/* kernel/timer.c */
+/* kernel/sys.c */
 #define __NR_getpid 172
 __SYSCALL(__NR_getpid, sys_getpid)
 #define __NR_getppid 173
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · Tal Zussman

The relevant syscalls were previously moved from kernel/timer.c to kernel/sys.c, but the comments weren't updated to reflect this change.

Fixing these comments messes up the alphabetical ordering of syscalls by filename. This could be fixed by merging the two groups of kernel/sys.c syscalls, but that would require reordering the syscalls and renumbering them to maintain the numerical order in unistd.h.

Lots of overly long lines in your commit log.

As for the patch itself: IMHO we should just remove the comments about the files as that information is completely irrelevant.

#2 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 7 lines · Tal Zussman

The relevant syscalls were previously moved from kernel/timer.c to kernel/sys.c, but the comments weren't updated to reflect this change.

Fixing these comments messes up the alphabetical ordering of syscalls by filename. This could be fixed by merging the two groups of kernel/sys.c syscalls, but that would require reordering the syscalls and renumbering them to maintain the numerical order in unistd.h.

Quoted 4 lines

Lots of overly long lines in your commit log.

As for the patch itself: IMHO we should just remove the comments about the files as that information is completely irrelevant.

I noticed I already applied the patch last week to the asm-generic cleanups branch, but forgot to send out the email about it.

I do agree the file names are rather useless, and I would apply a follow-up patch to completely remove them as well. My real plan was to remove the file itself and replace it with the parsable syscall.tbl format that we use for all non-generic architectures, but I haven't gotten around to updating the patch that Firoz Khan did a long time ago.

arnd