Skip to contentSkip to conversation

examples/multi_process: add missing SPDX header to Makefile

PATCH In review Stephen Hemminger 3 participants 4 messages Nov 16, 2020 – Nov 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/multi_process: add missing SPDX header to Makefile

Make is still used for these examples, so add header to Makefile

---
 examples/multi_process/Makefile                  | 3 +++
 examples/multi_process/client_server_mp/Makefile | 3 +++
 2 files changed, 6 insertions(+)
examples/multi_process/Makefile +3 -0
index f0a999745a7d..937d00faa313 100644
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+
 subdirs := client_server_mp hotplug_mp simple_mp symmetric_mp
 
 .PHONY: all static shared clean $(subdirs)
examples/multi_process/client_server_mp/Makefile +3 -0
index e8debdfd9ac7..fbe6d67a7771 100644
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+
 subdirs := mp_client mp_server
 
 .PHONY: all static shared clean $(subdirs)
Signature · 1 line
2.27.0
#1 lore raw
Quoted 13 lines · Stephen Hemminger

Make is still used for these examples, so add header to Makefile

---
 examples/multi_process/Makefile                  | 3 +++
 examples/multi_process/client_server_mp/Makefile | 3 +++
 2 files changed, 6 insertions(+)
examples/multi_process/Makefile +0 -0
index f0a999745a7d..937d00faa313 100644

examples/multi_process/Makefile line 3

Quoted 3 lines
examples/multi_process/Makefile +3 -0
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+

These two Makefiles are actually completely new, replacing the older ones, so the year should probably be 2020 just (or else 2010-2020 if you want to keep connection to the older ones). This is also why the old notice disappeared, as the old file was deleted before the new was created.

/Bruce

#2 lore raw

PATCH v2 1/1 examples/multi_process: fix missing SPDX headers

In reply to Stephen Hemminger

The makefiles for some of the multi_process example files were missing SPDX license headers, so add them. These Makefiles completely replaced the older makefiles and were written from scratch, not based on previous versions, so add a new copyright year on them.

Fixes 13abe17c3cd4 ("examples/multi_process: convert to pkg-config-based build")

---
v2: adjust copyright year to reflect year of authorship
add more detail and fixes line to commit log.

---
 examples/multi_process/Makefile                  | 3 +++
 examples/multi_process/client_server_mp/Makefile | 3 +++
 2 files changed, 6 insertions(+)
examples/multi_process/Makefile +3 -0
index f0a999745..e55204495 100644
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2020 Intel Corporation
+
 subdirs := client_server_mp hotplug_mp simple_mp symmetric_mp
 
 .PHONY: all static shared clean $(subdirs)
examples/multi_process/client_server_mp/Makefile +3 -0
index e8debdfd9..f4cab6313 100644
@@ -1,3 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2020 Intel Corporation
+
 subdirs := mp_client mp_server
 
 .PHONY: all static shared clean $(subdirs)

--
2.25.1

#3 lore raw

Re: [dpdk-dev] [PATCH v2] examples/multi_process: fix missing SPDX headers

Quoted 10 lines · Bruce Richardson

The makefiles for some of the multi_process example files were missing SPDX license headers, so add them. These Makefiles completely replaced the older makefiles and were written from scratch, not based on previous versions, so add a new copyright year on them.

Fixes 13abe17c3cd4 ("examples/multi_process: convert to pkg-config-based build")

Applied, thanks.

Signature · 1 line
David Marchand