drm/exynos: depend on COMMON_CLK to fix compile tests
Subsystems (5)
Krzysztof Kozlowski
maintainerPATCH 1/2 drm/exynos: depend on COMMON_CLK to fix compile tests
The Exynos DRM uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and SOC_RT305X):
/usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/exynos/exynos_mixer.o: in function `mixer_bind':
exynos_mixer.c:(.text+0x958): undefined reference to `clk_set_parent'
--- drivers/gpu/drm/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/exynos/Kconfig +2 -1
@@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_EXYNOS tristate "DRM Support for Samsung SoC Exynos Series" - depends on OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST) + depends on OF && DRM && COMMON_CLK + depends on ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST depends on MMU select DRM_KMS_HELPER select VIDEOMODE_HELPERS
Signature · 1 line
2.25.1
Krzysztof Kozlowski
maintainerPATCH 2/2 drm/ingenic: depend on COMMON_CLK to fix compile tests
The Ingenic DRM uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and SOC_RT305X):
/usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function `ingenic_drm_bind.isra.0':
ingenic-drm-drv.c:(.text+0x1600): undefined reference to `clk_get_parent'
/usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0): undefined reference to `clk_get_parent'--- drivers/gpu/drm/ingenic/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/ingenic/Kconfig +1 -0
@@ -4,6 +4,7 @@ config DRM_INGENIC depends on DRM depends on CMA depends on OF + depends on COMMON_CLK select DRM_BRIDGE select DRM_PANEL_BRIDGE select DRM_KMS_HELPER
Signature · 6 lines
2.25.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests
Hi Krzysztof,
Quoted 9 lines · Krzysztof Kozlowski
The Ingenic DRM uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):/usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function `ingenic_drm_bind.isra.0': ingenic-drm-drv.c:(.text+0x1600): undefined reference to `clk_get_parent' /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0):
Quoted 4 lines
undefined reference to `clk_get_parent'
Reported-by kernel test robot <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Cheers,
-Paul
Quoted 19 lines
--- drivers/gpu/drm/ingenic/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/ingenic/Kconfig +1
-1@@ -4,6 +4,7 @@ config DRM_INGENIC depends on DRM depends on CMA depends on OF + depends on COMMON_CLK select DRM_BRIDGE select DRM_PANEL_BRIDGE select DRM_KMS_HELPER --2.25.1
Inki Dae
maintainerHI Krzysztof,
20. 11. 17. 오전 2:53에 Krzysztof Kozlowski 이(가) 쓴 글:
Quoted 9 lines
The Exynos DRM uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):
/usr/bin/mips-linux-gnu-ld:drivers/gpu/drm/exynos/exynos_mixer.o: in function `mixer_bind':
exynos_mixer.c:(.text+0x958): undefined reference to `clk_set_parent'Reported-by kernel test robot <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Picked it up.
Thanks,
Inki Dae
Quoted 10 lines
--- drivers/gpu/drm/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/exynos/Kconfig +0
-0
drivers/gpu/drm/exynos/Kconfig line 8
Quoted 9 lines
drivers/gpu/drm/exynos/Kconfig +2
-1@@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_EXYNOS tristate "DRM Support for Samsung SoC Exynos Series" - depends on OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST) + depends on OF && DRM && COMMON_CLK + depends on ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST depends on MMU select DRM_KMS_HELPER select VIDEOMODE_HELPERS
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Krzysztof Kozlowski
maintainerRe: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests
In reply to Paul CercueilQuoted 16 lines · Paul Cercueil
Hi Krzysztof,
Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski <[email protected]> a écrit :
Quoted 12 lines
The Ingenic DRM uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):/usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function `ingenic_drm_bind.isra.0': ingenic-drm-drv.c:(.text+0x1600): undefined reference to `clk_get_parent' /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0):undefined reference to `clk_get_parent'
Quoted 4 lines
Quoted 2 lines
Reported-by kernel test robot <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>Acked-by Paul Cercueil <[email protected]>
Thanks for the ack.
David and Daniel,
I think there is no dedicated maintainer for Ingenic DRM, so can you pick it up directly?
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Paul Cercueil
maintainerRe: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests
Hi Krzysztof,
Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Paul Cercueil
Hi Krzysztof,
Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski
<[email protected]> a écrit
:Quoted 1 line
The Ingenic DRM uses Common Clock Framework thus it cannot be
built on
Quoted 13 lines
platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):/usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function `ingenic_drm_bind.isra.0': ingenic-drm-drv.c:(.text+0x1600): undefined reference to `clk_get_parent' /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0):undefined reference to `clk_get_parent'
Reported-by kernel test robot <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 7 lines
Quoted 1 line
Acked-by Paul Cercueil <[email protected]>Thanks for the ack.
David and Daniel,
I think there is no dedicated maintainer for Ingenic DRM, so can you pick it up directly?
I am. Pushed to drm-misc-next, thanks!
-Paul