Skip to contentSkip to conversation

drm/imx: depend on COMMON_CLK to fix compile tests

PATCH Applied Krzysztof Kozlowski 2 participants 2 messages Nov 17, 2020 – Nov 18, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/imx: depend on COMMON_CLK to fix compile tests

The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and SOC_RT305X):

/usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'

---

Changes since v1:
1. Put depends in DRM_IMX_LDB option only.

---
 drivers/gpu/drm/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/imx/Kconfig +1 -0
index 6231048aa5aa..73fe2bc5633c 100644
@@ -28,6 +28,7 @@ config DRM_IMX_TVE
 config DRM_IMX_LDB
 	tristate "Support for LVDS displays"
 	depends on DRM_IMX && MFD_SYSCON
+	depends on COMMON_CLK
 	select DRM_PANEL
 	help
 	  Choose this to enable the internal LVDS Display Bridge (LDB)
Signature · 6 lines
2.25.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Hi Krzysztof,

Quoted 22 lines · Krzysztof Kozlowski

The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be built on platforms without it (e.g. compile test on MIPS with RALINK and SOC_RT305X):

/usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'

---

Changes since v1:
1. Put depends in DRM_IMX_LDB option only.

---
 drivers/gpu/drm/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/imx/Kconfig +0 -0
index 6231048aa5aa..73fe2bc5633c 100644

drivers/gpu/drm/imx/Kconfig config DRM_IMX_TVE · line 34

Quoted 7 lines
drivers/gpu/drm/imx/Kconfig +1 -0
@@ -28,6 +28,7 @@ config DRM_IMX_TVE
 config DRM_IMX_LDB
 	tristate "Support for LVDS displays"
 	depends on DRM_IMX && MFD_SYSCON
+	depends on COMMON_CLK
 	select DRM_PANEL
 	help
 	  Choose this to enable the internal LVDS Display Bridge (LDB)

Thank you, applied to imx-drm/next.

regards
Philipp
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel