Skip to contentSkip to conversation

common/mlx5: fix name for ConnectX VF device ID

PATCH In review Raslan Darawsheh 2 participants 4 messages Nov 19, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/mlx5: fix name for ConnectX VF device ID

Starting ConnectX-6 Dx, the VF device ID is generic and not per chip.

https://pci-ids.ucw.cz/v2.2/pci.ids
101e ConnectX Family mlx5Gen Virtual Function

This means that all will have the same VF device ID.

Fixes 5fc66630bed5 ("net/mlx5: add ConnectX6-DX device ID")
---
 drivers/common/mlx5/mlx5_common.h | 2 +-
 drivers/net/mlx5/linux/mlx5_os.c  | 2 +-
 drivers/net/mlx5/mlx5.c           | 2 +-
 drivers/vdpa/mlx5/mlx5_vdpa.c     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/common/mlx5/mlx5_common.h +1 -1
index 10a0851794..a484b74b9c 100644
@@ -131,7 +131,7 @@ enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6 = 0x101b,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6VF = 0x101c,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DX = 0x101d,
-	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
+	PCI_DEVICE_ID_MELLANOX_CONNECTXVF = 0x101e,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021,
drivers/net/mlx5/linux/mlx5_os.c +1 -1
index 4b7fff4eff..9855bbe180 100644
@@ -2115,7 +2115,7 @@ mlx5_os_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 	case PCI_DEVICE_ID_MELLANOX_CONNECTX5EXVF:
 	case PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF:
 	case PCI_DEVICE_ID_MELLANOX_CONNECTX6VF:
-	case PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF:
+	case PCI_DEVICE_ID_MELLANOX_CONNECTXVF:
 		dev_config_vf = 1;
 		break;
 	default:
drivers/net/mlx5/mlx5.c +1 -1
index ede5fd44ab..db7e8d708c 100644
@@ -2035,7 +2035,7 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {
 	},
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
-				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF)
+				PCI_DEVICE_ID_MELLANOX_CONNECTXVF)
 	},
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
drivers/vdpa/mlx5/mlx5_vdpa.c +1 -1
index 1502abdc89..b64f364eb7 100644
@@ -824,7 +824,7 @@ static const struct rte_pci_id mlx5_vdpa_pci_id_map[] = {
 	},
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
-				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF)
+				PCI_DEVICE_ID_MELLANOX_CONNECTXVF)
 	},
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Raslan Darawsheh <[email protected]>
Sent: Thursday, November 19, 2020 10:06
To: [email protected]
Cc: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]
Subject: [PATCH] common/mlx5: fix name for ConnectX VF device ID

Quoted 6 lines

Starting ConnectX-6 Dx, the VF device ID is generic and not per chip.

https://pci-ids.ucw.cz/v2.2/pci.ids
101e ConnectX Family mlx5Gen Virtual Function

This means that all will have the same VF device ID.

Extra space is here: "all will".
Beside this:

Quoted 71 lines
Fixes 5fc66630bed5 ("net/mlx5: add ConnectX6-DX device ID")
---
 drivers/common/mlx5/mlx5_common.h | 2 +-
drivers/net/mlx5/linux/mlx5_os.c  | 2 +-
 drivers/net/mlx5/mlx5.c           | 2 +-
 drivers/vdpa/mlx5/mlx5_vdpa.c     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/common/mlx5/mlx5_common.h +1 -1
index 10a0851794..a484b74b9c 100644
@@ -131,7 +131,7 @@ enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6 = 0x101b,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6VF = 0x101c,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DX = 0x101d,
-	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
+	PCI_DEVICE_ID_MELLANOX_CONNECTXVF = 0x101e,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021, diff --git

a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 4b7fff4eff..9855bbe180 100644

drivers/net/mlx5/linux/mlx5_os.c +1 -1
@@ -2115,7 +2115,7 @@ mlx5_os_pci_probe(struct rte_pci_driver *pci_drv
 __rte_unused,
 	case PCI_DEVICE_ID_MELLANOX_CONNECTX5EXVF:
 	case PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF:
 	case PCI_DEVICE_ID_MELLANOX_CONNECTX6VF:
-	case PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF:
+	case PCI_DEVICE_ID_MELLANOX_CONNECTXVF:
 		dev_config_vf = 1;
 		break;
drivers/net/mlx5/linux/mlx5_os.c +0 -0
 	default:
drivers/net/mlx5/mlx5.c index renamed from drivers/net/mlx5/mlx5.c +0 -0

ede5fd44ab..db7e8d708c 100644

drivers/net/mlx5/mlx5.c +1 -1
@@ -2035,7 +2035,7 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {
 	},
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
-
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF)
+				PCI_DEVICE_ID_MELLANOX_CONNECTXVF)
 	},
 	{
drivers/net/mlx5/mlx5.c +0 -0
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
drivers/vdpa/mlx5/mlx5_vdpa.c +1 -1
index 1502abdc89..b64f364eb7 100644
@@ -824,7 +824,7 @@ static const struct rte_pci_id mlx5_vdpa_pci_id_map[]
 = {
 	},
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
-
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF)
+				PCI_DEVICE_ID_MELLANOX_CONNECTXVF)
 	},
drivers/vdpa/mlx5/mlx5_vdpa.c +0 -1
 	{
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
--

2.17.1

#2 lore raw

Hi Slava, thanks for your comments,

Quoted 15 lines

-----Original Message-----
From: Slava Ovsiienko <[email protected]>
Sent: Thursday, November 19, 2020 10:13 AM
To: Raslan Darawsheh <[email protected]>; [email protected]
Cc: Matan Azrad <[email protected]>; [email protected]
Subject: RE: [PATCH] common/mlx5: fix name for ConnectX VF device ID

Quoted 8 lines

-----Original Message-----
From: Raslan Darawsheh <[email protected]>
Sent: Thursday, November 19, 2020 10:06
To: [email protected]
Cc: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]
Subject: [PATCH] common/mlx5: fix name for ConnectX VF device ID

Quoted 7 lines
Quoted 6 lines

Starting ConnectX-6 Dx, the VF device ID is generic and not per chip.

https://pci-ids.ucw.cz/v2.2/pci.ids
101e ConnectX Family mlx5Gen Virtual Function

This means that all will have the same VF device ID.

Extra space is here: "all will".

Sure, will fix during integration.

Quoted 10 lines

Beside this:

Quoted 6 lines
Fixes 5fc66630bed5 ("net/mlx5: add ConnectX6-DX device ID")

---

Kindest regards,
Raslan Darawsheh

#3 lore raw
In reply to Raslan Darawsheh

Hi,

Quoted 21 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Raslan Darawsheh
Sent: Thursday, November 19, 2020 10:06 AM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] common/mlx5: fix name for ConnectX VF device ID

Starting ConnectX-6 Dx, the VF device ID is generic and not per chip.

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpci-
ids.ucw.cz%2Fv2.2%2Fpci.ids&amp;data=04%7C01%7Crasland%40nvidia.com %7C13be0db809fd48cf689a08d88c6214a3%7C43083d15727340c1b7db39efd9c cc17a%7C0%7C0%7C637413700176245747%7CUnknown%7CTWFpbGZsb3d8e yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D %7C1000&amp;sdata=0AtUwe1GPUVmOvf32LHYzyayHx%2FF7Yb7QhZKg8VL LB4%3D&amp;reserved=0
101e ConnectX Family mlx5Gen Virtual Function

Quoted 1 line

This means that all will have the same VF device ID.

Removed extra empty space from commit log,

Quoted 4 lines
Fixes 5fc66630bed5 ("net/mlx5: add ConnectX6-DX device ID")
Quoted 8 lines
---
 drivers/common/mlx5/mlx5_common.h | 2 +-
 drivers/net/mlx5/linux/mlx5_os.c  | 2 +-
 drivers/net/mlx5/mlx5.c           | 2 +-
 drivers/vdpa/mlx5/mlx5_vdpa.c     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh