mm,hugetlb: Remove unneded initialization
Subsystems (2)
Oscar Salvador
maintainerPATCH 1/1 mm,hugetlb: Remove unneded initialization
hugetlb_add_hstate initializes nr_huge_pages and free_huge_pages to 0, but since hstates[] is a global variable, all its fields are defined to 0 already.
Signed-off-by Oscar Salvador <[email protected]>
--- mm/hugetlb.c | 2 -- 1 file changed, 2 deletions(-)
mm/hugetlb.c +0 -2
@@ -3197,8 +3197,6 @@ void __init hugetlb_add_hstate(unsigned int order) h = &hstates[hugetlb_max_hstate++]; h->order = order; h->mask = ~((1ULL << (order +PAGE_SHIFT )) -1 ); - h->nr_huge_pages =0 ; - h->free_huge_pages =0 ;for (i =0 ; i <MAX_NUMNODES ; ++i)INIT_LIST_HEAD (&h->hugepage_freelists[i]);INIT_LIST_HEAD (&h->hugepage_activelist);
Signature · 1 line
2.26.2
Quoted 8 lines · Oscar Salvador
hugetlb_add_hstateinitializesnr_huge_pagesandfree_huge_pagesto 0, but since hstates[] is a global variable, all its fields are defined to 0 already.Signed-off-by Oscar Salvador <[email protected]>--- mm/hugetlb.c | 2 -- 1 file changed, 2 deletions(-)
Thanks,
Reviewed-by Mike Kravetz <[email protected]>
Signature · 1 line
Mike Kravetz
Quoted 15 lines · Oscar Salvador
hugetlb_add_hstateinitializesnr_huge_pagesandfree_huge_pagesto 0, but since hstates[] is a global variable, all its fields are defined to 0 already.Signed-off-by Oscar Salvador <[email protected]>--- mm/hugetlb.c | 2 -- 1 file changed, 2 deletions(-)mm/hugetlb.c +0
-0
mm/hugetlb.c void __init hugetlb_add_hstate(unsigned int order) · line 3202
Quoted 8 lines
mm/hugetlb.c +0
-2@@ -3197,8 +3197,6 @@ void __init hugetlb_add_hstate(unsigned int order) h = &hstates[hugetlb_max_hstate++]; h->order = order; h->mask = ~((1ULL << (order +PAGE_SHIFT )) -1 ); - h->nr_huge_pages =0 ; - h->free_huge_pages =0 ;for (i =0 ; i <MAX_NUMNODES ; ++i)INIT_LIST_HEAD (&h->hugepage_freelists[i]);INIT_LIST_HEAD (&h->hugepage_activelist);
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Thanks, David / dhildenb