Skip to contentSkip to conversation

mm,hugetlb: Remove unneded initialization

PATCH Applied Oscar Salvador 3 participants 3 messages Nov 19, 2020 – Nov 20, 2020

Subsystems (2)
lore
Share & tools
lore

Oscar Salvador

author maintainer
#0 lore raw

PATCH 1/1 mm,hugetlb: Remove unneded initialization

hugetlb_add_hstate initializes nr_huge_pages and free_huge_pages to 0, but since hstates[] is a global variable, all its fields are defined to 0 already.

---
 mm/hugetlb.c | 2 --
 1 file changed, 2 deletions(-)
mm/hugetlb.c +0 -2
index 37f15c3c24dc..1c69e9044887 100644
@@ -3197,8 +3197,6 @@ void __init hugetlb_add_hstate(unsigned int order)
 	h = &hstates[hugetlb_max_hstate++];
 	h->order = order;
 	h->mask = ~((1ULL << (order + PAGE_SHIFT)) - 1);
-	h->nr_huge_pages = 0;
-	h->free_huge_pages = 0;
 	for (i = 0; i < MAX_NUMNODES; ++i)
 		INIT_LIST_HEAD(&h->hugepage_freelists[i]);
 	INIT_LIST_HEAD(&h->hugepage_activelist);
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Oscar Salvador
Quoted 15 lines · Oscar Salvador

hugetlb_add_hstate initializes nr_huge_pages and free_huge_pages to 0, but since hstates[] is a global variable, all its fields are defined to 0 already.

---
  mm/hugetlb.c | 2 --
  1 file changed, 2 deletions(-)
mm/hugetlb.c +0 -0
index 37f15c3c24dc..1c69e9044887 100644

mm/hugetlb.c void __init hugetlb_add_hstate(unsigned int order) · line 3202

Quoted 8 lines
mm/hugetlb.c +0 -2
@@ -3197,8 +3197,6 @@ void __init hugetlb_add_hstate(unsigned int order)
  	h = &hstates[hugetlb_max_hstate++];
  	h->order = order;
  	h->mask = ~((1ULL << (order + PAGE_SHIFT)) - 1);
-	h->nr_huge_pages = 0;
-	h->free_huge_pages = 0;
  	for (i = 0; i < MAX_NUMNODES; ++i)
  		INIT_LIST_HEAD(&h->hugepage_freelists[i]);
  	INIT_LIST_HEAD(&h->hugepage_activelist);
Signature · 3 lines
Thanks,

David / dhildenb