PM / Domains: replace -ENOTSUPP with -EOPNOTSUPP
Subsystems (3)
PATCH v2 1/1 PM / Domains: replace -ENOTSUPP with -EOPNOTSUPP
While submitting a patch to add next_wakeup, checkpatch reported this -
WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
+ return -ENOTSUPP;
Address the above warning in other functions in pm_domain.h.
Reviewed-by Ulf Hansson <[email protected]>
Signed-off-by Lina Iyer <[email protected]>
--- include/linux/pm_domain.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
include/linux/pm_domain.h +7 -7
@@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd, }static inline int pm_genpd_remove (struct generic_pm_domain *genpd) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_set_performance_state (struct device *dev,unsigned int state) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_add_notifier (struct device *dev,struct notifier_block *nb) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_remove_notifier (struct device *dev) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_set_next_wakeup (struct device *dev,ktime_t next)
@@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev,static inline int of_genpd_add_provider_simple (struct device_node *np,struct generic_pm_domain *genpd) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int of_genpd_add_provider_onecell (struct device_node *np,struct genpd_onecell_data *data) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline void of_genpd_del_provider (struct device_node *np) {}
@@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev,static inline struct generic_pm_domain *of_genpd_remove_last (struct device_node *np) { -return ERR_PTR (-ENOTSUPP ); +return ERR_PTR (-EOPNOTSUPP ); }#endif /* CONFIG_PM_GENERIC_DOMAINS_OF */
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 64 lines · Lina Iyer
While submitting a patch to add
next_wakeup, checkpatch reported this -WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
+ return-ENOTSUPP;Address the above warning in other functions in
pm_domain.h.Reviewed-by Ulf Hansson <[email protected]>Signed-off-by Lina Iyer <[email protected]>--- include/linux/pm_domain.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)include/linux/pm_domain.h +6
-6@@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd, }static inline int pm_genpd_remove (struct generic_pm_domain *genpd) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_set_performance_state (struct device *dev,unsigned int state) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_add_notifier (struct device *dev,struct notifier_block *nb) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_remove_notifier (struct device *dev) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int dev_pm_genpd_set_next_wakeup (struct device *dev,ktime_t next)@@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev,static inline int of_genpd_add_provider_simple (struct device_node *np,struct generic_pm_domain *genpd) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline int of_genpd_add_provider_onecell (struct device_node *np,struct genpd_onecell_data *data) { -return -ENOTSUPP ; +return -EOPNOTSUPP ; }static inline void of_genpd_del_provider (struct device_node *np) {}
include/linux/pm_domain.h static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev,
Quoted 9 lines
include/linux/pm_domain.h +1
-2@@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev,static inline struct generic_pm_domain *of_genpd_remove_last (struct device_node *np) { -return ERR_PTR (-ENOTSUPP ); +return ERR_PTR (-EOPNOTSUPP ); }#endif /* CONFIG_PM_GENERIC_DOMAINS_OF */ --
Applied as 5.11 material, thanks!