lpfc: Fix set but not used warnings from Rework remote port lock handling
Subsystems (2)
PATCH 1/1 lpfc: Fix set but not used warnings from Rework remote port lock handling
Remove local variables that are set but not used.
Fixes c6adba150191 ("scsi: lpfc: Rework remote port lock handling")
Reported-by kernel test robot <[email protected]>
Signed-off-by James Smart <[email protected]>
--- drivers/scsi/lpfc/lpfc_els.c | 6 ------ drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ---- drivers/scsi/lpfc/lpfc_init.c | 2 -- 3 files changed, 12 deletions(-)
drivers/scsi/lpfc/lpfc_els.c +0 -6
@@ -2075,7 +2075,6 @@ int lpfc_issue_els_plogi(struct lpfc_vport *vport, uint32_t did, uint8_t retry) { struct lpfc_hba *phba = vport->phba; -struct Scsi_Host *shost;struct serv_parm *sp;struct lpfc_nodelist *ndlp;struct lpfc_iocbq *elsiocb;
@@ -2113,7 +2112,6 @@ lpfc_issue_els_plogi(struct lpfc_vport *vport, uint32_t did, uint8_t retry)if (!elsiocb)return 1 ; - shost =lpfc_shost_from_vport (vport);spin_lock_irq (&ndlp->lock); ndlp->nlp_flag &= ~NLP_FCP_PRLI_RJT ;spin_unlock_irq (&ndlp->lock);
@@ -8572,7 +8570,6 @@ static void lpfc_els_unsol_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, struct lpfc_vport *vport, struct lpfc_iocbq *elsiocb) { - struct Scsi_Host *shost; struct lpfc_nodelist *ndlp;struct ls_rjt stat;uint32_t *payload, payload_len;
@@ -8633,7 +8630,6 @@ lpfc_els_unsol_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,* Do not process any unsolicited ELS commands * if the ndlp is in DEV_LOSS */ - shost =lpfc_shost_from_vport (vport);spin_lock_irq (&ndlp->lock);if (ndlp->nlp_flag &NLP_IN_DEV_LOSS ) {spin_unlock_irq (&ndlp->lock);
@@ -9403,7 +9399,6 @@ void lpfc_retry_pport_discovery(struct lpfc_hba *phba) {struct lpfc_nodelist *ndlp; -struct Scsi_Host *shost;/* Cancel the all vports retry delay retry timers */ lpfc_cancel_all_vport_retry_delay_timer (phba);
@@ -9413,7 +9408,6 @@ lpfc_retry_pport_discovery(struct lpfc_hba *phba)if (!ndlp)return ; - shost =lpfc_shost_from_vport (phba->pport);mod_timer (&ndlp->nlp_delayfunc, jiffies +msecs_to_jiffies (1000 ));spin_lock_irq (&ndlp->lock); ndlp->nlp_flag |=NLP_DELAY_TMO ;
drivers/scsi/lpfc/lpfc_hbadisc.c +0 -4
@@ -84,7 +84,6 @@ lpfc_rport_invalid(struct fc_rport *rport) {struct lpfc_rport_data *rdata;struct lpfc_nodelist *ndlp; -struct lpfc_vport *vport;if (!rport) {pr_err ("**** %s: NULL rport, exit.\n" , __func__);
@@ -105,7 +104,6 @@ lpfc_rport_invalid(struct fc_rport *rport)return -EINVAL ; } - vport = ndlp->vport;if (!ndlp->vport) { pr_err("**** %s: Null vport on ndlp %p, DID x%x rport %p " "SID x%x\n", __func__, ndlp, ndlp->nlp_DID, rport,
@@ -6195,7 +6193,6 @@ lpfc_nlp_release(struct kref *kref)struct lpfc_nodelist *lpfc_nlp_get (struct lpfc_nodelist *ndlp) { -struct lpfc_hba *phba;unsigned long flags;if (ndlp) {
@@ -6208,7 +6205,6 @@ lpfc_nlp_get(struct lpfc_nodelist *ndlp)* ndlp reference count that is in the process of being * released. */ - phba = ndlp->phba;spin_lock_irqsave (&ndlp->lock, flags);if (!kref_get_unless_zero (&ndlp->kref)) {spin_unlock_irqrestore (&ndlp->lock, flags);
drivers/scsi/lpfc/lpfc_init.c +0 -2
@@ -5644,7 +5644,6 @@ lpfc_sli4_async_fip_evt(struct lpfc_hba *phba,int rc;struct lpfc_vport *vport;struct lpfc_nodelist *ndlp; -struct Scsi_Host *shost;int active_vlink_present;struct lpfc_vport **vports;int i;
@@ -5825,7 +5824,6 @@ lpfc_sli4_async_fip_evt(struct lpfc_hba *phba,*/ mod_timer (&ndlp->nlp_delayfunc, jiffies +msecs_to_jiffies (1000 )); - shost =lpfc_shost_from_vport (vport);spin_lock_irq (&ndlp->lock); ndlp->nlp_flag |=NLP_DELAY_TMO ;spin_unlock_irq (&ndlp->lock);
Signature · 1 line
2.26.2
Martin K. Petersen
AppliedJames,
Quoted 1 line
Remove local variables that are set but not used.
Applied to 5.11/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 1 line · James Smart
Remove local variables that are set but not used.
Applied to 5.11/scsi-queue, thanks!
[1/1] scsi: lpfc: Fix set but not used warnings from Rework remote port lock handling
https://git.kernel.org/mkp/scsi/c/4a119d8a4c60
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering