drm/amd/amdgpu: skip unload message in reset
Subsystems (2)
PATCH 1/1 drm/amd/amdgpu: skip unload message in reset
This has been confirmed that unload message is not needed from SIENNA_CICHLID in reset. Otherwise it will cause the fw wrong state after reset and no response for any messages.
Signed-off-by Kenneth Feng <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
@@ -1925,7 +1925,8 @@ static int psp_load_smu_fw(struct psp_context *psp)return 0 ; -if (amdgpu_in_reset (adev) && ras && ras->supported) { +if (amdgpu_in_reset (adev) && ras && ras->supported && + adev->asic_type ==CHIP_ARCTURUS ) { ret =amdgpu_dpm_set_mp1_state (adev,PP_MP1_STATE_UNLOAD );if (ret) {DRM_WARN ("Failed to set MP1 state prepare for reload\n" );
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
Reviewed-by Hawking Zhang <[email protected]>
Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Kenneth Feng
Sent: Friday, November 20, 2020 14:41
To: [email protected]
Cc: Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amd/amdgpu: skip unload message in reset
This has been confirmed that unload message is not needed from SIENNA_CICHLID in reset. Otherwise it will cause the fw wrong state after reset and no response for any messages.
Signed-off-by Kenneth Feng <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
@@ -1925,7 +1925,8 @@ static int psp_load_smu_fw(struct psp_context *psp)return 0 ; -if (amdgpu_in_reset (adev) && ras && ras->supported) { +if (amdgpu_in_reset (adev) && ras && ras->supported && + adev->asic_type ==CHIP_ARCTURUS ) { ret =amdgpu_dpm_set_mp1_state (adev,PP_MP1_STATE_UNLOAD );if (ret) {DRM_WARN ("Failed to set MP1 state prepare for reload\n" );
Signature · 10 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Chawking.zhang%40amd.com%7C45bd004548f04e12ba1e08d88d1f5e96%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637414513171894856%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=rO6cuJEwNk8mXAXFtVtMchYljIEwnUd3B1z16023Fow%3D&reserved=0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx