Skip to contentSkip to conversation

FPGA Manager Fix for 5.10

PATCH In review Moritz Fischer 2 participants 3 messages Nov 22, 2020 – Dec 1, 2020 FPGA manager framework

lore
Share & tools
lore

Moritz Fischer

author maintainer
#0 lore raw

cover FPGA Manager Fix for 5.10

Hi Greg,

This time as patchset, as requested last time.

Please take this fix addressing a missing dependency FPGA_DFL.

Thanks,
Moritz

David Gow (1):
fpga: Specify HAS_IOMEM dependency for FPGA_DFL

 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.29.2
author maintainer
#1 lore raw

PATCH 1/1 fpga: Specify HAS_IOMEM dependency for FPGA_DFL

From: David Gow <[email protected]>

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

[[email protected]: Removed "drivers: " in commit message]
Fixes 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
Signature · 1 line
2.29.2
#2 lore raw
In reply to Moritz Fischer
Quoted 5 lines · Moritz Fischer

Hi Greg,

This time as patchset, as requested last time.

Please take this fix addressing a missing dependency FPGA_DFL.

Sorry for the long delay, trying to catch up now. Now queued up.

greg k-h