Skip to contentSkip to conversation

fanotify.7: fix outdated description

PATCH In review Amir Goldstein 3 participants 7 messages Nov 24, 2020 – Jan 4, 2021 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fanotify.7: fix outdated description

---
 man7/fanotify.7 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
man7/fanotify.7 +4 -3
index c4f5397e4..5804a1f30 100644
@@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
 The fanotify API provides notification and interception of
 filesystem events.
 Use cases include virus scanning and hierarchical storage management.
-Currently, only a limited set of events is supported.
-In particular, there is no support for create, delete, and move events.
+In the original fanotify API, only a limited set of events was supported.
+In particular, there was no support for create, delete, and move events.
+The support for those events was added in Linux 5.1.
 (See
 .BR inotify (7)
-for details of an API that does notify those events.)
+for details of an API that did notify those events pre Linux 5.1.)
 .PP
 Additional capabilities compared to the
 .BR inotify (7)
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Amir Goldstein

Looks good to me. You can add:

Honza

Quoted 27 lines
---
 man7/fanotify.7 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
man7/fanotify.7 +4 -3
index c4f5397e4..5804a1f30 100644
@@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
 The fanotify API provides notification and interception of
 filesystem events.
 Use cases include virus scanning and hierarchical storage management.
-Currently, only a limited set of events is supported.
-In particular, there is no support for create, delete, and move events.
+In the original fanotify API, only a limited set of events was supported.
+In particular, there was no support for create, delete, and move events.
+The support for those events was added in Linux 5.1.
 (See
 .BR inotify (7)
-for details of an API that does notify those events.)
+for details of an API that did notify those events pre Linux 5.1.)
 .PP
 Additional capabilities compared to the
 .BR inotify (7)
Signature · 1 line
2.17.1
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#2 lore raw
In reply to Amir Goldstein
Quoted 15 lines · Amir Goldstein
---
 man7/fanotify.7 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
man7/fanotify.7 +0 -2
index c4f5397e4..5804a1f30 100644
@@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
 The fanotify API provides notification and interception of
 filesystem events.
 Use cases include virus scanning and hierarchical storage management.
-Currently, only a limited set of events is supported.
-In particular, there is no support for create, delete, and move events.

man7/fanotify.7 fanotify \- monitoring filesystem events · line 40

Quoted 10 lines
man7/fanotify.7 +4 -1
+In the original fanotify API, only a limited set of events was supported.
+In particular, there was no support for create, delete, and move events.
+The support for those events was added in Linux 5.1.
 (See
 .BR inotify (7)
-for details of an API that does notify those events.)
+for details of an API that did notify those events pre Linux 5.1.)
 .PP
 Additional capabilities compared to the
 .BR inotify (7)

Thanks, Amir. Applied, with Jan's Reviewed-by.

By the way, I see that there's still no documentation for FAN_AUDIT/FAN_ENABLE_AUDIT, added in:

commit de8cd83e91bc3ee212b3e6ec6e4283af9e4ab269
Author: Steve Grubb <[email protected]>
Date: Mon Oct 2 20:21:39 2017 -0400

audit: Record fanotify access control decisions

Can anyone help with that?

Cheers,

Michael

Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
#3 lore raw
Quoted 32 lines · Michael Kerrisk (man-pages)
Quoted 15 lines · Amir Goldstein
---
 man7/fanotify.7 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
man7/fanotify.7 +0 -2
index c4f5397e4..5804a1f30 100644
@@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
 The fanotify API provides notification and interception of
 filesystem events.
 Use cases include virus scanning and hierarchical storage management.
-Currently, only a limited set of events is supported.
-In particular, there is no support for create, delete, and move events.

man7/fanotify.7 fanotify \- monitoring filesystem events · line 40

Quoted 10 lines
man7/fanotify.7 +4 -1
+In the original fanotify API, only a limited set of events was supported.
+In particular, there was no support for create, delete, and move events.
+The support for those events was added in Linux 5.1.
 (See
 .BR inotify (7)
-for details of an API that does notify those events.)
+for details of an API that did notify those events pre Linux 5.1.)
 .PP
 Additional capabilities compared to the
 .BR inotify (7)

Thanks, Amir. Applied, with Jan's Reviewed-by.

By the way, I see that there's still no documentation for FAN_AUDIT/FAN_ENABLE_AUDIT, added in:

Quoted 8 lines

commit de8cd83e91bc3ee212b3e6ec6e4283af9e4ab269
Author: Steve Grubb <[email protected]>
Date: Mon Oct 2 20:21:39 2017 -0400

audit: Record fanotify access control decisions

Can anyone help with that?

Thanks for a notification. If Steve doesn't beat me to it, I'll write the doc likely next week.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#4 lore raw
Quoted 37 lines · Jan Kara
Quoted 36 lines · Michael Kerrisk (man-pages)
Quoted 15 lines · Amir Goldstein
---
 man7/fanotify.7 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
man7/fanotify.7 +0 -2
index c4f5397e4..5804a1f30 100644
@@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
 The fanotify API provides notification and interception of
 filesystem events.
 Use cases include virus scanning and hierarchical storage management.
-Currently, only a limited set of events is supported.
-In particular, there is no support for create, delete, and move events.

man7/fanotify.7 fanotify \- monitoring filesystem events · line 40

Quoted 10 lines
man7/fanotify.7 +4 -1
+In the original fanotify API, only a limited set of events was supported.
+In particular, there was no support for create, delete, and move events.
+The support for those events was added in Linux 5.1.
 (See
 .BR inotify (7)
-for details of an API that does notify those events.)
+for details of an API that did notify those events pre Linux 5.1.)
 .PP
 Additional capabilities compared to the
 .BR inotify (7)

Thanks, Amir. Applied, with Jan's Reviewed-by.

By the way, I see that there's still no documentation for FAN_AUDIT/FAN_ENABLE_AUDIT, added in:

    commit de8cd83e91bc3ee212b3e6ec6e4283af9e4ab269
    Author: Steve Grubb <[email protected]>
    Date:   Mon Oct 2 20:21:39 2017 -0400
Quoted 7 lines
Quoted 4 lines

audit: Record fanotify access control decisions

Can anyone help with that?

Thanks for a notification. If Steve doesn't beat me to it, I'll write the doc likely next week.

Ping!

Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
#5 lore raw
Quoted 41 lines · Michael Kerrisk (man-pages)
Quoted 40 lines · Jan Kara
Quoted 39 lines · Michael Kerrisk (man-pages)
Quoted 15 lines · Amir Goldstein
---
 man7/fanotify.7 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
man7/fanotify.7 +0 -2
index c4f5397e4..5804a1f30 100644
@@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
 The fanotify API provides notification and interception of
 filesystem events.
 Use cases include virus scanning and hierarchical storage management.
-Currently, only a limited set of events is supported.
-In particular, there is no support for create, delete, and move events.

man7/fanotify.7 fanotify \- monitoring filesystem events · line 40

Quoted 10 lines
man7/fanotify.7 +4 -1
+In the original fanotify API, only a limited set of events was supported.
+In particular, there was no support for create, delete, and move events.
+The support for those events was added in Linux 5.1.
 (See
 .BR inotify (7)
-for details of an API that does notify those events.)
+for details of an API that did notify those events pre Linux 5.1.)
 .PP
 Additional capabilities compared to the
 .BR inotify (7)

Thanks, Amir. Applied, with Jan's Reviewed-by.

By the way, I see that there's still no documentation for FAN_AUDIT/FAN_ENABLE_AUDIT, added in:

commit de8cd83e91bc3ee212b3e6ec6e4283af9e4ab269
Author: Steve Grubb <[email protected]>
Date: Mon Oct 2 20:21:39 2017 -0400

audit: Record fanotify access control decisions

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Can anyone help with that?

Thanks for a notification. If Steve doesn't beat me to it, I'll write the doc likely next week.

Ping!

I've already sent it and Steve has acked it [1]. So the ball is on your side ;).

Honza

[1] https://lore.kernel.org/linux-man/4619055.31r3eYUQgx@x2

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#6 lore raw

Hello Jan,

Quoted 47 lines · Jan Kara
Quoted 46 lines · Michael Kerrisk (man-pages)
Quoted 44 lines · Jan Kara
Quoted 32 lines · Michael Kerrisk (man-pages)
Quoted 15 lines · Amir Goldstein
---
 man7/fanotify.7 | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
man7/fanotify.7 +0 -2
index c4f5397e4..5804a1f30 100644
@@ -29,11 +29,12 @@ fanotify \- monitoring filesystem events
 The fanotify API provides notification and interception of
 filesystem events.
 Use cases include virus scanning and hierarchical storage management.
-Currently, only a limited set of events is supported.
-In particular, there is no support for create, delete, and move events.

man7/fanotify.7 fanotify \- monitoring filesystem events · line 40

Quoted 10 lines
man7/fanotify.7 +4 -1
+In the original fanotify API, only a limited set of events was supported.
+In particular, there was no support for create, delete, and move events.
+The support for those events was added in Linux 5.1.
 (See
 .BR inotify (7)
-for details of an API that does notify those events.)
+for details of an API that did notify those events pre Linux 5.1.)
 .PP
 Additional capabilities compared to the
 .BR inotify (7)

Thanks, Amir. Applied, with Jan's Reviewed-by.

By the way, I see that there's still no documentation for FAN_AUDIT/FAN_ENABLE_AUDIT, added in:

Quoted 8 lines

commit de8cd83e91bc3ee212b3e6ec6e4283af9e4ab269
Author: Steve Grubb <[email protected]>
Date: Mon Oct 2 20:21:39 2017 -0400

audit: Record fanotify access control decisions

Can anyone help with that?

Thanks for a notification. If Steve doesn't beat me to it, I'll write the doc likely next week.

Quoted 8 lines
Quoted 1 line

Ping!

I've already sent it and Steve has acked it [1]. So the ball is on your side ;).

Honza

[1] https://lore.kernel.org/linux-man/4619055.31r3eYUQgx@x2

I was slightly confused because you mentioned in that thread that you might revise the patych after the comments from Alex.

Anyway, I applied now, and did some light editing. Thank you for the patch!

Cheers,

Michael

Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/