ASoC: fix !OF compile test warnings
Subsystems (14)
v2 cover ASoC: fix !OF compile test warnings
Hi,
Changes since v1:
1. New patch 2/39: ASoC: bd28623: mark OF related data as maybe unused,
2. Patches 1-13: add maybe_unused after discussions with Mark,
3. Add Sylwester's review to two patches (one changed so please review one more time).
Best regards,
Krzysztof
Krzysztof Kozlowski (39):
ASoC: ak5558: mark OF related data as maybe unused
ASoC: bd28623: mark OF related data as maybe unused
ASoC: gtm601: mark OF related data as maybe unused
ASoC: inno_rk3036: mark OF related data as maybe unused
ASoC: rk3328: mark OF related data as maybe unused
ASoC: tas571x: mark OF related data as maybe unused
ASoC: kirkwood: armada-370-db: mark OF related data as maybe unused
ASoC: meson: t9015: mark OF related data as maybe unused
ASoC: qcom: mark OF related data as maybe unused
ASoC: samsung: smdk_wm8994: mark OF related data as maybe unused
ASoC: rockchip: mark OF related data as maybe unused
ASoC: ti: davinci: mark OF related data as maybe unused
ASoC: uniphier: mark OF related data as maybe unused
ASoC: ak4118: skip of_device_id table when !CONFIG_OF
ASoC: alc5623: skip of_device_id table when !CONFIG_OF
ASoC: alc5632: skip of_device_id table when !CONFIG_OF
ASoC: da7218: skip of_device_id table when !CONFIG_OF
ASoC: da7219: skip of_device_id table when !CONFIG_OF
ASoC: da9055: skip of_device_id table when !CONFIG_OF
ASoC: es8316: skip of_device_id table when !CONFIG_OF
ASoC: max98090: skip of_device_id table when !CONFIG_OF
ASoC: max98095: skip of_device_id table when !CONFIG_OF
ASoC: max98371: skip of_device_id table when !CONFIG_OF
ASoC: max9867: skip of_device_id table when !CONFIG_OF
ASoC: max98925: skip of_device_id table when !CONFIG_OF
ASoC: max98926: skip of_device_id table when !CONFIG_OF
ASoC: pcm1789: skip of_device_id table when !CONFIG_OF
ASoC: pcm179x: skip of_device_id table when !CONFIG_OF
ASoC: rt5660: skip of_device_id table when !CONFIG_OF
ASoC: tas2562: skip of_device_id table when !CONFIG_OF
ASoC: tlv320: skip of_device_id table when !CONFIG_OF
ASoC: ts3a227e: skip of_device_id table when !CONFIG_OF
ASoC: es7134: mark OF related data as maybe unused
ASoC: es7241: mark OF related data as maybe unused
ASoC: samsung: i2s: mark OF related data as maybe unused
ASoC: max98371: drop driver pm=NULL assignment
ASoC: max98925: drop driver pm=NULL assignment
ASoC: max98926: drop driver pm=NULL assignment
ASoC: samsung: smdk_wm8994: remove redundant of_match_ptr()
sound/soc/codecs/ak4118.c | 2 ++ sound/soc/codecs/ak5558.c | 2 +- sound/soc/codecs/alc5623.c | 2 ++ sound/soc/codecs/alc5632.c | 2 ++ sound/soc/codecs/bd28623.c | 2 +- sound/soc/codecs/da7218.c | 2 ++ sound/soc/codecs/da7219.c | 2 ++ sound/soc/codecs/da9055.c | 2 ++ sound/soc/codecs/es7134.c | 4 ++-- sound/soc/codecs/es7241.c | 2 +- sound/soc/codecs/es8316.c | 2 ++ sound/soc/codecs/gtm601.c | 2 +- sound/soc/codecs/inno_rk3036.c | 2 +- sound/soc/codecs/max98090.c | 2 ++ sound/soc/codecs/max98095.c | 2 ++ sound/soc/codecs/max98371.c | 3 ++- sound/soc/codecs/max9867.c | 2 ++ sound/soc/codecs/max98925.c | 3 ++- sound/soc/codecs/max98926.c | 3 ++- sound/soc/codecs/pcm1789-i2c.c | 2 ++ sound/soc/codecs/pcm179x-i2c.c | 2 ++ sound/soc/codecs/rk3328_codec.c | 2 +- sound/soc/codecs/rt5660.c | 2 ++ sound/soc/codecs/tas2562.c | 2 ++ sound/soc/codecs/tas571x.c | 4 ++-- sound/soc/codecs/tlv320adcx140.c | 2 ++ sound/soc/codecs/tlv320aic23-i2c.c | 2 ++ sound/soc/codecs/ts3a227e.c | 2 ++ sound/soc/kirkwood/armada-370-db.c | 2 +- sound/soc/meson/t9015.c | 2 +- sound/soc/qcom/apq8016_sbc.c | 2 +- sound/soc/qcom/lpass-apq8016.c | 2 +- sound/soc/qcom/lpass-ipq806x.c | 2 +- sound/soc/qcom/lpass-sc7180.c | 2 +- sound/soc/rockchip/rockchip_i2s.c | 2 +- sound/soc/rockchip/rockchip_pdm.c | 2 +- sound/soc/rockchip/rockchip_spdif.c | 2 +- sound/soc/samsung/i2s.c | 8 ++++---- sound/soc/samsung/smdk_wm8994.c | 4 ++-- sound/soc/ti/davinci-i2s.c | 2 +- sound/soc/uniphier/aio-ld11.c | 2 +- sound/soc/uniphier/aio-pxs2.c | 2 +- sound/soc/uniphier/evea.c | 2 +- 43 files changed, 69 insertions(+), 32 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/39 ASoC: ak5558: mark OF related data as maybe unused
The driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/ak5558.c:418:34: warning: ‘ak5558_i2c_dt_ids’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/ak5558.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ak5558.c +1 -1
@@ -415,7 +415,7 @@ static int ak5558_i2c_remove(struct i2c_client *i2c)return 0 ; } -static const struct of_device_id ak5558_i2c_dt_ids[] = { +static const struct of_device_id ak5558_i2c_dt_ids[]__maybe_unused = { { .compatible ="asahi-kasei,ak5558" }, { } };
Signature · 7 lines
2.25.1 _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic
PATCH v2 2/39 ASoC: bd28623: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/bd28623.c:225:34: warning: ‘bd28623_of_match’ defined but not used [-Wunused-const-variable=]
---
New patch
--- sound/soc/codecs/bd28623.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/bd28623.c +1 -1
@@ -222,7 +222,7 @@ static int bd28623_probe(struct platform_device *pdev) &soc_dai_bd, 1); } -static const struct of_device_id bd28623_of_match[] = { +static const struct of_device_id bd28623_of_match[]__maybe_unused = { { .compatible ="rohm,bd28623" , }, {} };
Signature · 1 line
2.25.1
PATCH v2 3/39 ASoC: gtm601: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/gtm601.c:90:34: warning: ‘gtm601_codec_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/gtm601.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/gtm601.c +1 -1
@@ -87,7 +87,7 @@ static int gtm601_platform_probe(struct platform_device *pdev) (struct snd_soc_dai_driver *)dai_driver, 1); } -static const struct of_device_id gtm601_codec_of_match[] = { +static const struct of_device_id gtm601_codec_of_match[]__maybe_unused = { { .compatible ="option,gtm601" , .data = (void *)>m601_dai }, { .compatible ="broadmobi,bm818" , .data = (void *)&bm818_dai }, {},
Signature · 1 line
2.25.1
PATCH v2 4/39 ASoC: inno_rk3036: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/inno_rk3036.c:470:34: warning: ‘rk3036_codec_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/inno_rk3036.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/inno_rk3036.c +1 -1
@@ -467,7 +467,7 @@ static int rk3036_codec_platform_remove(struct platform_device *pdev)return 0 ; } -static const struct of_device_id rk3036_codec_of_match[] = { +static const struct of_device_id rk3036_codec_of_match[]__maybe_unused = { { .compatible ="rockchip,rk3036-codec" , }, {} };
Signature · 1 line
2.25.1
PATCH v2 5/39 ASoC: rk3328: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/rk3328_codec.c:502:34: warning: ‘rk3328_codec_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/rk3328_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/rk3328_codec.c +1 -1
@@ -499,7 +499,7 @@ static int rk3328_platform_probe(struct platform_device *pdev) ARRAY_SIZE(rk3328_dai)); } -static const struct of_device_id rk3328_codec_of_match[] = { +static const struct of_device_id rk3328_codec_of_match[]__maybe_unused = { { .compatible ="rockchip,rk3328-codec" , }, {}, };
Signature · 1 line
2.25.1
PATCH v2 6/39 ASoC: tas571x: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/tas571x.c:892:34: warning: ‘tas571x_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/tas571x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/tas571x.c +2 -2
@@ -773,7 +773,7 @@ static struct snd_soc_dai_driver tas571x_dai = { .ops = &tas571x_dai_ops, }; -static const struct of_device_id tas571x_of_match[]; +static const struct of_device_id tas571x_of_match[]__maybe_unused ;static int tas571x_i2c_probe (struct i2c_client *client,const struct i2c_device_id *id)
@@ -889,7 +889,7 @@ static int tas571x_i2c_remove(struct i2c_client *client)return 0 ; } -static const struct of_device_id tas571x_of_match[] = { +static const struct of_device_id tas571x_of_match[]__maybe_unused = { { .compatible ="ti,tas5707" , .data = &tas5707_chip, }, { .compatible ="ti,tas5711" , .data = &tas5711_chip, }, { .compatible ="ti,tas5717" , .data = &tas5717_chip, },
Signature · 1 line
2.25.1
PATCH v2 7/39 ASoC: kirkwood: armada-370-db: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/kirkwood/armada-370-db.c:137:34: warning: ‘a370db_dt_ids’ defined but not used [-Wunused-const-variable=]
--- sound/soc/kirkwood/armada-370-db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/kirkwood/armada-370-db.c +1 -1
@@ -134,7 +134,7 @@ static int a370db_probe(struct platform_device *pdev)return devm_snd_soc_register_card (card->dev, card); } -static const struct of_device_id a370db_dt_ids[] = { +static const struct of_device_id a370db_dt_ids[]__maybe_unused = { { .compatible ="marvell,a370db-audio" }, { }, };
Signature · 1 line
2.25.1
PATCH v2 8/39 ASoC: meson: t9015: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/meson/t9015.c:315:34: warning: ‘t9015_ids’ defined but not used [-Wunused-const-variable=]
--- sound/soc/meson/t9015.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/meson/t9015.c +1 -1
@@ -312,7 +312,7 @@ static int t9015_probe(struct platform_device *pdev) &t9015_dai, 1); } -static const struct of_device_id t9015_ids[] = { +static const struct of_device_id t9015_ids[]__maybe_unused = { { .compatible ="amlogic,t9015" , }, { } };
Signature · 1 line
2.25.1
PATCH v2 9/39 ASoC: qcom: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/qcom/lpass-apq8016.c:294:34: warning: ‘apq8016_lpass_cpu_device_id’ defined but not used [-Wunused-const-variable=]
--- sound/soc/qcom/apq8016_sbc.c | 2 +- sound/soc/qcom/lpass-apq8016.c | 2 +- sound/soc/qcom/lpass-ipq806x.c | 2 +- sound/soc/qcom/lpass-sc7180.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
sound/soc/qcom/apq8016_sbc.c +1 -1
@@ -167,7 +167,7 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev)return devm_snd_soc_register_card (&pdev->dev, card); } -static const struct of_device_id apq8016_sbc_device_id[] = { +static const struct of_device_id apq8016_sbc_device_id[]__maybe_unused = { { .compatible ="qcom,apq8016-sbc-sndcard" }, {}, };
sound/soc/qcom/lpass-apq8016.c +1 -1
@@ -291,7 +291,7 @@ static struct lpass_variant apq8016_data = { .free_dma_channel = apq8016_lpass_free_dma_channel, }; -static const struct of_device_id apq8016_lpass_cpu_device_id[] = { +static const struct of_device_id apq8016_lpass_cpu_device_id[]__maybe_unused = { { .compatible ="qcom,lpass-cpu-apq8016" , .data = &apq8016_data }, {} };
sound/soc/qcom/lpass-ipq806x.c +1 -1
@@ -161,7 +161,7 @@ static struct lpass_variant ipq806x_data = { .free_dma_channel = ipq806x_lpass_free_dma_channel, }; -static const struct of_device_id ipq806x_lpass_cpu_device_id[] = { +static const struct of_device_id ipq806x_lpass_cpu_device_id[]__maybe_unused = { { .compatible ="qcom,lpass-cpu" , .data = &ipq806x_data }, {} };
sound/soc/qcom/lpass-sc7180.c +1 -1
@@ -284,7 +284,7 @@ static struct lpass_variant sc7180_data = { .free_dma_channel = sc7180_lpass_free_dma_channel, }; -static const struct of_device_id sc7180_lpass_cpu_device_id[] = { +static const struct of_device_id sc7180_lpass_cpu_device_id[]__maybe_unused = { {.compatible ="qcom,sc7180-lpass-cpu" , .data = &sc7180_data}, {} };
Signature · 1 line
2.25.1
PATCH v2 10/39 ASoC: samsung: smdk_wm8994: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/samsung/smdk_wm8994.c:139:34: warning: ‘samsung_wm8994_of_match’ defined but not used [-Wunused-const-variable=]
---
Not adding Sylwester's review as patch changed.
--- sound/soc/samsung/smdk_wm8994.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/samsung/smdk_wm8994.c +1 -1
@@ -136,7 +136,7 @@ static struct snd_soc_card smdk = { .num_links = ARRAY_SIZE(smdk_dai), }; -static const struct of_device_id samsung_wm8994_of_match[] = { +static const struct of_device_id samsung_wm8994_of_match[]__maybe_unused = { { .compatible ="samsung,smdk-wm8994" , .data = &smdk_board_data }, {}, };
Signature · 1 line
2.25.1
PATCH v2 11/39 ASoC: rockchip: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/rockchip/rockchip_i2s.c:569:34: warning: ‘rockchip_i2s_match’ defined but not used [-Wunused-const-variable=] sound/soc/rockchip/rockchip_pdm.c:463:34: warning: ‘rockchip_pdm_match’ defined but not used [-Wunused-const-variable=] sound/soc/rockchip/rockchip_spdif.c:44:34: warning: ‘rk_spdif_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/rockchip/rockchip_i2s.c | 2 +- sound/soc/rockchip/rockchip_pdm.c | 2 +- sound/soc/rockchip/rockchip_spdif.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
sound/soc/rockchip/rockchip_i2s.c +1 -1
@@ -566,7 +566,7 @@ static const struct rk_i2s_pins rk3399_i2s_pins = { .shift = 11, }; -static const struct of_device_id rockchip_i2s_match[] = { +static const struct of_device_id rockchip_i2s_match[]__maybe_unused = { { .compatible ="rockchip,rk3066-i2s" , }, { .compatible ="rockchip,rk3188-i2s" , }, { .compatible ="rockchip,rk3288-i2s" , },
sound/soc/rockchip/rockchip_pdm.c +1 -1
@@ -460,7 +460,7 @@ static const struct regmap_config rockchip_pdm_regmap_config = { .cache_type = REGCACHE_FLAT, }; -static const struct of_device_id rockchip_pdm_match[] = { +static const struct of_device_id rockchip_pdm_match[]__maybe_unused = { { .compatible ="rockchip,pdm" , .data = (void *)RK_PDM_RK3229 }, { .compatible ="rockchip,px30-pdm" ,
sound/soc/rockchip/rockchip_spdif.c +1 -1
@@ -41,7 +41,7 @@ struct rk_spdif_dev {struct regmap *regmap; }; -static const struct of_device_id rk_spdif_match[] = { +static const struct of_device_id rk_spdif_match[]__maybe_unused = { { .compatible ="rockchip,rk3066-spdif" , .data = (void *)RK_SPDIF_RK3066 }, { .compatible ="rockchip,rk3188-spdif" ,
Signature · 1 line
2.25.1
PATCH v2 12/39 ASoC: ti: davinci: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/ti/davinci-i2s.c:750:34: warning: ‘davinci_i2s_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/ti/davinci-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/ti/davinci-i2s.c +1 -1
@@ -747,7 +747,7 @@ static int davinci_i2s_remove(struct platform_device *pdev)return 0 ; } -static const struct of_device_id davinci_i2s_match[] = { +static const struct of_device_id davinci_i2s_match[]__maybe_unused = { { .compatible ="ti,da850-mcbsp" }, {}, };
Signature · 1 line
2.25.1
PATCH v2 13/39 ASoC: uniphier: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/uniphier/aio-ld11.c:375:34: warning: ‘uniphier_aio_of_match’ defined but not used [-Wunused-const-variable=] sound/soc/uniphier/evea.c:554:34: warning: ‘evea_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/uniphier/aio-ld11.c | 2 +- sound/soc/uniphier/aio-pxs2.c | 2 +- sound/soc/uniphier/evea.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
sound/soc/uniphier/aio-ld11.c +1 -1
@@ -372,7 +372,7 @@ static const struct uniphier_aio_chip_spec uniphier_aio_ld20_spec = { .addr_ext = 1, }; -static const struct of_device_id uniphier_aio_of_match[] = { +static const struct of_device_id uniphier_aio_of_match[]__maybe_unused = { { .compatible ="socionext,uniphier-ld11-aio" , .data = &uniphier_aio_ld11_spec,
sound/soc/uniphier/aio-pxs2.c +1 -1
@@ -282,7 +282,7 @@ static const struct uniphier_aio_chip_spec uniphier_aio_pxs2_spec = { .addr_ext = 0, }; -static const struct of_device_id uniphier_aio_of_match[] = { +static const struct of_device_id uniphier_aio_of_match[]__maybe_unused = { { .compatible ="socionext,uniphier-pxs2-aio" , .data = &uniphier_aio_pxs2_spec,
sound/soc/uniphier/evea.c +1 -1
@@ -551,7 +551,7 @@ static int evea_remove(struct platform_device *pdev)return 0 ; } -static const struct of_device_id evea_of_match[] = { +static const struct of_device_id evea_of_match[]__maybe_unused = { { .compatible ="socionext,uniphier-evea" , }, {} };
Signature · 1 line
2.25.1
PATCH v2 14/39 ASoC: ak4118: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/ak4118.c:407:34: warning: ‘ak4118_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/ak4118.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/ak4118.c +2 -0
@@ -404,11 +404,13 @@ static int ak4118_i2c_probe(struct i2c_client *i2c, &soc_component_drv_ak4118, &ak4118_dai, 1); } +#ifdef CONFIG_OF static const struct of_device_id ak4118_of_match[] = { { .compatible ="asahi-kasei,ak4118" , }, {} };MODULE_DEVICE_TABLE (of, ak4118_of_match); +#endif static const struct i2c_device_id ak4118_id_table[] = { {"ak4118" ,0 },
Signature · 1 line
2.25.1
PATCH v2 15/39 ASoC: alc5623: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/alc5623.c:1071:34: warning: ‘alc5623_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/alc5623.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/alc5623.c +2 -0
@@ -1068,11 +1068,13 @@ static const struct i2c_device_id alc5623_i2c_table[] = { };MODULE_DEVICE_TABLE (i2c, alc5623_i2c_table); +#ifdef CONFIG_OF static const struct of_device_id alc5623_of_match[] = { { .compatible ="realtek,alc5623" , }, { } };MODULE_DEVICE_TABLE (of, alc5623_of_match); +#endif /* i2c codec control layer */ static struct i2c_driver alc5623_i2c_driver = {
Signature · 1 line
2.25.1
PATCH v2 16/39 ASoC: alc5632: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/alc5632.c:1170:34: warning: ‘alc5632_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/alc5632.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/alc5632.c +2 -0
@@ -1167,11 +1167,13 @@ static const struct i2c_device_id alc5632_i2c_table[] = { };MODULE_DEVICE_TABLE (i2c, alc5632_i2c_table); +#ifdef CONFIG_OF static const struct of_device_id alc5632_of_match[] = { { .compatible ="realtek,alc5632" , }, { } };MODULE_DEVICE_TABLE (of, alc5632_of_match); +#endif /* i2c codec control layer */ static struct i2c_driver alc5632_i2c_driver = {
Signature · 1 line
2.25.1
PATCH v2 17/39 ASoC: da7218: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/da7218.c:2281:34: warning: ‘da7218_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/da7218.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/da7218.c +2 -0
@@ -2278,12 +2278,14 @@ static irqreturn_t da7218_irq_thread(int irq, void *data)* DT */ +#ifdef CONFIG_OF static const struct of_device_id da7218_of_match[] = { { .compatible ="dlg,da7217" , .data = (void *)DA7217_DEV_ID }, { .compatible ="dlg,da7218" , .data = (void *)DA7218_DEV_ID }, { } };MODULE_DEVICE_TABLE (of, da7218_of_match); +#endif static inline int da7218_of_get_id (struct device *dev) {
Signature · 1 line
2.25.1
PATCH v2 18/39 ASoC: da7219: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/da7219.c:1705:34: warning: ‘da7219_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/da7219.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/da7219.c +2 -0
@@ -1702,11 +1702,13 @@ static struct snd_soc_dai_driver da7219_dai = {* DT/ACPI */ +#ifdef CONFIG_OF static const struct of_device_id da7219_of_match[] = { { .compatible ="dlg,da7219" , }, { } };MODULE_DEVICE_TABLE (of, da7219_of_match); +#endif #ifdef CONFIG_ACPI static const struct acpi_device_id da7219_acpi_match[] = {
Signature · 1 line
2.25.1
PATCH v2 19/39 ASoC: da9055: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/da9055.c:1522:34: warning: ‘da9055_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/da9055.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/da9055.c +2 -0
@@ -1519,11 +1519,13 @@ static const struct i2c_device_id da9055_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, da9055_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id da9055_of_match[] = { { .compatible ="dlg,da9055-codec" , }, { } };MODULE_DEVICE_TABLE (of, da9055_of_match); +#endif /* I2C codec control layer */ static struct i2c_driver da9055_i2c_driver = {
Signature · 1 line
2.25.1
PATCH v2 20/39 ASoC: es8316: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/es8316.c:837:34: warning: ‘es8316_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/es8316.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/es8316.c +2 -0
@@ -834,11 +834,13 @@ static const struct i2c_device_id es8316_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, es8316_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id es8316_of_match[] = { { .compatible ="everest,es8316" , }, {}, };MODULE_DEVICE_TABLE (of, es8316_of_match); +#endif #ifdef CONFIG_ACPI static const struct acpi_device_id es8316_acpi_match[] = {
Signature · 1 line
2.25.1
PATCH v2 21/39 ASoC: max98090: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/max98090.c:2671:34: warning: ‘max98090_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/max98090.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/max98090.c +2 -0
@@ -2668,12 +2668,14 @@ static const struct i2c_device_id max98090_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, max98090_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id max98090_of_match[] = { { .compatible ="maxim,max98090" , }, { .compatible ="maxim,max98091" , }, { } };MODULE_DEVICE_TABLE (of, max98090_of_match); +#endif #ifdef CONFIG_ACPI static const struct acpi_device_id max98090_acpi_match[] = {
Signature · 1 line
2.25.1
PATCH v2 22/39 ASoC: max98095: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/max98095.c:2151:34: warning: ‘max98095_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/max98095.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/max98095.c +2 -0
@@ -2148,11 +2148,13 @@ static const struct i2c_device_id max98095_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, max98095_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id max98095_of_match[] = { { .compatible ="maxim,max98095" , }, { } };MODULE_DEVICE_TABLE (of, max98095_of_match); +#endif static struct i2c_driver max98095_i2c_driver = { .driver = {
Signature · 1 line
2.25.1
PATCH v2 23/39 ASoC: max98371: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/max98371.c:411:34: warning: ‘max98371_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/max98371.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/max98371.c +2 -0
@@ -408,11 +408,13 @@ static const struct i2c_device_id max98371_i2c_id[] = {MODULE_DEVICE_TABLE (i2c, max98371_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id max98371_of_match[] = { { .compatible ="maxim,max98371" , }, { } };MODULE_DEVICE_TABLE (of, max98371_of_match); +#endif static struct i2c_driver max98371_i2c_driver = { .driver = {
Signature · 1 line
2.25.1
PATCH v2 24/39 ASoC: max9867: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/max9867.c:652:34: warning: ‘max9867_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/max9867.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/max9867.c +2 -0
@@ -649,11 +649,13 @@ static const struct i2c_device_id max9867_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, max9867_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id max9867_of_match[] = { { .compatible ="maxim,max9867" , }, { } };MODULE_DEVICE_TABLE (of, max9867_of_match); +#endif static struct i2c_driver max9867_i2c_driver = { .driver = {
Signature · 1 line
2.25.1
PATCH v2 25/39 ASoC: max98925: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/max98925.c:630:34: warning: ‘max98925_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/max98925.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/max98925.c +2 -0
@@ -627,11 +627,13 @@ static const struct i2c_device_id max98925_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, max98925_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id max98925_of_match[] = { { .compatible ="maxim,max98925" , }, { } };MODULE_DEVICE_TABLE (of, max98925_of_match); +#endif static struct i2c_driver max98925_i2c_driver = { .driver = {
Signature · 1 line
2.25.1
PATCH v2 26/39 ASoC: max98926: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/max98926.c:574:34: warning: ‘max98926_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/max98926.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/max98926.c +2 -0
@@ -571,11 +571,13 @@ static const struct i2c_device_id max98926_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, max98926_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id max98926_of_match[] = { { .compatible ="maxim,max98926" , }, { } };MODULE_DEVICE_TABLE (of, max98926_of_match); +#endif static struct i2c_driver max98926_i2c_driver = { .driver = {
Signature · 1 line
2.25.1
PATCH v2 27/39 ASoC: pcm1789: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/pcm1789-i2c.c:36:34: warning: ‘pcm1789_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/pcm1789-i2c.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/pcm1789-i2c.c +2 -0
@@ -33,11 +33,13 @@ static int pcm1789_i2c_remove(struct i2c_client *client)return pcm1789_common_exit (&client->dev); } +#ifdef CONFIG_OF static const struct of_device_id pcm1789_of_match[] = { { .compatible ="ti,pcm1789" , }, { } };MODULE_DEVICE_TABLE (of, pcm1789_of_match); +#endif static const struct i2c_device_id pcm1789_i2c_ids[] = { {"pcm1789" ,0 },
Signature · 1 line
2.25.1
PATCH v2 28/39 ASoC: pcm179x: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/pcm179x-i2c.c:33:34: warning: ‘pcm179x_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/pcm179x-i2c.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/pcm179x-i2c.c +2 -0
@@ -30,11 +30,13 @@ static int pcm179x_i2c_probe(struct i2c_client *client,return pcm179x_common_init (&client->dev, regmap); } +#ifdef CONFIG_OF static const struct of_device_id pcm179x_of_match[] = { { .compatible ="ti,pcm1792a" , }, { } };MODULE_DEVICE_TABLE (of, pcm179x_of_match); +#endif static const struct i2c_device_id pcm179x_i2c_ids[] = { {"pcm179x" ,0 },
Signature · 1 line
2.25.1
PATCH v2 29/39 ASoC: rt5660: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/rt5660.c:1238:34: warning: ‘rt5660_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/rt5660.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/rt5660.c +2 -0
@@ -1235,11 +1235,13 @@ static const struct i2c_device_id rt5660_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, rt5660_i2c_id); +#ifdef CONFIG_OF static const struct of_device_id rt5660_of_match[] = { { .compatible ="realtek,rt5660" , }, {}, };MODULE_DEVICE_TABLE (of, rt5660_of_match); +#endif #ifdef CONFIG_ACPI static const struct acpi_device_id rt5660_acpi_match[] = {
Signature · 1 line
2.25.1
PATCH v2 30/39 ASoC: tas2562: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/tas2562.c:805:34: warning: ‘tas2562_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/tas2562.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/tas2562.c +2 -0
@@ -802,6 +802,7 @@ static const struct i2c_device_id tas2562_id[] = { };MODULE_DEVICE_TABLE (i2c, tas2562_id); +#ifdef CONFIG_OF static const struct of_device_id tas2562_of_match[] = { { .compatible ="ti,tas2562" , }, { .compatible = "ti,tas2563", },
@@ -810,6 +811,7 @@ static const struct of_device_id tas2562_of_match[] = { { }, };MODULE_DEVICE_TABLE (of, tas2562_of_match); +#endif static struct i2c_driver tas2562_i2c_driver = { .driver = {
Signature · 1 line
2.25.1
PATCH v2 31/39 ASoC: tlv320: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/tlv320aic23-i2c.c:38:34: warning: ‘tlv320aic23_of_match’ defined but not used [-Wunused-const-variable=] sound/soc/codecs/tlv320adcx140.c:1076:34: warning: ‘tlv320adcx140_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/tlv320adcx140.c | 2 ++ sound/soc/codecs/tlv320aic23-i2c.c | 2 ++ 2 files changed, 4 insertions(+)
sound/soc/codecs/tlv320adcx140.c +2 -0
@@ -1073,6 +1073,7 @@ static struct snd_soc_dai_driver adcx140_dai_driver[] = { } }; +#ifdef CONFIG_OF static const struct of_device_id tlv320adcx140_of_match[] = { { .compatible ="ti,tlv320adc3140" }, { .compatible = "ti,tlv320adc5140" },
@@ -1080,6 +1081,7 @@ static const struct of_device_id tlv320adcx140_of_match[] = { {}, };MODULE_DEVICE_TABLE (of, tlv320adcx140_of_match); +#endif static int adcx140_i2c_probe (struct i2c_client *i2c,const struct i2c_device_id *id)
sound/soc/codecs/tlv320aic23-i2c.c +2 -0
@@ -35,11 +35,13 @@ static const struct i2c_device_id tlv320aic23_id[] = {MODULE_DEVICE_TABLE (i2c, tlv320aic23_id); +#ifdef CONFIG_OF static const struct of_device_id tlv320aic23_of_match[] = { { .compatible ="ti,tlv320aic23" , }, { } };MODULE_DEVICE_TABLE (of, tlv320aic23_of_match); +#endif static struct i2c_driver tlv320aic23_i2c_driver = { .driver = {
Signature · 1 line
2.25.1
PATCH v2 32/39 ASoC: ts3a227e: skip of_device_id table when !CONFIG_OF
In reply to Krzysztof KozlowskiThe driver can match by multiple methods. Its of_device_id table is referenced via of_match_ptr() so it will be unused for !CONFIG_OF builds:
sound/soc/codecs/ts3a227e.c:369:34: warning: ‘ts3a227e_of_match’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/ts3a227e.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/codecs/ts3a227e.c +2 -0
@@ -366,11 +366,13 @@ static const struct i2c_device_id ts3a227e_i2c_ids[] = { };MODULE_DEVICE_TABLE (i2c, ts3a227e_i2c_ids); +#ifdef CONFIG_OF static const struct of_device_id ts3a227e_of_match[] = { { .compatible ="ti,ts3a227e" , }, { } };MODULE_DEVICE_TABLE (of, ts3a227e_of_match); +#endif #ifdef CONFIG_ACPI static struct acpi_device_id ts3a227e_acpi_match[] = {
Signature · 1 line
2.25.1
PATCH v2 33/39 ASoC: es7134: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/es7134.c:264:33: warning: ‘es7154_chip’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/es7134.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/es7134.c +2 -2
@@ -183,7 +183,7 @@ static const struct snd_soc_dapm_route es7134_extra_routes[] = { { "Playback", NULL, "VDD", } }; -static const struct es7134_chip es7134_chip = { +static const struct es7134_chip es7134_chip__maybe_unused = { .dai_drv = &es7134_dai, .modes = es7134_modes, .mode_num = ARRAY_SIZE(es7134_modes),
@@ -261,7 +261,7 @@ static const struct snd_soc_dapm_route es7154_extra_routes[] = { { "Playback", NULL, "PVDD", } }; -static const struct es7134_chip es7154_chip = { +static const struct es7134_chip es7154_chip__maybe_unused = { .dai_drv = &es7154_dai, .modes = es7154_modes, .mode_num = ARRAY_SIZE(es7154_modes),
Signature · 1 line
2.25.1
PATCH v2 34/39 ASoC: es7241: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/codecs/es7241.c:206:33: warning: ‘es7241_chip’ defined but not used [-Wunused-const-variable=]
--- sound/soc/codecs/es7241.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/es7241.c +1 -1
@@ -203,7 +203,7 @@ static const struct es7241_clock_mode es7241_modes[] = { }, }; -static const struct es7241_chip es7241_chip = { +static const struct es7241_chip es7241_chip__maybe_unused = { .modes = es7241_modes, .mode_num =ARRAY_SIZE (es7241_modes), };
Signature · 1 line
2.25.1
PATCH v2 35/39 ASoC: samsung: i2s: mark OF related data as maybe unused
In reply to Krzysztof KozlowskiThe driver can be compile tested with !CONFIG_OF making certain data unused:
sound/soc/samsung/i2s.c:1646:42: warning: ‘i2sv5_dai_type_i2s1’ defined but not used [-Wunused-const-variable=] sound/soc/samsung/i2s.c:1639:42: warning: ‘i2sv7_dai_type’ defined but not used [-Wunused-const-variable=]
--- sound/soc/samsung/i2s.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/samsung/i2s.c +4 -4
@@ -1622,28 +1622,28 @@ static const struct samsung_i2s_dai_data i2sv3_dai_type = { .i2s_variant_regs = &i2sv3_regs, }; -static const struct samsung_i2s_dai_data i2sv5_dai_type = { +static const struct samsung_i2s_dai_data i2sv5_dai_type__maybe_unused = { .quirks =QUIRK_PRI_6CHAN |QUIRK_SEC_DAI |QUIRK_NEED_RSTCLR |QUIRK_SUPPORTS_IDMA , .pcm_rates =SNDRV_PCM_RATE_8000_96000 , .i2s_variant_regs = &i2sv3_regs, }; -static const struct samsung_i2s_dai_data i2sv6_dai_type = { +static const struct samsung_i2s_dai_data i2sv6_dai_type__maybe_unused = { .quirks =QUIRK_PRI_6CHAN |QUIRK_SEC_DAI |QUIRK_NEED_RSTCLR |QUIRK_SUPPORTS_TDM |QUIRK_SUPPORTS_IDMA , .pcm_rates =SNDRV_PCM_RATE_8000_96000 , .i2s_variant_regs = &i2sv6_regs, }; -static const struct samsung_i2s_dai_data i2sv7_dai_type = { +static const struct samsung_i2s_dai_data i2sv7_dai_type__maybe_unused = { .quirks =QUIRK_PRI_6CHAN |QUIRK_SEC_DAI |QUIRK_NEED_RSTCLR |QUIRK_SUPPORTS_TDM , .pcm_rates =SNDRV_PCM_RATE_8000_192000 , .i2s_variant_regs = &i2sv7_regs, }; -static const struct samsung_i2s_dai_data i2sv5_dai_type_i2s1 = { +static const struct samsung_i2s_dai_data i2sv5_dai_type_i2s1__maybe_unused = { .quirks =QUIRK_PRI_6CHAN |QUIRK_NEED_RSTCLR , .pcm_rates =SNDRV_PCM_RATE_8000_96000 , .i2s_variant_regs = &i2sv5_i2s1_regs,
Signature · 1 line
2.25.1
PATCH v2 36/39 ASoC: max98371: drop driver pm=NULL assignment
In reply to Krzysztof KozlowskiThere is no point to explicitly set driver .pm field to NULL.
--- sound/soc/codecs/max98371.c | 1 - 1 file changed, 1 deletion(-)
sound/soc/codecs/max98371.c +0 -1
@@ -419,7 +419,6 @@ MODULE_DEVICE_TABLE(of, max98371_of_match);static struct i2c_driver max98371_i2c_driver = { .driver = { .name ="max98371" , - .pm =NULL , .of_match_table =of_match_ptr (max98371_of_match), }, .probe = max98371_i2c_probe,
Signature · 1 line
2.25.1
PATCH v2 37/39 ASoC: max98925: drop driver pm=NULL assignment
In reply to Krzysztof KozlowskiThere is no point to explicitly set driver .pm field to NULL.
--- sound/soc/codecs/max98925.c | 1 - 1 file changed, 1 deletion(-)
sound/soc/codecs/max98925.c +0 -1
@@ -639,7 +639,6 @@ static struct i2c_driver max98925_i2c_driver = { .driver = { .name = "max98925", .of_match_table = of_match_ptr(max98925_of_match), - .pm = NULL, }, .probe = max98925_i2c_probe, .id_table = max98925_i2c_id,
Signature · 1 line
2.25.1
PATCH v2 38/39 ASoC: max98926: drop driver pm=NULL assignment
In reply to Krzysztof KozlowskiThere is no point to explicitly set driver .pm field to NULL.
--- sound/soc/codecs/max98926.c | 1 - 1 file changed, 1 deletion(-)
sound/soc/codecs/max98926.c +0 -1
@@ -583,7 +583,6 @@ static struct i2c_driver max98926_i2c_driver = { .driver = { .name = "max98926", .of_match_table = of_match_ptr(max98926_of_match), - .pm = NULL, }, .probe = max98926_i2c_probe, .id_table = max98926_i2c_id,
Signature · 1 line
2.25.1
PATCH v2 39/39 ASoC: samsung: smdk_wm8994: remove redundant of_match_ptr()
In reply to Krzysztof Kozlowskiof_match_device() already handles properly !CONFIG_OF case, so passing the argument via of_match_ptr() is not needed.
--- sound/soc/samsung/smdk_wm8994.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/samsung/smdk_wm8994.c +1 -1
@@ -170,7 +170,7 @@ static int smdk_audio_probe(struct platform_device *pdev) smdk_dai[0 ].platforms->of_node = smdk_dai[0 ].cpus->of_node; } - id =of_match_device (of_match_ptr (samsung_wm8994_of_match), &pdev->dev); + id =of_match_device (samsung_wm8994_of_match, &pdev->dev);if (id) *board = *((struct smdk_wm8994_data *)id->data);
Signature · 1 line
2.25.1
Mark Brown
maintainerQuoted 10 lines · Krzysztof Kozlowski
Changes since v1:
1. New patch 2/39: ASoC: bd28623: mark OF related data as maybe unused,
2. Patches 1-13: addmaybe_unusedafter discussions with Mark,
3. Add Sylwester's review to two patches (one changed so please review one more time).Best regards,
Krzysztof[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[01/39] ASoC: ak5558: mark OF related data as maybe unused
commit: 9f34c04057232ca2688d26416d3f0011c5ea5377
[02/39] ASoC: bd28623: mark OF related data as maybe unused
commit: 1bab2b22675f2e4bd498a7688b681839a7ecece0
[03/39] ASoC: gtm601: mark OF related data as maybe unused
commit: 03219faf153c3adb93d68355a8ccbaa48e40735f
[04/39] ASoC: inno_rk3036: mark OF related data as maybe unused
commit: 66b9890634690c71910c8dd41f273e87f9bc4b4a
[05/39] ASoC: rk3328: mark OF related data as maybe unused
commit: 84902aec0886e1a8fdd26ae6b8a65fb2c26018a8
[06/39] ASoC: tas571x: mark OF related data as maybe unused
commit: f38c0b1e8a63439edc234a65bb549d3c6e49e66e
[07/39] ASoC: kirkwood: armada-370-db: mark OF related data as maybe unused
commit: d013a59a199e81582c6435a924a23ed393279b07
[08/39] ASoC: meson: t9015: mark OF related data as maybe unused
commit: b397f02171e6d6ca9b77e4cfec73c0dfe2345562
[09/39] ASoC: qcom: mark OF related data as maybe unused
commit: 377c7b7cc11d80acf85101416d1122135f997dc5
[10/39] ASoC: samsung: smdk_wm8994: mark OF related data as maybe unused
commit: 3285b6623653befaf97687d418c99531a09037db
[11/39] ASoC: rockchip: mark OF related data as maybe unused
commit: 56af27ad5f363e030a1191da459460fcb70cf76a
[12/39] ASoC: ti: davinci: mark OF related data as maybe unused
commit: 4bad6ec57d8045046ae8f8e410a16c1ad9d652f2
[13/39] ASoC: uniphier: mark OF related data as maybe unused
commit: c0b7cf59971e9f5fd1960774dc8a1728777cd437
[14/39] ASoC: ak4118: skip of_device_id table when !CONFIG_OF
commit: bda20fb03e54c261b6ff8b0d04344ed9a1812338
[15/39] ASoC: alc5623: skip of_device_id table when !CONFIG_OF
commit: d11f8974896817382f8adda8b6c9071387cb2ce0
[16/39] ASoC: alc5632: skip of_device_id table when !CONFIG_OF
commit: 5207e768347dbb3249ee83979e868850b4b9d23b
[17/39] ASoC: da7218: skip of_device_id table when !CONFIG_OF
commit: a06cd8cf97a336c87a98c7e64e5692c5391b50e6
[18/39] ASoC: da7219: skip of_device_id table when !CONFIG_OF
commit: a7de367daa8412fe854a255c2b4ff5bd4399c00a
[19/39] ASoC: da9055: skip of_device_id table when !CONFIG_OF
commit: a25b45dc143748354947cbc30b682deacb27978f
[20/39] ASoC: es8316: skip of_device_id table when !CONFIG_OF
commit: 75333af40a25ca33179cbbe68019da0b9a123262
[21/39] ASoC: max98090: skip of_device_id table when !CONFIG_OF
commit: ac792c0ab3db9392bbbc7023fefb41bc9d467bfc
[22/39] ASoC: max98095: skip of_device_id table when !CONFIG_OF
commit: a5a196bf0a0b9af14e0170282a3c8d8febe9fe64
[23/39] ASoC: max98371: skip of_device_id table when !CONFIG_OF
commit: e77332c3e741e88ea025c9d0fbb22c833cdb01ad
[24/39] ASoC: max9867: skip of_device_id table when !CONFIG_OF
commit: 682e22193120a87a25ed7d7a71bbac682a33e2ee
[25/39] ASoC: max98925: skip of_device_id table when !CONFIG_OF
commit: d39d9cb5a2c9526c19e2d3a0a43465d49143426d
[26/39] ASoC: max98926: skip of_device_id table when !CONFIG_OF
commit: fff68ff65129525c88d52a05a55cabff5a4b0821
[27/39] ASoC: pcm1789: skip of_device_id table when !CONFIG_OF
commit: 36cbbf009f229fe27eac869cb279de1f80aa654b
[28/39] ASoC: pcm179x: skip of_device_id table when !CONFIG_OF
commit: e2baf7fa3e84a6f1fb930f10547401d9363b4caf
[29/39] ASoC: rt5660: skip of_device_id table when !CONFIG_OF
commit: c7bfb25333526463ffc38b5c3460e6778e474c9d
[30/39] ASoC: tas2562: skip of_device_id table when !CONFIG_OF
commit: 68591e8aa122b43e5f9c6eb5cf49c559e5d6300e
[31/39] ASoC: tlv320: skip of_device_id table when !CONFIG_OF
commit: 762e0b8baf63b1bb534254f89148884c873363f3
[32/39] ASoC: ts3a227e: skip of_device_id table when !CONFIG_OF
commit: 62bd3054af54d4d55267a623c4d938fd42f48b59
[33/39] ASoC: es7134: mark OF related data as maybe unused
commit: 418fb63003f6e2d99d6f6eb6ba25e1576bf55348
[34/39] ASoC: es7241: mark OF related data as maybe unused
commit: 55c259bf06e5f7a899411e474a48d79cf1a0a2f6
[35/39] ASoC: samsung: i2s: mark OF related data as maybe unused
commit: da773b2b45f9de4f44bd62db8b291e2b0a4c3f5b
[36/39] ASoC: max98371: drop driver pm=NULL assignment
commit: fe4b501e56af81f88215f943c2caef5eded26920
[37/39] ASoC: max98925: drop driver pm=NULL assignment
commit: 0eb97389cc4d470b3fdf5384f70f4dc074004843
[38/39] ASoC: max98926: drop driver pm=NULL assignment
commit: c37de70121a03415acd4c7de58a65c4a55ab4c6b
[39/39] ASoC: samsung: smdk_wm8994: remove redundant of_match_ptr()
commit: 0670c9a7239a478ec9675fa82d7ee0a86ef22fe5All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic