Skip to contentSkip to conversation

evaluation order bug in acpi_pic_sci_set_trigger() ?

DISCUSSION Alexey Dobriyan 2 participants 3 messages Nov 25, 2020 – Nov 27, 2020 ACPI

lore
Share & tools
lore
#0 lore raw

acpi_pic_sci_set_trigger() contains the following code:

	/* Real old ELCR mask */
	old = inb(0x4d0) | (inb(0x4d1) << 8);

Operand evalution order is not guaranteed for binary or. I wonder if this is a bug?

Alexey

#1 lore raw
Quoted 8 lines · Alexey Dobriyan

acpi_pic_sci_set_trigger() contains the following code:

        /* Real old ELCR mask */
        old = inb(0x4d0) | (inb(0x4d1) << 8);

Operand evalution order is not guaranteed for binary or. I wonder if this is a bug?

Does the ordering matter in practice?

#2 lore raw
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Alexey Dobriyan

acpi_pic_sci_set_trigger() contains the following code:

        /* Real old ELCR mask */
        old = inb(0x4d0) | (inb(0x4d1) << 8);

Operand evalution order is not guaranteed for binary or. I wonder if this is a bug?

Does the ordering matter in practice?

I have no idea, this is why I'm asking. :-)