serial: imx: Remove unneeded of_device_get_match_data() NULL check
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 serial: imx: Remove unneeded of_device_get_match_data() NULL check
Since 5.10-rc1 i.MX is a devicetree-only platform and the NULL check on of_device_get_match_data() is no longer needed.
This check was only needed when this driver supported both DT and non-DT platforms.
Remove the unneeded of_device_get_match_data() NULL check.
--- drivers/tty/serial/imx.c | 3 --- 1 file changed, 3 deletions(-)
drivers/tty/serial/imx.c +0 -3
@@ -2174,9 +2174,6 @@ static int imx_uart_probe_dt(struct imx_port *sport,int ret; sport->devdata =of_device_get_match_data (&pdev->dev); -if (!sport->devdata) -/* no device tree device */ -return 1 ; ret =of_alias_get_id (np,"serial" );if (ret <0 ) {
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 18 lines · Fabio Estevam
Since 5.10-rc1 i.MX is a devicetree-only platform and the NULL check on
of_device_get_match_data()is no longer needed.This check was only needed when this driver supported both DT and non-DT platforms.
Remove the unneeded
of_device_get_match_data()NULL check.Signed-off-by Fabio Estevam <[email protected]>--- drivers/tty/serial/imx.c | 3 --- 1 file changed, 3 deletions(-)drivers/tty/serial/imx.c +0
-0
drivers/tty/serial/imx.c static int imx_uart_probe_dt(struct imx_port *sport, · line 2179
Quoted 6 lines
drivers/tty/serial/imx.c +0
-3@@ -2174,9 +2174,6 @@ static int imx_uart_probe_dt(struct imx_port *sport,int ret; sport->devdata =of_device_get_match_data (&pdev->dev); -if (!sport->devdata) -/* no device tree device */ -return 1 ;
Would it be sensible to fold imx_uart_probe_dt into imx_uart_probe now?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerHi Uwe,
Quoted 1 line · Uwe Kleine-König
Would it be sensible to fold
imx_uart_probe_dtintoimx_uart_probenow?
Yes, that can be done as a separate patch.
Regards,
Fabio Estevam
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel