Skip to contentSkip to conversation

RDMA/mlx5: Fix a error code in devx_umem_reg_cmd_alloc()

PATCH In review Dan Carpenter 2 participants 2 messages Nov 27, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/mlx5: Fix a error code in devx_umem_reg_cmd_alloc()

This code returns PTR_ERR(NULL) which is zero or success but it should return -ENOMEM.

Fixes 878f7b31c3a7 ("RDMA/mlx5: Use ib_umem_find_best_pgsz() for devx")
---
 drivers/infiniband/hw/mlx5/devx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/devx.c +1 -1
index 7c3eefba6197..0b87c74281d3 100644
@@ -2107,7 +2107,7 @@ static int devx_umem_reg_cmd_alloc(struct mlx5_ib_dev *dev,
 		      ib_umem_num_dma_blocks(obj->umem, page_size));
 	cmd->in = uverbs_zalloc(attrs, cmd->inlen);
 	if (!cmd->in)
-		return PTR_ERR(cmd->in);
+		return -ENOMEM;
 
 	umem = MLX5_ADDR_OF(create_umem_in, cmd->in, umem);
 	mtt = (__be64 *)MLX5_ADDR_OF(umem, umem, mtt);
Signature · 1 line
2.29.2
#1 lore raw
Quoted 8 lines · Dan Carpenter

This code returns PTR_ERR(NULL) which is zero or success but it should return -ENOMEM.

Fixes 878f7b31c3a7 ("RDMA/mlx5: Use ib_umem_find_best_pgsz() for devx")
---
 drivers/infiniband/hw/mlx5/devx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Not quite, it is worse, cmd->in is never NULL in the first place

https://lore.kernel.org/linux-rdma/[email protected]/

Jason