x86: tangier: Find proper memory region for relocation
PATCH 1/1 x86: tangier: Find proper memory region for relocation
It appears that U-Boot works by luck on Intel Edison board because the amount of RAM is less than 1 GB and standard way of calculating the top of it work for this configuration. However, this won't work if the amount of RAM is different and split differently in address space. We have to fine the suitable window correctly.
Find proper memory region for relocation by scanning MMAP SFI table in board_get_usable_ram_top() callback.
According to the address map documentation the Main Memory is guaranteed to lie in the 0..2 GB range, that's why we limit search by this range.
--- arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)
arch/x86/cpu/tangier/sdram.c +43 -0
@@ -196,6 +196,49 @@ unsigned int install_e820_map(unsigned int max_entries,return sfi_setup_e820 (max_entries, entries); } +/* +* This function looks for the highest region of memory lower than 2GB which +* has enough space for U-Boot where U-Boot is aligned on a page boundary. It +* overrides the default implementation found elsewhere which simply picks the +* end of RAM, wherever that may be. The location of the stack, the relocation +* address, and how far U-Boot is moved by relocation are set in the global +* data structure. +*/ +ulong board_get_usable_ram_top (ulong total_size) +{ +struct sfi_table_simple *sb; +struct sfi_mem_entry *mentry; +ulong dest_addr =0 ; +u32 i; + + sb =sfi_search_mmap (); +if (!sb) +panic ("No available memory found for relocation" ); + +sfi_for_each_mentry (i, sb, mentry) { +unsigned long long start, end; + +if (mentry->type !=SFI_MEM_CONV ) +continue ; + + start = mentry->phys_start; + end = start + (mentry->pages <<12 ); + +/* Filter memory over 2GB. */ +if (end >0x7fffffffULL ) + end =0x80000000ULL ; +/* Skip this region if it's too small. */ +if (end - start < total_size) +continue ; + +/* Use this address if it's the largest so far. */ +if (end > dest_addr) + dest_addr = end; + } + +return dest_addr; +} +int dram_init_banksize (void ) {sfi_get_bank_size ();
Signature · 1 line
2.29.2
PATCH 1/1 x86: tangier: Find proper memory region for relocation
Quoted 10 lines · Andy Shevchenko
It appears that U-Boot works by luck on Intel Edison board because the amount of RAM is less than 1 GB and standard way of calculating the top of it work for this configuration. However, this won't work if the amount of RAM is different and split differently in address space. We have to fine the suitable window correctly.
Find proper memory region for relocation by scanning MMAP SFI table in
board_get_usable_ram_top()callback.
Quoted 8 lines
According to the address map documentation the Main Memory is guaranteed to lie in the 0..2 GB range, that's why we limit search by this range.
Fixes e71de54a4943 ("x86: Add Intel Tangier support")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)
PATCH 1/1 x86: tangier: Find proper memory region for relocation
Quoted 15 lines · Simon Glass
Quoted 13 lines · Andy Shevchenko
It appears that U-Boot works by luck on Intel Edison board because the amount of RAM is less than 1 GB and standard way of calculating the top of it work for this configuration. However, this won't work if the amount of RAM is different and split differently in address space. We have to fine the suitable window correctly.
Find proper memory region for relocation by scanning MMAP SFI table in
board_get_usable_ram_top()callback.According to the address map documentation the Main Memory is guaranteed to lie in the 0..2 GB range, that's why we limit search by this range.
Quoted 7 lines
Quoted 5 lines
Fixes e71de54a4943 ("x86: Add Intel Tangier support")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)Reviewed-by Simon Glass <[email protected]>
Thanks!
Bin, can we get this, somehow important fix, into v2021.01 release? And any comments about the rest tangier/edison patches?
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 1/1 x86: tangier: Find proper memory region for relocation
Hi Andy,
Quoted 23 lines · Andy Shevchenko
Quoted 21 lines · Simon Glass
Quoted 18 lines · Andy Shevchenko
It appears that U-Boot works by luck on Intel Edison board because the amount of RAM is less than 1 GB and standard way of calculating the top of it work for this configuration. However, this won't work if the amount of RAM is different and split differently in address space. We have to fine the suitable window correctly.
Find proper memory region for relocation by scanning MMAP SFI table in
board_get_usable_ram_top()callback.According to the address map documentation the Main Memory is guaranteed to lie in the 0..2 GB range, that's why we limit search by this range.
Fixes e71de54a4943 ("x86: Add Intel Tangier support")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)
Quoted 7 lines
Quoted 1 line
Reviewed-by Simon Glass <[email protected]>Thanks!
Bin, can we get this, somehow important fix, into v2021.01 release? And any comments about the rest tangier/edison patches?
Sure, I will take a look soon.
Regards,
Bin
PATCH 1/1 x86: tangier: Find proper memory region for relocation
In reply to Andy ShevchenkoQuoted 5 lines · Andy Shevchenko
It appears that U-Boot works by luck on Intel Edison board because the amount of RAM is less than 1 GB and standard way of calculating the top of it work for this configuration. However, this won't work if the amount of RAM is different and split differently in address space. We have to fine the suitable
fine -> find
I can fix this when applying
Quoted 5 lines
window correctly.
Find proper memory region for relocation by scanning MMAP SFI table in
board_get_usable_ram_top()callback.
Quoted 9 lines
According to the address map documentation the Main Memory is guaranteed to lie in the 0..2 GB range, that's why we limit search by this range.
Fixes e71de54a4943 ("x86: Add Intel Tangier support")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)
PATCH 1/1 x86: tangier: Find proper memory region for relocation
Quoted 4 lines · Bin Meng
Quoted 1 line · Andy Shevchenko
Quoted 8 lines
Quoted 4 lines
It appears that U-Boot works by luck on Intel Edison board because the amount of RAM is less than 1 GB and standard way of calculating the top of it work for this configuration. However, this won't work if the amount of RAM is different and split differently in address space. We have to fine the suitable
fine -> find
I can fix this when applying
Fixed this, and
Quoted 9 lines
Quoted 9 lines
window correctly.
Find proper memory region for relocation by scanning MMAP SFI table in
board_get_usable_ram_top()callback.According to the address map documentation the Main Memory is guaranteed to lie in the 0..2 GB range, that's why we limit search by this range.
Quoted 8 lines
Quoted 6 lines
Fixes e71de54a4943 ("x86: Add Intel Tangier support")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/sdram.c | 43 ++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)Reviewed-by Bin Meng <[email protected]>
applied to u-boot-x86, thanks!