sym53c8xx: remove trailing semicolon in macro definition
PATCH 1/1 sym53c8xx: remove trailing semicolon in macro definition
From: Tom Rix <[email protected]>
The macro use will already have a semicolon.
Signed-off-by Tom Rix <[email protected]>
--- drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/sym53c8xx_2/sym_glue.c +2 -2
@@ -1001,12 +1001,12 @@ static int is_keyword(char *ptr, int len, char *verb)#define SKIP_SPACES (ptr, len) \ if ((arg_len = sym_skip_spaces(ptr, len)) < 1) \ return -EINVAL; \ - ptr += arg_len; len -= arg_len; + ptr += arg_len; len -= arg_len#define GET_INT_ARG (ptr, len, v) \ if (!(arg_len = get_int_arg(ptr, len, &(v)))) \ return -EINVAL; \ - ptr += arg_len; len -= arg_len; + ptr += arg_len; len -= arg_len/*
Signature · 1 line
2.18.4
Quoted 31 lines · On Fri, 2020-11-27 at 10:29 -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
The macro use will already have a semicolon.
Signed-off-by Tom Rix <[email protected]>--- drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/scsi/sym53c8xx_2/sym_glue.c +1
-1@@ -1001,12 +1001,12 @@ static int is_keyword(char *ptr, int len, char *verb)#define SKIP_SPACES (ptr, len) \ if ((arg_len = sym_skip_spaces(ptr, len)) < 1) \return -EINVAL ; \ - ptr += arg_len; len -= arg_len; + ptr += arg_len; len -= arg_len#define GET_INT_ARG (ptr, len, v) \ if (!(arg_len = get_int_arg(ptr, len, &(v))))\
return-EINVAL;
\
drivers/scsi/sym53c8xx_2/sym_glue.c
Quoted 2 lines
drivers/scsi/sym53c8xx_2/sym_glue.c +1
-1- ptr += arg_len; len -= arg_len; + ptr += arg_len; len -= arg_len
Those macros have the wrong form which can lead to actual bugs and this cosmetic change does nothing to fix it. If the goal here is to get the code base into better shape, please fix the bugs.
James