Skip to contentSkip to conversation

menuconfig,mconf-cfg: Allow specification of ncurses location

PATCH In review Scott Branden 3 participants 6 messages Nov 28, 2020 – Dec 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 menuconfig,mconf-cfg: Allow specification of ncurses location

From: Bruce Ashfield <[email protected]>

In some cross build environments such as the Yocto Project build environment it provides an ncurses library that is compiled differently than the host's version. This causes display corruption problems when the host's curses includes are used instead of the includes from the provided compiler are overridden. There is a second case where there is no curses libraries at all on the host system and menuconfig will just fail entirely.

The solution is simply to allow an override variable in check-lxdialog.sh for environments such as the Yocto Project. Adding a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing compiling and linking against the right headers and libraries.

---
 scripts/kconfig/mconf-cfg.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
 mode change 100755 => 100644 scripts/kconfig/mconf-cfg.sh
scripts/kconfig/mconf-cfg.sh +8 -0
old mode 100755
new mode 100644
index aa68ec95620d..32448bc198a5
@@ -4,6 +4,14 @@
 PKG="ncursesw"
 PKG2="ncurses"
 
+if [ "$CROSS_CURSES_LIB" != "" ]; then
+    echo libs=\'$CROSS_CURSES_LIB\'
+    if [ x"$CROSS_CURSES_INC" != x ]; then
+	echo cflags=\'$CROSS_CURSES_INC\'
+    fi
+    exit 0
+fi
+
 if [ -n "$(command -v pkg-config)" ]; then
 	if pkg-config --exists $PKG; then
 		echo cflags=\"$(pkg-config --cflags $PKG)\"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 16 lines · Scott Branden

From: Bruce Ashfield <[email protected]>

In some cross build environments such as the Yocto Project build environment it provides an ncurses library that is compiled differently than the host's version. This causes display corruption problems when the host's curses includes are used instead of the includes from the provided compiler are overridden. There is a second case where there is no curses libraries at all on the host system and menuconfig will just fail entirely.

The solution is simply to allow an override variable in check-lxdialog.sh for environments such as the Yocto Project. Adding a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing compiling and linking against the right headers and libraries.

Quoted 6 lines

---

Some people solve the cross-compiling in Yocto
by using pkg-config.

For example,

commit 067c650c456e758f933aaf87a202f841d34be269

Author: Pavel Modilaynen <[email protected]>
Date:   Fri Jul 12 13:52:19 2019 +0200

dtc: Use pkg-config to locate libyaml

Using Makefile's wildcard with absolute path to detect the presence of libyaml results in false-positive detection when cross-compiling e.g. in yocto environment.

mconf-cfg.sh already allows the path flexibility with pkg-config. Why do you want yet another hook?

Quoted 28 lines
 scripts/kconfig/mconf-cfg.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
 mode change 100755 => 100644 scripts/kconfig/mconf-cfg.sh
scripts/kconfig/mconf-cfg.sh +8 -1
old mode 100755
new mode 100644
index aa68ec95620d..32448bc198a5
@@ -4,6 +4,14 @@
 PKG="ncursesw"
 PKG2="ncurses"
 
+if [ "$CROSS_CURSES_LIB" != "" ]; then
+    echo libs=\'$CROSS_CURSES_LIB\'
+    if [ x"$CROSS_CURSES_INC" != x ]; then
+       echo cflags=\'$CROSS_CURSES_INC\'
+    fi
+    exit 0
+fi
+
 if [ -n "$(command -v pkg-config)" ]; then
        if pkg-config --exists $PKG; then
                echo cflags=\"$(pkg-config --cflags $PKG)\"
--

2.17.1

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw

Hi Masahiro,

Quoted 36 lines · Masahiro Yamada
Quoted 15 lines · Scott Branden

From: Bruce Ashfield <[email protected]>

In some cross build environments such as the Yocto Project build environment it provides an ncurses library that is compiled differently than the host's version. This causes display corruption problems when the host's curses includes are used instead of the includes from the provided compiler are overridden. There is a second case where there is no curses libraries at all on the host system and menuconfig will just fail entirely.

The solution is simply to allow an override variable in check-lxdialog.sh for environments such as the Yocto Project. Adding a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing compiling and linking against the right headers and libraries.

Quoted 6 lines

---

Some people solve the cross-compiling in Yocto
by using pkg-config.

For example,

commit 067c650c456e758f933aaf87a202f841d34be269

Author: Pavel Modilaynen <[email protected]>
Date:   Fri Jul 12 13:52:19 2019 +0200

dtc: Use pkg-config to locate libyaml

Quoted 8 lines

Using Makefile's wildcard with absolute path to detect the presence of libyaml results in false-positive detection when cross-compiling e.g. in yocto environment.

mconf-cfg.sh already allows the path flexibility with pkg-config. Why do you want yet another hook?

I hope the yocto community can provide more details on this patch.
The yocto environment isolates the build environment from the host tools.
Running menuconfig with the upstream kernel does not work on the latest yocto without this patch.

Quoted 29 lines
Quoted 28 lines
 scripts/kconfig/mconf-cfg.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
 mode change 100755 => 100644 scripts/kconfig/mconf-cfg.sh
scripts/kconfig/mconf-cfg.sh +8 -1
old mode 100755
new mode 100644
index aa68ec95620d..32448bc198a5
@@ -4,6 +4,14 @@
 PKG="ncursesw"
 PKG2="ncurses"
 
+if [ "$CROSS_CURSES_LIB" != "" ]; then
+    echo libs=\'$CROSS_CURSES_LIB\'
+    if [ x"$CROSS_CURSES_INC" != x ]; then
+       echo cflags=\'$CROSS_CURSES_INC\'
+    fi
+    exit 0
+fi
+
 if [ -n "$(command -v pkg-config)" ]; then
        if pkg-config --exists $PKG; then
                echo cflags=\"$(pkg-config --cflags $PKG)\"
--

2.17.1

#3 lore raw
Quoted 46 lines · Scott Branden

Hi Masahiro,

Quoted 42 lines · Masahiro Yamada
Quoted 15 lines · Scott Branden

From: Bruce Ashfield <[email protected]>

In some cross build environments such as the Yocto Project build environment it provides an ncurses library that is compiled differently than the host's version. This causes display corruption problems when the host's curses includes are used instead of the includes from the provided compiler are overridden. There is a second case where there is no curses libraries at all on the host system and menuconfig will just fail entirely.

The solution is simply to allow an override variable in check-lxdialog.sh for environments such as the Yocto Project. Adding a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing compiling and linking against the right headers and libraries.

Quoted 6 lines

---

Some people solve the cross-compiling in Yocto
by using pkg-config.

For example,

commit 067c650c456e758f933aaf87a202f841d34be269

Author: Pavel Modilaynen <[email protected]>
Date:   Fri Jul 12 13:52:19 2019 +0200

dtc: Use pkg-config to locate libyaml

Using Makefile's wildcard with absolute path to detect the presence of libyaml results in false-positive detection when cross-compiling e.g. in yocto environment.

Quoted 5 lines
Quoted 2 lines

mconf-cfg.sh already allows the path flexibility with pkg-config. Why do you want yet another hook?

I hope the yocto community can provide more details on this patch.
The yocto environment isolates the build environment from the host tools.
Running menuconfig with the upstream kernel does not work on the latest yocto without this patch.

Sorry for not commenting on the origin patch, gmail buried it within some other threads, but luckily this one popped up.

It is true that we've been carrying this for several years to deal with the fact that the native sysroot is not searched by the pkg-config called by mconf-cfg.sh (since it is separate from host and target pkg-config).

As it turns out, in the past few weeks, we have come up with a way to inject those native sysroot components into pkg-config without the need for any changes to the scripts.

Scott: if you try again the the latest oe-core, and are still seeing the problem with the mainline kernel, ping me, and we can see if the pkg-config fix isn't holding for you, at that point, yes, we may still need a hook like this to solve the problem.

Cheers,

Bruce

Quoted 30 lines
Quoted 29 lines
Quoted 28 lines
 scripts/kconfig/mconf-cfg.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
 mode change 100755 => 100644 scripts/kconfig/mconf-cfg.sh
scripts/kconfig/mconf-cfg.sh +8 -1
old mode 100755
new mode 100644
index aa68ec95620d..32448bc198a5
@@ -4,6 +4,14 @@
 PKG="ncursesw"
 PKG2="ncurses"
 
+if [ "$CROSS_CURSES_LIB" != "" ]; then
+    echo libs=\'$CROSS_CURSES_LIB\'
+    if [ x"$CROSS_CURSES_INC" != x ]; then
+       echo cflags=\'$CROSS_CURSES_INC\'
+    fi
+    exit 0
+fi
+
 if [ -n "$(command -v pkg-config)" ]; then
        if pkg-config --exists $PKG; then
                echo cflags=\"$(pkg-config --cflags $PKG)\"
--

2.17.1

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#4 lore raw

Hi Bruce,

Quoted 59 lines · Bruce Ashfield
Quoted 44 lines · Scott Branden

Hi Masahiro,

Quoted 41 lines · Masahiro Yamada
Quoted 15 lines · Scott Branden

From: Bruce Ashfield <[email protected]>

In some cross build environments such as the Yocto Project build environment it provides an ncurses library that is compiled differently than the host's version. This causes display corruption problems when the host's curses includes are used instead of the includes from the provided compiler are overridden. There is a second case where there is no curses libraries at all on the host system and menuconfig will just fail entirely.

The solution is simply to allow an override variable in check-lxdialog.sh for environments such as the Yocto Project. Adding a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing compiling and linking against the right headers and libraries.

Quoted 6 lines

---

Some people solve the cross-compiling in Yocto
by using pkg-config.

For example,

commit 067c650c456e758f933aaf87a202f841d34be269

Author: Pavel Modilaynen <[email protected]>
Date:   Fri Jul 12 13:52:19 2019 +0200

dtc: Use pkg-config to locate libyaml

Using Makefile's wildcard with absolute path to detect the presence of libyaml results in false-positive detection when cross-compiling e.g. in yocto environment.

Quoted 5 lines
Quoted 2 lines

mconf-cfg.sh already allows the path flexibility with pkg-config. Why do you want yet another hook?

I hope the yocto community can provide more details on this patch.
The yocto environment isolates the build environment from the host tools.
Running menuconfig with the upstream kernel does not work on the latest yocto without this patch.

Sorry for not commenting on the origin patch, gmail buried it within some other threads, but luckily this one popped up.

It is true that we've been carrying this for several years to deal with the fact that the native sysroot is not searched by the pkg-config called by mconf-cfg.sh (since it is separate from host and target pkg-config).

Quoted 8 lines

As it turns out, in the past few weeks, we have come up with a way to inject those native sysroot components into pkg-config without the need for any changes to the scripts.

Scott: if you try again the the latest oe-core, and are still seeing the problem with the mainline kernel, ping me, and we can see if the pkg-config fix isn't holding for you, at that point, yes, we may still need a hook like this to solve the problem.

Try reverting this kernel patch from linux-yocto and menuconfig will fail.

menuconfig actually did work with the upstream kernel until the yocto change below was introduced:
"cml1.bbclass: Handle ncurses-native being available via pkg-config"
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=master-next&id=ce447d70df386ca55ce1672478b245851556374e

Quoted 35 lines

Cheers,

Bruce

Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
 scripts/kconfig/mconf-cfg.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
 mode change 100755 => 100644 scripts/kconfig/mconf-cfg.sh
scripts/kconfig/mconf-cfg.sh +8 -1
old mode 100755
new mode 100644
index aa68ec95620d..32448bc198a5
@@ -4,6 +4,14 @@
 PKG="ncursesw"
 PKG2="ncurses"
 
+if [ "$CROSS_CURSES_LIB" != "" ]; then
+    echo libs=\'$CROSS_CURSES_LIB\'
+    if [ x"$CROSS_CURSES_INC" != x ]; then
+       echo cflags=\'$CROSS_CURSES_INC\'
+    fi
+    exit 0
+fi
+
 if [ -n "$(command -v pkg-config)" ]; then
        if pkg-config --exists $PKG; then
                echo cflags=\"$(pkg-config --cflags $PKG)\"
--

2.17.1

#5 lore raw
Quoted 68 lines · Scott Branden

Hi Bruce,

Quoted 46 lines · Bruce Ashfield
Quoted 44 lines · Scott Branden

Hi Masahiro,

Quoted 41 lines · Masahiro Yamada
Quoted 15 lines · Scott Branden

From: Bruce Ashfield <[email protected]>

In some cross build environments such as the Yocto Project build environment it provides an ncurses library that is compiled differently than the host's version. This causes display corruption problems when the host's curses includes are used instead of the includes from the provided compiler are overridden. There is a second case where there is no curses libraries at all on the host system and menuconfig will just fail entirely.

The solution is simply to allow an override variable in check-lxdialog.sh for environments such as the Yocto Project. Adding a CROSS_CURSES_LIB and CROSS_CURSES_INC solves the issue and allowing compiling and linking against the right headers and libraries.

Quoted 6 lines

---

Some people solve the cross-compiling in Yocto
by using pkg-config.

For example,

commit 067c650c456e758f933aaf87a202f841d34be269

Author: Pavel Modilaynen <[email protected]>
Date:   Fri Jul 12 13:52:19 2019 +0200

dtc: Use pkg-config to locate libyaml

Using Makefile's wildcard with absolute path to detect the presence of libyaml results in false-positive detection when cross-compiling e.g. in yocto environment.

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

mconf-cfg.sh already allows the path flexibility with pkg-config. Why do you want yet another hook?

I hope the yocto community can provide more details on this patch. The yocto environment isolates the build environment from the host

tools.

Quoted 1 line
Quoted 1 line

Running menuconfig with the upstream kernel does not work on the latest

yocto without this patch.

Quoted 12 lines

Sorry for not commenting on the origin patch, gmail buried it within some other threads, but luckily this one popped up.

It is true that we've been carrying this for several years to deal with the fact that the native sysroot is not searched by the pkg-config called by mconf-cfg.sh (since it is separate from host and target pkg-config).

As it turns out, in the past few weeks, we have come up with a way to inject those native sysroot components into pkg-config without the need for any changes to the scripts.

Quoted 6 lines
Quoted 4 lines

Scott: if you try again the the latest oe-core, and are still seeing the problem with the mainline kernel, ping me, and we can see if the pkg-config fix isn't holding for you, at that point, yes, we may still need a hook like this to solve the problem.

Try reverting this kernel patch from linux-yocto and menuconfig will fail.

s/this/your/ ?

I'm continuing to carry it, since that tree is part of more than just yocto builds so
it is needed for other reasons as well.

Quoted 7 lines

menuconfig actually did work with the upstream kernel until the yocto change below was introduced:
"cml1.bbclass: Handle ncurses-native being available via pkg-config"

https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=master-next&id=ce447d70df386ca55ce1672478b245851556374e

That's the one I was referring to.

You need to take that up with the submitter of that change, since it has broken
your workflow.

My change will indeed fix (mask) it, but considering that commit claims to solve
the same problem, it should be root caused on the oe core mailing list.

Bruce

Quoted 38 lines
Quoted 11 lines

Cheers,

Bruce

Quoted 5 lines
Quoted 5 lines

Review

Quoted 5 lines
 scripts/kconfig/mconf-cfg.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
 mode change 100755 => 100644 scripts/kconfig/mconf-cfg.sh
(quoted diff) +0 -0

b/scripts/kconfig/mconf-cfg.sh

Quoted 24 lines
Quoted 23 lines
Quoted 23 lines
Quoted 23 lines

old mode 100755
new mode 100644
index aa68ec95620d..32448bc198a5

scripts/kconfig/mconf-cfg.sh +8 -1
@@ -4,6 +4,14 @@
 PKG="ncursesw"
 PKG2="ncurses"
 
+if [ "$CROSS_CURSES_LIB" != "" ]; then
+    echo libs=\'$CROSS_CURSES_LIB\'
+    if [ x"$CROSS_CURSES_INC" != x ]; then
+       echo cflags=\'$CROSS_CURSES_INC\'
+    fi
+    exit 0
+fi
+
 if [ -n "$(command -v pkg-config)" ]; then
        if pkg-config --exists $PKG; then
                echo cflags=\"$(pkg-config --cflags $PKG)\"
--

2.17.1

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II