iio: fix warnings about passing signed values to %u
Jonathan Cameron
maintainerPATCH 1/1 iio: fix warnings about passing signed values to %u
From: Jonathan Cameron <[email protected]>
In reality, we already know both of these values are positive but it is still better to make that explicit at the point of use with abs().
Signed-off-by Jonathan Cameron <[email protected]>
Reported-by kernel test robot <[email protected]>
--- drivers/iio/industrialio-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/industrialio-core.c +2 -2
@@ -608,14 +608,14 @@ static ssize_t __iio_format_value(char *buf, size_t len, unsigned int type,return scnprintf (buf, len,"-%d.%06u%s" ,abs (vals[0 ]), -vals[1 ], scale_db ?" dB" :"" ); else - return scnprintf(buf, len, "%d.%06u%s", vals[0], vals[1], + return scnprintf(buf, len, "%d.%06u%s", vals[0], abs(vals[1]), scale_db ?" dB" :"" );case IIO_VAL_INT_PLUS_NANO :if (vals[1 ] <0 )return scnprintf (buf, len,"-%d.%09u" ,abs (vals[0 ]), -vals[1 ]);else -return scnprintf (buf, len,"%d.%09u" , vals[0 ], vals[1 ]); +return scnprintf (buf, len,"%d.%09u" , vals[0 ],abs (vals[1 ]));case IIO_VAL_FRACTIONAL : tmp2 =div_s64 ((s64 )vals[0 ] *1000000000LL , vals[1 ]); tmp1 = vals[1 ];
Signature · 1 line
2.29.2
Quoted 8 lines · On Sat, 28 Nov 2020 15:56:48 +0000 Jonathan Cameron <[email protected]> wrote:
From: Jonathan Cameron <[email protected]>
In reality, we already know both of these values are positive but it is still better to make that explicit at the point of use with
abs().Signed-off-by Jonathan Cameron <[email protected]>Reported-by kernel test robot <[email protected]>
Maintainers curse. If someone could sanity check this that would be great. I never trust myself not to do anything stupid :)
Jonathan
Quoted 25 lines
--- drivers/iio/industrialio-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/industrialio-core.c +2
-2@@ -608,14 +608,14 @@ static ssize_t __iio_format_value(char *buf, size_t len, unsigned int type,return scnprintf (buf, len,"-%d.%06u%s" ,abs (vals[0 ]), -vals[1 ], scale_db ?" dB" :"" ); else - return scnprintf(buf, len, "%d.%06u%s", vals[0], vals[1], + return scnprintf(buf, len, "%d.%06u%s", vals[0], abs(vals[1]), scale_db ?" dB" :"" );case IIO_VAL_INT_PLUS_NANO :if (vals[1 ] <0 )return scnprintf (buf, len,"-%d.%09u" ,abs (vals[0 ]), -vals[1 ]);else -return scnprintf (buf, len,"%d.%09u" , vals[0 ], vals[1 ]); +return scnprintf (buf, len,"%d.%09u" , vals[0 ],abs (vals[1 ]));case IIO_VAL_FRACTIONAL : tmp2 =div_s64 ((s64 )vals[0 ] *1000000000LL , vals[1 ]); tmp1 = vals[1 ];