Skip to contentSkip to conversation

iio:health:afe4403: Fix naming of tx supply to match dt-bindings

PATCH In review Jonathan Cameron 1 participant 3 messages Nov 28, 2020 – Feb 21, 2021 IIO

lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/2 iio:health:afe4403: Fix naming of tx supply to match dt-bindings

From: Jonathan Cameron <[email protected]>

These have always been different and the name tx_sup-supply that would work for the driver is rather nonsensical so let us go with what was described in the dt-binding doc.

Fixes eec96d1e2d318 ("iio: health: Add driver for the TI AFE4403 heart monitor")
---
 drivers/iio/health/afe4403.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/health/afe4403.c +1 -1
index 38734e4ce360..94bbfc065bed 100644
@@ -486,7 +486,7 @@ static int afe4403_probe(struct spi_device *spi)
 		}
 	}
 
-	afe->regulator = devm_regulator_get(afe->dev, "tx_sup");
+	afe->regulator = devm_regulator_get(afe->dev, "tx");
 	if (IS_ERR(afe->regulator)) {
 		dev_err(afe->dev, "Unable to get regulator\n");
 		return PTR_ERR(afe->regulator);
Signature · 1 line
2.29.2
author maintainer
#1 lore raw

PATCH 2/2 iio:health:afe4404: Fix naming of tx supply to match dt-bindings

From: Jonathan Cameron <[email protected]>

This has always been inconsistent. The binding naming is better so lets us standardise on that.

Fixes 87aec56e27ef ("iio: health: Add driver for the TI AFE4404 heart monitor")
---
 drivers/iio/health/afe4404.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/health/afe4404.c +1 -1
index 61fe4932d81d..95547864fe8e 100644
@@ -493,7 +493,7 @@ static int afe4404_probe(struct i2c_client *client,
 		}
 	}
 
-	afe->regulator = devm_regulator_get(afe->dev, "tx_sup");
+	afe->regulator = devm_regulator_get(afe->dev, "tx");
 	if (IS_ERR(afe->regulator)) {
 		dev_err(afe->dev, "Unable to get regulator\n");
 		return PTR_ERR(afe->regulator);
Signature · 1 line
2.29.2
author maintainer
#2 lore raw
In reply to Jonathan Cameron
Quoted 8 lines · On Sat, 28 Nov 2020 16:23:33 +0000 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

These have always been different and the name tx_sup-supply that would work for the driver is rather nonsensical so let us go with what was described in the dt-binding doc.

Fixes eec96d1e2d318 ("iio: health: Add driver for the TI AFE4403 heart monitor")

Another old series that I could do with a sanity check / review on.

Thanks,

Jonathan

Quoted 17 lines
---
 drivers/iio/health/afe4403.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/health/afe4403.c +1 -1
index 38734e4ce360..94bbfc065bed 100644
@@ -486,7 +486,7 @@ static int afe4403_probe(struct spi_device *spi)
 		}
 	}
 
-	afe->regulator = devm_regulator_get(afe->dev, "tx_sup");
+	afe->regulator = devm_regulator_get(afe->dev, "tx");
 	if (IS_ERR(afe->regulator)) {
 		dev_err(afe->dev, "Unable to get regulator\n");
 		return PTR_ERR(afe->regulator);