Skip to contentSkip to conversation

ell: add missing include in dhcp-server.

PATCH Superseded Érico Nogueira 2 participants 2 messages Nov 30, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ell: add missing include in dhcp-server.

From: Érico Rolim <[email protected]>

---

I would prefer adding #include <linux/types> directly in dhcp-private.h, but this patch follows the current style.

 ell/dhcp-server.c | 1 +
 1 file changed, 1 insertion(+)
ell/dhcp-server.c +1 -0
index c983ed4..144e83e 100644
@@ -24,6 +24,7 @@
 #include <config.h>
 #endif
 
+#include <linux/types.h>
 #include <net/ethernet.h>
 #include <sys/socket.h>
 #include <arpa/inet.h>
Signature · 1 line
2.29.2
#1 lore raw

Hi Érico,

Quoted 3 lines

I would prefer adding #include <linux/types> directly in dhcp-private.h, but this patch follows the current style.

We prefer to not have #includes in -private.h files. So the way you have it is correct.

Quoted 4 lines
  ell/dhcp-server.c | 1 +
  1 file changed, 1 insertion(+)

Note that the patch seems to come through MIME encoded and doesn't apply via 'git am'.

Regards,
-Denis