Skip to contentSkip to conversation

drm: panel: add flags to BOE NV110WTM-N61

PATCH In review Sam Ravnborg 2 participants 4 messages Nov 30, 2020 – Dec 1, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: panel: add flags to BOE NV110WTM-N61

When applying a patch to add the BOE NV110WTM-N61 panel I forgot to add the changes that added flags to drm_display_mode.

Fixes a96ee0f6b58d ("drm: panel: simple: Add BOE NV110WTM-N61")
Cc Douglas Anderson <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 216cde33b5c4..2d093b5a513c 100644
@@ -1367,6 +1367,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
 		.vsync_start = 800 + 3,
 		.vsync_end = 800 + 3 + 5,
 		.vtotal = 800 + 3 + 5 + 24,
+		.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
 	},
 	{
 		.clock = 57500,
@@ -1378,6 +1379,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
 		.vsync_start = 800 + 3,
 		.vsync_end = 800 + 3 + 5,
 		.vtotal = 800 + 3 + 5 + 24,
+		.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
 	},
 };
 
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Hi,

Quoted 3 lines · Sam Ravnborg

When applying a patch to add the BOE NV110WTM-N61 panel I forgot to add the changes that added flags to drm_display_mode.

Sorry, I didn't mean to make more work for you!

Quoted 23 lines
Fixes a96ee0f6b58d ("drm: panel: simple: Add BOE NV110WTM-N61")
Cc Douglas Anderson <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +1 -0
index 216cde33b5c4..2d093b5a513c 100644
@@ -1367,6 +1367,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
                .vsync_start = 800 + 3,
                .vsync_end = 800 + 3 + 5,
                .vtotal = 800 + 3 + 5 + 24,
+               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
        },
        {
                .clock = 57500,

drivers/gpu/drm/panel/panel-simple.c static const struct drm_display_mode boe_nv101wxmn51_modes[] = { · line 1382

Quoted 4 lines
drivers/gpu/drm/panel/panel-simple.c +1 -0
@@ -1378,6 +1379,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
                .vsync_start = 800 + 3,
                .vsync_end = 800 + 3 + 5,
                .vtotal = 800 + 3 + 5 + 24,
+               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,

I think you're off by 10 and a letter.

The subject talks about:
NV110WTM-N61

You're modifying the structs for:
NV101WXM-N51

I'm happy to post this if it's helpful to you, or I can review a v2 from you. :-)

-Doug
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw

Hi Doug,

Quoted 40 lines · Doug Anderson

Hi,

Quoted 3 lines · Sam Ravnborg

When applying a patch to add the BOE NV110WTM-N61 panel I forgot to add the changes that added flags to drm_display_mode.

Sorry, I didn't mean to make more work for you!

Quoted 23 lines
Fixes a96ee0f6b58d ("drm: panel: simple: Add BOE NV110WTM-N61")
Cc Douglas Anderson <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +1 -0
index 216cde33b5c4..2d093b5a513c 100644
@@ -1367,6 +1367,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
                .vsync_start = 800 + 3,
                .vsync_end = 800 + 3 + 5,
                .vtotal = 800 + 3 + 5 + 24,
+               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
        },
        {
                .clock = 57500,

drivers/gpu/drm/panel/panel-simple.c static const struct drm_display_mode boe_nv101wxmn51_modes[] = { · line 1382

Quoted 4 lines
drivers/gpu/drm/panel/panel-simple.c +1 -0
@@ -1378,6 +1379,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
                .vsync_start = 800 + 3,
                .vsync_end = 800 + 3 + 5,
                .vtotal = 800 + 3 + 5 + 24,
+               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,

I think you're off by 10 and a letter.

Quoted 8 lines

The subject talks about:
NV110WTM-N61

You're modifying the structs for:
NV101WXM-N51

I'm happy to post this if it's helpful to you, or I can review a v2 from you. :-)

Please do so, that would be very nice.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Hi,

Quoted 47 lines · Sam Ravnborg

Hi Doug,

Quoted 43 lines · Doug Anderson

Hi,

Quoted 3 lines · Sam Ravnborg

When applying a patch to add the BOE NV110WTM-N61 panel I forgot to add the changes that added flags to drm_display_mode.

Sorry, I didn't mean to make more work for you!

Quoted 23 lines
Fixes a96ee0f6b58d ("drm: panel: simple: Add BOE NV110WTM-N61")
Cc Douglas Anderson <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +1 -0
index 216cde33b5c4..2d093b5a513c 100644
@@ -1367,6 +1367,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
                .vsync_start = 800 + 3,
                .vsync_end = 800 + 3 + 5,
                .vtotal = 800 + 3 + 5 + 24,
+               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
        },
        {
                .clock = 57500,

drivers/gpu/drm/panel/panel-simple.c static const struct drm_display_mode boe_nv101wxmn51_modes[] = { · line 1382

Quoted 4 lines
drivers/gpu/drm/panel/panel-simple.c +1 -0
@@ -1378,6 +1379,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
                .vsync_start = 800 + 3,
                .vsync_end = 800 + 3 + 5,
                .vtotal = 800 + 3 + 5 + 24,
+               .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,

I think you're off by 10 and a letter.

The subject talks about:
NV110WTM-N61

Quoted 6 lines
Quoted 5 lines

You're modifying the structs for:
NV101WXM-N51

I'm happy to post this if it's helpful to you, or I can review a v2 from you. :-)

Please do so, that would be very nice.

Breadcrumbs: this can be found at:

https://lore.kernel.org/r/20201201125554.v2.1.I8a7bfc0966e803ab91001c9e6d01a736950c4981@changeid

-Doug
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel