Staging: rtl8723bs/core: Add blank line after variable declaration.
Subsystems (2)
PATCH 1/1 Staging: rtl8723bs/core: Add blank line after variable declaration.
Fix the checkpatch.pl warning:
rtw_security.c:2374: WARNING: Missing a blank line after declarations
--- drivers/staging/rtl8723bs/core/rtw_security.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/rtl8723bs/core/rtw_security.c +1 -0
@@ -2371,6 +2371,7 @@ u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller)if (securitypriv->btkip_countermeasure) {unsigned long passing_ms =jiffies_to_msecs (jiffies - securitypriv->btkip_countermeasure_time); +if (passing_ms >60 *1000 ) {DBG_871X_LEVEL (_drv_always_,"%s(" ADPT_FMT ") countermeasure time:%lus > 60s\n" , caller,ADPT_ARG (adapter), passing_ms/1000 );
Signature · 1 line
2.25.1
Hi Matthew,
Someone already sent this patch a month back. You should work against linux-next so that you have the latest code. Also kernel janitors doesn't apply patches. Send patches to the output from scripts/get_maintainer.pl
Otherwise it looks fine though and Greg would have applied it if he hadn't already applied someone else's.
regards,
dan carpenter
PATCH 1/1 Staging: rtl8723bs/core: Add blank line after variable declarations.
In reply to Brother Matthew De AngelisFix the checkpatch.pl warning:
rtw_security.c:2374: WARNING: Missing a blank line after declarations
--- drivers/staging/rtl8723bs/core/rtw_security.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/rtl8723bs/core/rtw_security.c +1 -0
@@ -2371,6 +2371,7 @@ u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller)if (securitypriv->btkip_countermeasure) {unsigned long passing_ms =jiffies_to_msecs (jiffies - securitypriv->btkip_countermeasure_time); +if (passing_ms >60 *1000 ) {DBG_871X_LEVEL (_drv_always_,"%s(" ADPT_FMT ") countermeasure time:%lus > 60s\n" , caller,ADPT_ARG (adapter), passing_ms/1000 );
Signature · 8 lines
2.25.1 Hello kernel janitors, this is my third patch and I don't feel very confident yet. Would this patch be worth Greg's time? Thanks! Br. Matt
Re: [PATCH] Staging: rtl8723bs/core: Add blank line after variable declarations.
In reply to Brother Matthew De AngelisQuoted 28 lines · Brother Matthew De Angelis
Fix the checkpatch.pl warning:
rtw_security.c:2374: WARNING: Missing a blank line after declarations
Signed-off-by Brother Matthew De Angelis <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_security.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/rtl8723bs/core/rtw_security.c +1
-0@@ -2371,6 +2371,7 @@ u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller)if (securitypriv->btkip_countermeasure) {unsigned long passing_ms =jiffies_to_msecs (jiffies - securitypriv->btkip_countermeasure_time); +if (passing_ms >60 *1000 ) {DBG_871X_LEVEL (_drv_always_,"%s(" ADPT_FMT ") countermeasure time:%lus > 60s\n" , caller,ADPT_ARG (adapter), passing_ms/1000 );Signature · 5 lines
2.25.1 Hello kernel janitors, this is my third patch and I don't feel very confident yet. Would this patch be worth Greg's time?
I already replied about this patch earlier. Someone already sent it so it's not needed.
These patches take about 15 seconds of Greg's time and he deliberately leaves checkpatch warnings like this for people to practice sending him patches.
regards,
dan carpenter