scsi: ufs: Remove pre-defined initial voltage values of device powers
Subsystems (2)
PATCH v2 1/1 scsi: ufs: Remove pre-defined initial voltage values of device powers
UFS specficication allows different VCC configurations for UFS devices, for example,
(1). 2.70V - 3.60V (Activated by default in UFS core driver)
(2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in
device tree)
(3). 2.40V - 2.70V (Supported since UFS 3.x)With the introduction of UFS 3.x products, an issue is happening that UFS driver will use wrong "min_uV-max_uV" values to configure the voltage of VCC regulator on UFU 3.x products with the configuration (3) used.
To solve this issue, we simply remove pre-defined initial VCC voltage values in UFS core driver with below reasons,
1. UFS specifications do not define how to detect the VCC configuration supported by attached device.
2. Device tree already supports standard regulator properties.
Therefore VCC voltage shall be defined correctly in device tree, and shall not changed by UFS driver. What UFS driver needs to do is simply enable or disable the VCC regulator only.
Similar change is applied to VCCQ and VCCQ2 as well.
Note that we keep struct ufs_vreg unchanged. This is allow vendors to configure proper min_uV and max_uV of any regulators to make regulator_set_voltage() works during regulator toggling flow. Without specific vendor configurations, min_uV and max_uV will be NULL by default and UFS core driver will enable or disable the regulator only without adjusting its voltage.
--- drivers/scsi/ufs/ufshcd-pltfrm.c | 16 ---------------- 1 file changed, 16 deletions(-)
drivers/scsi/ufs/ufshcd-pltfrm.c +0 -16
@@ -133,22 +133,6 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, vreg->max_uA =0 ; } -if (!strcmp (name,"vcc" )) { -if (of_property_read_bool (np,"vcc-supply-1p8" )) { - vreg->min_uV =UFS_VREG_VCC_1P8_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_1P8_MAX_UV ; - }else { - vreg->min_uV =UFS_VREG_VCC_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_MAX_UV ; - } - }else if (!strcmp (name,"vccq" )) { - vreg->min_uV =UFS_VREG_VCCQ_MIN_UV ; - vreg->max_uV =UFS_VREG_VCCQ_MAX_UV ; - }else if (!strcmp (name,"vccq2" )) { - vreg->min_uV =UFS_VREG_VCCQ2_MIN_UV ; - vreg->max_uV =UFS_VREG_VCCQ2_MAX_UV ; - } - goto out; out:
Signature · 1 line
2.18.0
Quoted 34 lines
UFS specficication allows different VCC configurations for UFS devices, for example,
(1). 2.70V - 3.60V (Activated by default in UFS core driver) (2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in device tree) (3). 2.40V - 2.70V (Supported since UFS 3.x)With the introduction of UFS 3.x products, an issue is happening that UFS driver will use wrong "min_uV-max_uV" values to configure the voltage of VCC regulator on UFU 3.x products with the configuration (3) used.
To solve this issue, we simply remove pre-defined initial VCC voltage values in UFS core driver with below reasons,
1. UFS specifications do not define how to detect the VCC configuration supported by attached device.
2. Device tree already supports standard regulator properties.
Therefore VCC voltage shall be defined correctly in device tree, and shall not changed by UFS driver. What UFS driver needs to do is simply enable or disable the VCC regulator only.
Similar change is applied to VCCQ and VCCQ2 as well.
Note that we keep struct
ufs_vregunchanged. This is allow vendors to configure propermin_uVandmax_uVof any regulators to makeregulator_set_voltage()works during regulator toggling flow. Without specific vendor configurations,min_uVandmax_uVwill be NULL by default and UFS core driver will enable or disable the regulator only without adjusting its voltage.
Quoted 2 lines
Reviewed-by Bjorn Andersson <[email protected]>Signed-off-by Stanley Chu <[email protected]>
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 33 lines · Stanley Chu
UFS specficication allows different VCC configurations for UFS devices, for example,
(1). 2.70V - 3.60V (Activated by default in UFS core driver) (2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in device tree) (3). 2.40V - 2.70V (Supported since UFS 3.x)With the introduction of UFS 3.x products, an issue is happening that UFS driver will use wrong "min_uV-max_uV" values to configure the voltage of VCC regulator on UFU 3.x products with the configuration (3) used.
To solve this issue, we simply remove pre-defined initial VCC voltage values in UFS core driver with below reasons,
1. UFS specifications do not define how to detect the VCC configuration supported by attached device.
2. Device tree already supports standard regulator properties.
Therefore VCC voltage shall be defined correctly in device tree, and shall not changed by UFS driver. What UFS driver needs to do is simply enable or disable the VCC regulator only.
Similar change is applied to VCCQ and VCCQ2 as well.
Note that we keep struct
ufs_vregunchanged. This is allow vendors to configure propermin_uVandmax_uVof any regulators to makeregulator_set_voltage()works during regulator toggling flow. Without specific vendor configurations,min_uVandmax_uVwill be NULL by default and UFS core driver will enable or disable the regulator only without adjusting its voltage.
Quoted 3 lines
Reviewed-by Bjorn Andersson <[email protected]>Signed-off-by Stanley Chu <[email protected]>---
Quoted 31 lines
drivers/scsi/ufs/ufshcd-pltfrm.c | 16 ---------------- 1 file changed, 16 deletions(-)drivers/scsi/ufs/ufshcd-pltfrm.c +0
-16@@ -133,22 +133,6 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, vreg->max_uA =0 ; } -if (!strcmp (name,"vcc" )) { -if (of_property_read_bool (np,"vcc-supply-1p8" )) { - vreg->min_uV =UFS_VREG_VCC_1P8_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_1P8_MAX_UV ; - }else { - vreg->min_uV =UFS_VREG_VCC_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_MAX_UV ; - } - }else if (!strcmp (name,"vccq" )) { - vreg->min_uV =UFS_VREG_VCCQ_MIN_UV ; - vreg->max_uV =UFS_VREG_VCCQ_MAX_UV ; - }else if (!strcmp (name,"vccq2" )) { - vreg->min_uV =UFS_VREG_VCCQ2_MIN_UV ; - vreg->max_uV =UFS_VREG_VCCQ2_MAX_UV ; - } - goto out; out:
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 55 lines · Stanley Chu
UFS specficication allows different VCC configurations for UFS devices, for example,
(1). 2.70V - 3.60V (Activated by default in UFS core driver) (2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in device tree) (3). 2.40V - 2.70V (Supported since UFS 3.x)With the introduction of UFS 3.x products, an issue is happening that UFS driver will use wrong "min_uV-max_uV" values to configure the voltage of VCC regulator on UFU 3.x products with the configuration (3) used.
To solve this issue, we simply remove pre-defined initial VCC voltage values in UFS core driver with below reasons,
1. UFS specifications do not define how to detect the VCC configuration supported by attached device.
2. Device tree already supports standard regulator properties.
Therefore VCC voltage shall be defined correctly in device tree, and shall not changed by UFS driver. What UFS driver needs to do is simply enable or disable the VCC regulator only.
Similar change is applied to VCCQ and VCCQ2 as well.
Note that we keep struct
ufs_vregunchanged. This is allow vendors to configure propermin_uVandmax_uVof any regulators to makeregulator_set_voltage()works during regulator toggling flow. Without specific vendor configurations,min_uVandmax_uVwill be NULL by default and UFS core driver will enable or disable the regulator only without adjusting its voltage.Reviewed-by Bjorn Andersson <[email protected]>Signed-off-by Stanley Chu <[email protected]>--- drivers/scsi/ufs/ufshcd-pltfrm.c | 16 ---------------- 1 file changed, 16 deletions(-)drivers/scsi/ufs/ufshcd-pltfrm.c +0
-7@@ -133,22 +133,6 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, vreg->max_uA =0 ; } -if (!strcmp (name,"vcc" )) { -if (of_property_read_bool (np,"vcc-supply-1p8" )) { - vreg->min_uV =UFS_VREG_VCC_1P8_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_1P8_MAX_UV ; - }else { - vreg->min_uV =UFS_VREG_VCC_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_MAX_UV ;
drivers/scsi/ufs/ufshcd-pltfrm.c static int ufshcd_populate_vreg(struct device · line 137
Quoted 10 lines
drivers/scsi/ufs/ufshcd-pltfrm.c +0
-9- } - }else if (!strcmp (name,"vccq" )) { - vreg->min_uV =UFS_VREG_VCCQ_MIN_UV ; - vreg->max_uV =UFS_VREG_VCCQ_MAX_UV ; - }else if (!strcmp (name,"vccq2" )) { - vreg->min_uV =UFS_VREG_VCCQ2_MIN_UV ; - vreg->max_uV =UFS_VREG_VCCQ2_MAX_UV ; - } - goto out;
Do we need this "goto out;"?
drivers/scsi/ufs/ufshcd-pltfrm.c static int ufshcd_populate_vreg(struct device · line 138
Quoted 2 lines
drivers/scsi/ufs/ufshcd-pltfrm.c +0
-0out:
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 60 lines · On Wed, 2020-12-02 at 00:19 -0800, [email protected] wrote:
Quoted 59 lines · Stanley Chu
UFS specficication allows different VCC configurations for UFS devices, for example,
(1). 2.70V - 3.60V (Activated by default in UFS core driver) (2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in device tree) (3). 2.40V - 2.70V (Supported since UFS 3.x)With the introduction of UFS 3.x products, an issue is happening that UFS driver will use wrong "min_uV-max_uV" values to configure the voltage of VCC regulator on UFU 3.x products with the configuration (3) used.
To solve this issue, we simply remove pre-defined initial VCC voltage values in UFS core driver with below reasons,
1. UFS specifications do not define how to detect the VCC configuration supported by attached device.
2. Device tree already supports standard regulator properties.
Therefore VCC voltage shall be defined correctly in device tree, and shall not changed by UFS driver. What UFS driver needs to do is simply enable or disable the VCC regulator only.
Similar change is applied to VCCQ and VCCQ2 as well.
Note that we keep struct
ufs_vregunchanged. This is allow vendors to configure propermin_uVandmax_uVof any regulators to makeregulator_set_voltage()works during regulator toggling flow. Without specific vendor configurations,min_uVandmax_uVwill be NULL by default and UFS core driver will enable or disable the regulator only without adjusting its voltage.Reviewed-by Bjorn Andersson <[email protected]>Signed-off-by Stanley Chu <[email protected]>--- drivers/scsi/ufs/ufshcd-pltfrm.c | 16 ---------------- 1 file changed, 16 deletions(-)drivers/scsi/ufs/ufshcd-pltfrm.c +0
-10@@ -133,22 +133,6 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, vreg->max_uA =0 ; } -if (!strcmp (name,"vcc" )) { -if (of_property_read_bool (np,"vcc-supply-1p8" )) { - vreg->min_uV =UFS_VREG_VCC_1P8_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_1P8_MAX_UV ; - }else { - vreg->min_uV =UFS_VREG_VCC_MIN_UV ; - vreg->max_uV =UFS_VREG_VCC_MAX_UV ; - } - }else if (!strcmp (name,"vccq" )) { - vreg->min_uV =UFS_VREG_VCCQ_MIN_UV ;
Quoted 8 lines
drivers/scsi/ufs/ufshcd-pltfrm.c static int ufshcd_populate_vreg(struct device *dev, const char *name, · line 136
Quoted 7 lines
drivers/scsi/ufs/ufshcd-pltfrm.c +0
-6- vreg->max_uV =UFS_VREG_VCCQ_MAX_UV ; - }else if (!strcmp (name,"vccq2" )) { - vreg->min_uV =UFS_VREG_VCCQ2_MIN_UV ; - vreg->max_uV =UFS_VREG_VCCQ2_MAX_UV ; - } - goto out;Do we need this "goto out;"?
Will remove it in next version.
Thanks for remind.
Stanley Chu
Quoted 3 lines
drivers/scsi/ufs/ufshcd-pltfrm.c static int ufshcd_populate_vreg(struct device · line 138
Quoted 3 lines
drivers/scsi/ufs/ufshcd-pltfrm.c +0
-0out:
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek