ASoC: Intel: Boards: tgl_max98373: update TDM slot_width
Subsystems (3)
PATCH 1/1 ASoC: Intel: Boards: tgl_max98373: update TDM slot_width
From: Sathyanarayana Nujella <[email protected]>
Speaker amp's SSP bclk configuration was changed in the topology file to be based on 12.288MHz and dai_ops->hw_params is based on s32le format. But, the TDM slot size remained set to 24 bits.
This inconsistency created audible noises and needs to be corrected. This patch updates TDM slot width to 32.
--- sound/soc/intel/boards/sof_maxim_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/intel/boards/sof_maxim_common.c +2 -2
@@ -49,11 +49,11 @@ static int max98373_hw_params(struct snd_pcm_substream *substream,for_each_rtd_codec_dais (rtd, j, codec_dai) {if (!strcmp (codec_dai->component->name,MAX_98373_DEV0_NAME )) {/* DEV0 tdm slot configuration */ -snd_soc_dai_set_tdm_slot (codec_dai,0x03 ,3 ,8 ,24 ); +snd_soc_dai_set_tdm_slot (codec_dai,0x03 ,3 ,8 ,32 ); }if (!strcmp (codec_dai->component->name,MAX_98373_DEV1_NAME )) {/* DEV1 tdm slot configuration */ -snd_soc_dai_set_tdm_slot (codec_dai,0x0C ,3 ,8 ,24 ); +snd_soc_dai_set_tdm_slot (codec_dai,0x0C ,3 ,8 ,32 ); } }return 0 ;
Signature · 1 line
2.25.1
Mark Brown
maintainerQuoted 7 lines · Ranjani Sridharan
Speaker amp's SSP bclk configuration was changed in the topology file to be based on 12.288MHz and
dai_ops->hw_paramsis based on s32le format. But, the TDM slot size remained set to 24 bits.
This inconsistency created audible noises and needs to be corrected. This patch updates TDM slot width to 32.Fixes bc7477fc2ab4 ("ASoC: Intel: Boards: tgl_max98373: Update TDM configuration in hw_params")
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: Intel: Boards: tgl_max98373: update TDM slot_width
commit: 0d7f2459ae926a964ab211aac413d72074131727
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark