Skip to contentSkip to conversation

hwmon: Add driver for STMicroelectronics PM6764 Voltage Regulator

PATCH Guenter Roeck 2 participants 3 messages Dec 2, 2020 – Dec 4, 2020 1 message not in the archive Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw
Quoted 91 lines · Charles

Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.

the output voltage use the MFR_READ_VOUT 0xD4
vout value returned is linear11

---

v6:
 - Fix misspelling.
v5:
 - Add MAINTAINERS.
 - Add a reference into trivial-devices.yaml. v4:
 - Add pm6764tr to Documentation/hwmon/index.rst. v3:
 - Add Documentation(Documentation/hwmon/pm6764tr.rst).
 - Fix include order.
v2:
 - Fix formatting.
 - Remove pmbus_do_remove.
 - Change from .probe to .probe_new.
v1:
 - Initial patchset.

---
 Documentation/hwmon/index.rst    |  1 +
 Documentation/hwmon/pm6764tr.rst | 32 ++++++++++++++
 MAINTAINERS                      |  7 +++
 drivers/hwmon/pmbus/Kconfig      |  9 ++++
 drivers/hwmon/pmbus/Makefile     |  1 +
 drivers/hwmon/pmbus/pm6764tr.c   | 76 ++++++++++++++++++++++++++++++++
 6 files changed, 126 insertions(+)
 create mode 100644 Documentation/hwmon/pm6764tr.rst
 create mode 100644 drivers/hwmon/pmbus/pm6764tr.c
Documentation/hwmon/index.rst +1 -0
index b797db738225..1bbd05e41de4 100644
@@ -144,6 +144,7 @@ Hardware Monitoring Kernel Drivers
    pc87360
    pc87427
    pcf8591
+   pm6764tr
    pmbus
    powr1220
    pxe1610
Documentation/hwmon/pm6764tr.rst new file +32 -0
new file mode 100644
index 000000000000..a1fb8fea2326
@@ -0,0 +1,32 @@
+.. SPDX-License-Identifier: GPL-2.0-only
+
+Kernel driver pm6764tr
+======================
+
+Supported chips:
+
+  * ST PM6764TR
+
+    Prefix: 'pm6764tr'
+
+    Addresses scanned: -
+
+    Datasheet: http://www.st.com/resource/en/data_brief/pm6764.pdf
+
+Authors:
+	<[email protected]>
+
+Description:
+------------
+
+This driver supports the STMicroelectronics PM6764TR chip. The PM6764TR is a high
+performance digital controller designed to power Intel’s VR12.5 processors and memories.
+
+The device utilizes digital technology to implement all control and power management
+functions to provide maximum flexibility and performance. The NVM is embedded to store
+custom configurations. The PM6764TR device features up to 4-phase programmable operation.
+
+The PM6764TR supports power state transitions featuring VFDE, and programmable DPM
+maintaining the best efficiency over all loading conditions without compromising transient
+response. The device assures fast and independent protection against load overcurrent,
+under/overvoltage and feedback disconnections.
MAINTAINERS +0 -0
index 94ac10a153c7..a3fea132c4ed 100644

MAINTAINERS M: Logan Gunthorpe <[email protected]> · line 13906

Quoted 3 lines
MAINTAINERS +1 -0
@@ -13904,6 +13904,13 @@ M:	Logan Gunthorpe <[email protected]>
 S:	Maintained
 F:	drivers/dma/plx_dma.c
+PM6764TR DRIVER

I dn't know what happened, but this line ...

Quoted 14 lines
MAINTAINERS +6 -0
+M:	Charles Hsu	<[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/hwmon/pm6764tr.rst
+F:	drivers/hwmon/pmbus/pm6764tr.c
+
 PM-GRAPH UTILITY
 M:	"Todd E Brandt" <[email protected]>
 L:	[email protected]
drivers/hwmon/pmbus/Kconfig +0 -0
index a25faf69fce3..9c846facce9f 100644

drivers/hwmon/pmbus/Kconfig config SENSORS_MP2975 · line 222

Quoted 3 lines
drivers/hwmon/pmbus/Kconfig +1 -0
@@ -220,6 +220,15 @@ config SENSORS_MP2975
 	  This driver can also be built as a module. If so, the module will
 	  be called mp2975.
+config SENSORS_PM6764TR

... and this line report that the patch is corrupted when I try to apply it. Looking into the files, there is supposed to be an empty line before "config SENSORS_PM6764TR" and before "PM6764TR DRIVER". If I add those empty lines, the patch applies. checkpatch also reports problems associated with that corruption as well as other problems. On top of that, the patch does not show up in patchwork.

Please fix whatever is causing those problems and resubmit. I would suggest to try to apply the patch yourself with "git am ..." before you send it out.

You'll also need a separate patch to add st,pm6764tr to trivial_devices.

Thanks,
Guenter

Quoted 108 lines
drivers/hwmon/pmbus/Kconfig +8 -0
+	tristate "ST PM6764TR"
+	help
+	  If you say yes here you get hardware monitoring support for ST
+	  PM6764TR.
+
+	  This driver can also be built as a module. If so, the module will
+	  be called pm6764tr.
+
 config SENSORS_PXE1610
 	tristate "Infineon PXE1610"
 	help
drivers/hwmon/pmbus/Makefile +1 -0
index 4c97ad0bd791..31ebdef5d4a6 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_SENSORS_MAX31785)	+= max31785.o
 obj-$(CONFIG_SENSORS_MAX34440)	+= max34440.o
 obj-$(CONFIG_SENSORS_MAX8688)	+= max8688.o
 obj-$(CONFIG_SENSORS_MP2975)	+= mp2975.o
+obj-$(CONFIG_SENSORS_PM6764TR)	+= pm6764tr.o
 obj-$(CONFIG_SENSORS_PXE1610)	+= pxe1610.o
 obj-$(CONFIG_SENSORS_TPS40422)	+= tps40422.o
 obj-$(CONFIG_SENSORS_TPS53679)	+= tps53679.o
drivers/hwmon/pmbus/pm6764tr.c new file +76 -0
new file mode 100644
index 000000000000..70747c21c66e
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Hardware monitoring driver for STMicroelectronics digital controller PM6764TR
+ */
+
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/pmbus.h>
+#include "pmbus.h"
+
+#define PM6764TR_PMBUS_READ_VOUT	0xD4
+
+static int pm6764tr_read_word_data(struct i2c_client *client, int page, int reg)
+{
+	int ret;
+
+	switch (reg) {
+	case PMBUS_VIRT_READ_VMON:
+		ret = pmbus_read_word_data(client, page, PM6764TR_PMBUS_READ_VOUT);
+		break;
+	default:
+		ret = -ENODATA;
+		break;
+	}
+	return ret;
+}
+
+static struct pmbus_driver_info pm6764tr_info = {
+	.pages = 1,
+	.format[PSC_VOLTAGE_IN] = linear,
+	.format[PSC_VOLTAGE_OUT] = vid,
+	.format[PSC_TEMPERATURE] = linear,
+	.format[PSC_CURRENT_OUT] = linear,
+	.format[PSC_POWER] = linear,
+	.func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN |  PMBUS_HAVE_PIN |
+	    PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT | PMBUS_HAVE_VMON |
+		PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_VOUT |
+		PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP,
+	.read_word_data = pm6764tr_read_word_data,
+};
+
+static int pm6764tr_probe(struct i2c_client *client,
+			  const struct i2c_device_id *id)
+{
+	return pmbus_do_probe(client, id, &pm6764tr_info);
+}
+
+static const struct i2c_device_id pm6764tr_id[] = {
+	{"pm6764tr", 0},
+	{}
+};
+MODULE_DEVICE_TABLE(i2c, pm6764tr_id);
+
+static const struct of_device_id pm6764tr_of_match[] = {
+	{.compatible = "st,pm6764tr"},
+	{}
+};
+
+/* This is the driver that will be inserted */
+static struct i2c_driver pm6764tr_driver = {
+	.driver = {
+		   .name = "pm6764tr",
+		   .of_match_table = of_match_ptr(pm6764tr_of_match),
+		   },
+	.probe_new = pm6764tr_probe,
+	.id_table = pm6764tr_id,
+};
+
+module_i2c_driver(pm6764tr_driver);
+
+MODULE_AUTHOR("Charles Hsu");
+MODULE_DESCRIPTION("PMBus driver for  ST PM6764TR");
+MODULE_LICENSE("GPL");
Signature · 1 line
2.25.1
author maintainer
#2 lore raw
In reply to a message not in the archive

On Thu, Dec 03, 2020 at 08:34:32PM +0800, Charles wrote:
[ ... ]

Review config SENSORS_MP2975 · line 223

Quoted 7 lines

It's really weird. I sent a mail to myself, and it looks good.

(quoted diff) +1 -0
@@ -220,6 +220,15 @@ config SENSORS_MP2975
 	  This driver can also be built as a module. If so, the module will
 	  be called mp2975.
+config SENSORS_PM6764TR
 

But the above doesn't look good. The empty line is again missing. It looks like your e-mail system manipulates/modifies the message and removes that line.

Quoted 4 lines

I have applied my patch with "git am", and it did work.
Applying: Add-driver-for-STMicroelectronics-PM6764-Voltage-Regulator

I think I should use another e-mail system.

That may be a good idea. FWIW, I use msmtp, and git send-email.

Thanks,
Guenter

#3 lore raw
Quoted 12 lines · Guenter Roeck

On Thu, Dec 03, 2020 at 08:34:32PM +0800, Charles wrote:
[ ... ]

Review config SENSORS_MP2975 · line 223

Quoted 6 lines

It's really weird. I sent a mail to myself, and it looks good.

(quoted diff) +1 -0
@@ -220,6 +220,15 @@ config SENSORS_MP2975
  	  This driver can also be built as a module. If so, the module will
  	  be called mp2975.
+config SENSORS_PM6764TR
 

But the above doesn't look good. The empty line is again missing. It looks like your e-mail system manipulates/modifies the message and removes that line.

Quoted 8 lines
Quoted 4 lines

I have applied my patch with "git am", and it did work.
Applying: Add-driver-for-STMicroelectronics-PM6764-Voltage-Regulator

I think I should use another e-mail system.

That may be a good idea. FWIW, I use msmtp, and git send-email.

Thanks,
Guenter

I will try this way to send my patch, thank you.

Charles