soc: samsung: exynos-chipid: order list of SoCs by name
Krzysztof Kozlowski
maintainerPATCH 1/2 soc: samsung: exynos-chipid: order list of SoCs by name
Bring some order to the list of SoCs. No functional change.
--- drivers/soc/samsung/exynos-chipid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/samsung/exynos-chipid.c +2 -1
@@ -20,6 +20,7 @@ static const struct exynos_soc_id {const char *name;unsigned int id; } soc_ids[] = { +/* List ordered by SoC name */ { "EXYNOS3250", 0xE3472000 }, { "EXYNOS4210", 0x43200000 }, /* EVT0 revision */ { "EXYNOS4210", 0x43210000 },
@@ -29,10 +30,10 @@ static const struct exynos_soc_id { { "EXYNOS5260", 0xE5260000 }, { "EXYNOS5410", 0xE5410000 }, { "EXYNOS5420", 0xE5420000 }, + { "EXYNOS5433", 0xE5433000 }, { "EXYNOS5440", 0xE5440000 }, { "EXYNOS5800", 0xE5422000 }, { "EXYNOS7420", 0xE7420000 }, - { "EXYNOS5433", 0xE5433000 }, };static const char *__init product_id_to_soc_id (unsigned int product_id)
Signature · 1 line
2.25.1
Krzysztof Kozlowski
maintainerPATCH 2/2 soc: samsung: exynos-chipid: initialize later - with arch_initcall
The Exynos ChipID driver on Exynos SoCs has only informational purpose - to expose the SoC device in sysfs. No other drivers depend on it so there is really no benefit of initializing it early.
Instead, initialize everything with arch_initcall which:
1. Allows to use dev_info() as the SoC bus is present (since core_initcall),
2. Could speed things up because of execution in a SMP environment (after bringing up secondary CPUs, unlike early_initcall),
3. Reduces the amount of work to be done early, when the kernel has to bring up critical devices.
--- drivers/soc/samsung/exynos-chipid.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/soc/samsung/exynos-chipid.c +4 -4
@@ -99,9 +99,9 @@ static int __init exynos_chipid_early_init(void) goto err; } -/* it is too early to use dev_info() here (soc_dev is NULL) */ -pr_info ("soc soc0: Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n" , - soc_dev_attr->soc_id, product_id, revision); +dev_info (soc_device_to_device (soc_dev), +"Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n" , + soc_dev_attr->soc_id, product_id, revision);return 0 ;
@@ -111,4 +111,4 @@ static int __init exynos_chipid_early_init(void)return ret; } -early_initcall (exynos_chipid_early_init); +arch_initcall (exynos_chipid_early_init);
Signature · 1 line
2.25.1
Quoted 1 line · Krzysztof Kozlowski
Bring some order to the list of SoCs. No functional change.
Applied, thanks!
[1/2] soc: samsung: exynos-chipid: order list of SoCs by name [2/2] soc: samsung: exynos-chipid: initialize later - with arch_initcall
commit: 3b4c362e5ef102ca2d70d33f4e8cf0780053a7db
Best regards,
Signature · 6 lines
Krzysztof Kozlowski <[email protected]> _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel